Re: [PATCH v3 5/5] arm64: dts: qcom: Add device tree for SA8797P Ride board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Thermal zones lack 'critical' trip points, disabling emergency thermal shutdown and risking hardware damage or data corruption.
--

commit aa64a0535c6c55bb78850bd4e6509abadf2cf760
Author: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for SA8797P Ride board

This commit adds the initial device tree for the Qualcomm SA8797P Ride
reference board. It configures primary and secondary UART consoles,
enables UFS storage support, and defines thermal zones for PMIC dies,
UFS, and SDRAM sensors.

> diff --git a/arch/arm64/boot/dts/qcom/sa8797p-ride.dts b/arch/arm64/boot/dts/qcom/sa8797p-ride.dts
> new file mode 100644
> index 0000000000000..d429de313f248
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sa8797p-ride.dts
[ ... ]
> +&thermal_zones {
> +	pm_kobra_thermal: pm-a-die-thermal {
> +		polling-delay-passive = <100>;
> +		polling-delay = <0>;
> +		thermal-sensors = <&scmi23_sensor 3>;
> +
> +		trips {
> +			trip0 {
> +				temperature = <115000>;
> +				hysteresis = <5000>;
> +				type = "passive";
> +			};
> +
> +			trip1 {
> +				temperature = <135000>;
> +				hysteresis = <5000>;
> +				type = "passive";

[Severity: High]
Should this upper trip point be configured as a critical trip instead
of a passive one?

Since all thermal zones in this file use passive for their maximum
temperature thresholds and omit cooling maps, the thermal framework
will not trigger any mitigations. 

Missing a critical trip also prevents the kernel from performing an orderly
thermal shutdown when these high temperatures are reached. Even if the
underlying hardware or SCMI firmware implements an abrupt hard cutoff,
defining a critical trip point allows the operating system to shut down
cleanly and prevents potential filesystem corruption.

> +			};
> +		};
> +	};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526034557.1669007-1-shengchao.guo@oss.qualcomm.com?part=5