Re: [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The patch fails to add the `bootph-all` property to UART and `syscfg` nodes, contradicting the commit message, and modifies unmentioned nodes.
- [Low] Incorrect double-tab indentation for the `bootph-all` property inside the `&timer5` node.
--

commit 46ae77600efc54228af475f90f412a5aaa703ea3
Author: Patrice Chotard <patrice.chotard@foss.st.com>

ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards

The bootph-all flag was introduced to define node usage across different
boot phases. This commit adds the bootph-all phase flag to several nodes
to ensure SD boot is supported across all boot stages.

> To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be
> present in all boot stages, so add missing bootph-all phase flag
> to these nodes to support SD boot.

[Severity: High]
The commit message states that syscfg and uart nodes are modified to support
SD boot, but the patch doesn't appear to add the bootph-all flag to them.

Since the pinctrl node depends on syscfg, if syscfg is missing from the early
boot device tree, could pinctrl fail to probe in SPL? Would this prevent
SDMMC from functioning and break the early serial console if the UART nodes
are also missing?

> diff --git a/arch/arm/boot/dts/st/stm32h743i-disco.dts b/arch/arm/boot/dts/st/stm32h743i-disco.dts
> index 78d55b77db7ce..1b4b9bc5c72dd 100644
> --- a/arch/arm/boot/dts/st/stm32h743i-disco.dts
> +++ b/arch/arm/boot/dts/st/stm32h743i-disco.dts
[ ... ]
> +&pinctrl {
> +	bootph-all;
> +};
> +
> +&pwrcfg {
> +	bootph-all;
> +};

[Severity: High]
Was pwrcfg added here by mistake instead of the syscfg node mentioned in
the commit message?

[ ... ]
> +&timer5 {
> +	bootph-all;
> +};
> +
>  &usart2 {
>  	pinctrl-0 = <&usart2_pins_a>;
>  	pinctrl-names = "default";

[Severity: High]
Did this usart node also need the bootph-all property added to support
the early serial console, as mentioned in the commit message?

> diff --git a/arch/arm/boot/dts/st/stm32h743i-eval.dts b/arch/arm/boot/dts/st/stm32h743i-eval.dts
> index e5e10b0758eea..55674fe054311 100644
> --- a/arch/arm/boot/dts/st/stm32h743i-eval.dts
> +++ b/arch/arm/boot/dts/st/stm32h743i-eval.dts
[ ... ]
> +&timer5 {
> +		bootph-all;
> +};

[Severity: Low]
This isn't a bug, but there appears to be an extra tab used for indentation
here. The same extra tab is also present in stm32h747i-disco.dts and
stm32h750i-art-pi.dts.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=3