* [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards
@ 2026-05-26 9:26 Patrice Chotard
2026-05-26 9:26 ` [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards Patrice Chotard
` (6 more replies)
0 siblings, 7 replies; 16+ messages in thread
From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier,
Marek Vasut
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel,
Patrice Chotard
The bootph-all flag was introduced in dt-schema
(dtschema/schemas/bootph.yaml) to define node usage across
different boot phases.
To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be
present in all boot stages, so add missing bootph-all phase flag
to these nodes to support SD boot.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
Changes in v7:
- Rebase on top of stm32-next.
_ Fix sdmmc2_b4_pins_a's node in stm32mp15xx-dhcom-som.dtsi.
- Link to v6: https://lore.kernel.org/r/20260203-upstream_uboot_properties-v6-0-0a2280e84d31@foss.st.com
Changes in v6:
- Add bootph-all property in syscfg node of stm32mp215f-dk.dtsi.
- Split patch 4 in 2 parts, first part for reordering nodes, second part
for adding bootph-all property.
- Rebase on top of stm32-dt-for-v6.20-1.
- Link to v5: https://lore.kernel.org/r/20260123-upstream_uboot_properties-v5-0-5167929d5af5@foss.st.com
Changes in v5:
- Initial implementation allows to factorize and add bootph-* properties in a limited number of DT files.
After internal discussion with Alexandre, choice has been done to add bootph-* properties only
in board DT files instead of SoCs/pinctrl/boards DT files.This impacts a greater number of DT boards files.
- Link to v4: https://lore.kernel.org/r/20260109-upstream_uboot_properties-v4-0-75e06657c600@foss.st.com
Changes in v4:
- Remove useless nodes in stm32mp15-scmi.dtsi
- Link to v3: https://lore.kernel.org/r/20260108-upstream_uboot_properties-v3-0-c1b9d4f2ce8d@foss.st.com
Changes in v3:
- Remove duplicate bootph-all property in ltdc node
- Link to v2: https://lore.kernel.org/r/20251114-upstream_uboot_properties-v2-0-3784ff668ae0@foss.st.com
Changes in v2:
- Fix 'pinmux' is a required property for arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dtb
- Add bootph-all property for lvds and ltdc nodes for stm32mp2
---
Patrice Chotard (7):
ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards
ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards
ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards
ARM: dts: stm32: Sort uart nodes by alphabetical order in stm32mp13xx-dhcor-som.dtsi
ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards
ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards
arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards
arch/arm/boot/dts/st/stm32429i-eval.dts | 80 ++++++++++
arch/arm/boot/dts/st/stm32746g-eval.dts | 10 ++
arch/arm/boot/dts/st/stm32f429-disco.dts | 80 ++++++++++
arch/arm/boot/dts/st/stm32f469-disco.dts | 72 +++++++++
arch/arm/boot/dts/st/stm32f746-disco.dts | 75 +++++++++
arch/arm/boot/dts/st/stm32f746.dtsi | 2 +-
arch/arm/boot/dts/st/stm32f769-disco.dts | 76 ++++++++-
arch/arm/boot/dts/st/stm32h743i-disco.dts | 69 ++++++++
arch/arm/boot/dts/st/stm32h743i-eval.dts | 69 ++++++++
arch/arm/boot/dts/st/stm32h747i-disco.dts | 69 ++++++++
arch/arm/boot/dts/st/stm32h750i-art-pi.dts | 69 ++++++++
arch/arm/boot/dts/st/stm32mp131.dtsi | 4 +-
arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts | 21 +++
arch/arm/boot/dts/st/stm32mp135f-dk.dts | 101 ++++++++++++
arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi | 145 ++++++++++++++---
arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +-
arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts | 19 +++
.../st/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts | 1 +
.../dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts | 25 +++
.../dts/st/stm32mp157a-icore-stm32mp1-edimm2.2.dts | 26 +++
.../boot/dts/st/stm32mp157a-icore-stm32mp1.dtsi | 100 ++++++++++++
...m32mp157a-microgea-stm32mp1-microdev2.0-of7.dts | 27 ++++
.../stm32mp157a-microgea-stm32mp1-microdev2.0.dts | 27 ++++
.../boot/dts/st/stm32mp157a-microgea-stm32mp1.dtsi | 97 ++++++++++++
arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts | 5 +
arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 1 +
arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts | 19 +++
arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 151 ++++++++++++++++++
arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts | 5 +
arch/arm/boot/dts/st/stm32mp157c-ev1.dts | 38 +++++
arch/arm/boot/dts/st/stm32mp157c-lxa-mc1.dts | 1 +
arch/arm/boot/dts/st/stm32mp157c-odyssey-som.dtsi | 119 ++++++++++++++
arch/arm/boot/dts/st/stm32mp157c-odyssey.dts | 21 +++
arch/arm/boot/dts/st/stm32mp157c-osd32mp1-red.dts | 1 +
arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi | 5 +
arch/arm/boot/dts/st/stm32mp157f-dk2.dts | 1 +
arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi | 2 +-
arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi | 175 +++++++++++++++++++++
.../boot/dts/st/stm32mp15xx-dhcor-avenger96.dtsi | 55 +++++++
.../boot/dts/st/stm32mp15xx-dhcor-drc-compact.dtsi | 50 ++++++
arch/arm/boot/dts/st/stm32mp15xx-dhcor-som.dtsi | 157 ++++++++++++++++++
.../boot/dts/st/stm32mp15xx-dhcor-testbench.dtsi | 50 ++++++
arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi | 122 ++++++++++++++
arch/arm64/boot/dts/st/stm32mp211.dtsi | 4 +-
arch/arm64/boot/dts/st/stm32mp215f-dk.dts | 29 ++++
arch/arm64/boot/dts/st/stm32mp231.dtsi | 4 +-
arch/arm64/boot/dts/st/stm32mp235f-dk.dts | 95 +++++++++++
arch/arm64/boot/dts/st/stm32mp251.dtsi | 4 +-
arch/arm64/boot/dts/st/stm32mp255.dtsi | 2 +-
arch/arm64/boot/dts/st/stm32mp257f-dk.dts | 103 ++++++++++++
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 105 +++++++++++++
51 files changed, 2552 insertions(+), 38 deletions(-)
---
base-commit: a0d6c2a06fffff47bcca4d5bfdab4cc428a315fc
change-id: 20251112-upstream_uboot_properties-22480b0b4b1c
Best regards,
--
Patrice Chotard <patrice.chotard@foss.st.com>
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 9:41 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards Patrice Chotard ` (5 subsequent siblings) 6 siblings, 1 reply; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard The bootph-all flag was introduced in dt-schema (dtschema/schemas/bootph.yaml) to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be present in all boot stages, so add missing bootph-all phase flag to these nodes to support SD boot. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/boot/dts/st/stm32429i-eval.dts | 80 ++++++++++++++++++++++++++++++++ arch/arm/boot/dts/st/stm32f429-disco.dts | 80 ++++++++++++++++++++++++++++++++ arch/arm/boot/dts/st/stm32f469-disco.dts | 72 ++++++++++++++++++++++++++++ 3 files changed, 232 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32429i-eval.dts b/arch/arm/boot/dts/st/stm32429i-eval.dts index f4b1c4eb64f2..8a08b9f6b837 100644 --- a/arch/arm/boot/dts/st/stm32429i-eval.dts +++ b/arch/arm/boot/dts/st/stm32429i-eval.dts @@ -188,6 +188,15 @@ adc3: adc@200 { &clk_hse { clock-frequency = <25000000>; + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_i2s_ckin { + bootph-all; }; &crc { @@ -209,6 +218,50 @@ dcmi_0: endpoint { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + &i2c1 { pinctrl-0 = <&i2c1_pins>; pinctrl-names = "default"; @@ -278,6 +331,18 @@ phy1: ethernet-phy@1 { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &rtc { status = "okay"; }; @@ -293,6 +358,10 @@ &sdio { max-frequency = <12500000>; }; +&syscfg { + bootph-all; +}; + &timers1 { status = "okay"; @@ -325,6 +394,7 @@ &timers5 { /* Override timer5 to act as clockevent */ compatible = "st,stm32-timer"; interrupts = <50>; + bootph-all; status = "okay"; /delete-property/#address-cells; /delete-property/#size-cells; @@ -339,6 +409,16 @@ &usart1 { status = "okay"; }; +&usart1_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_hs { dr_mode = "host"; phys = <&usbotg_hs_phy>; diff --git a/arch/arm/boot/dts/st/stm32f429-disco.dts b/arch/arm/boot/dts/st/stm32f429-disco.dts index ded369abee4f..047845ab3d5f 100644 --- a/arch/arm/boot/dts/st/stm32f429-disco.dts +++ b/arch/arm/boot/dts/st/stm32f429-disco.dts @@ -113,12 +113,65 @@ vcc5v_otg: vcc5v-otg-regulator { &clk_hse { clock-frequency = <8000000>; + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_i2s_ckin { + bootph-all; }; &crc { status = "okay"; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + &i2c3 { pinctrl-names = "default"; pinctrl-0 = <&i2c3_pins>; @@ -176,6 +229,18 @@ ltdc_out_rgb: endpoint { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &rtc { assigned-clocks = <&rcc 1 CLK_RTC>; assigned-clock-parents = <&rcc 1 CLK_LSI>; @@ -216,10 +281,15 @@ panel_in_rgb: endpoint { }; }; +&syscfg { + bootph-all; +}; + &timers5 { /* Override timer5 to act as clockevent */ compatible = "st,stm32-timer"; interrupts = <50>; + bootph-all; status = "okay"; /delete-property/#address-cells; /delete-property/#size-cells; @@ -234,6 +304,16 @@ &usart1 { status = "okay"; }; +&usart1_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_hs { compatible = "st,stm32f4x9-fsotg"; dr_mode = "host"; diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts index 943afba06b5f..ecd33d6003b3 100644 --- a/arch/arm/boot/dts/st/stm32f469-disco.dts +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts @@ -181,7 +181,52 @@ dsi_panel_in: endpoint { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + <dc { + bootph-all; status = "okay"; port { @@ -191,10 +236,26 @@ ltdc_out_dsi: endpoint { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &rtc { status = "okay"; }; +&syscfg { + bootph-all; +}; + &timers1 { status = "okay"; @@ -238,6 +299,7 @@ &timers5 { /* Override timer5 to act as clockevent */ compatible = "st,stm32-timer"; interrupts = <50>; + bootph-all; status = "okay"; /delete-property/#address-cells; /delete-property/#size-cells; @@ -252,6 +314,16 @@ &usart3 { status = "okay"; }; +&usart3_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_fs { dr_mode = "host"; pinctrl-0 = <&usbotg_fs_pins_a>; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards 2026-05-26 9:26 ` [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards Patrice Chotard @ 2026-05-26 9:41 ` sashiko-bot 2026-05-26 15:52 ` Patrice CHOTARD 0 siblings, 1 reply; 16+ messages in thread From: sashiko-bot @ 2026-05-26 9:41 UTC (permalink / raw) To: Patrice Chotard; +Cc: conor+dt, robh, devicetree Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider: - [High] The `&sdio` controller nodes are missing the `bootph-all` property, contradicting the stated goal of supporting SD boot. - [Medium] The `bootph-all` flag is missing for the clock nodes (e.g., `&clk_hse`) in `stm32f469-disco.dts`. - [Medium] UART controller nodes are omitted from `bootph-all` tagging despite the commit message claiming otherwise. - [Low] The `bootph-all` property is incorrectly added to the LCD-TFT display controller (`<dc`) in `stm32f469-disco.dts`. - [Low] A duplicate `&rcc` node reference is created in `stm32f469-disco.dts`. -- commit 7a940b6d4b0cb2432e629736b8cac85e1dd3638f Author: Patrice Chotard <patrice.chotard@foss.st.com> ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards This commit introduces the bootph-all flag to several device tree nodes across STM32 f4 boards. It targets nodes like timer, gpio, syscfg, clock, and uart to ensure they are present during all boot stages for SD boot support. > diff --git a/arch/arm/boot/dts/st/stm32429i-eval.dts b/arch/arm/boot/dts/st/stm32429i-eval.dts > index f4b1c4eb64f28..8a08b9f6b8371 100644 > --- a/arch/arm/boot/dts/st/stm32429i-eval.dts > +++ b/arch/arm/boot/dts/st/stm32429i-eval.dts [ ... ] > @@ -293,6 +358,10 @@ &sdio { > max-frequency = <12500000>; > }; [Severity: High] The commit message states the goal is to ensure SD boot, but the &sdio node does not receive the bootph-all tag here. Will this cause the SDIO controller to be stripped from the SPL device tree and break early SD boot capabilities? > > +&syscfg { > + bootph-all; > +}; > + > &timers1 { > status = "okay"; [ ... ] > @@ -339,6 +409,16 @@ &usart1 { > status = "okay"; > }; [Severity: Medium] The commit message mentions adding the tag to uart nodes. While the pinctrl configuration for the UART receives the tag below, the core &usart1 node does not. Could this result in the UART controller being omitted during early boot stages, breaking early console initialization? > > +&usart1_pins_a { > + bootph-all; > + pins1 { > + bootph-all; > + }; [ ... ] > diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts > index 943afba06b5fe..ecd33d6003b34 100644 > --- a/arch/arm/boot/dts/st/stm32f469-disco.dts > +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts [Severity: Medium] The commit message states the bootph-all flag is added to clock nodes, and other boards in this patch update their &clk_hse nodes. Is it missing for the &clk_hse node in stm32f469-disco.dts, and might this cause the clock to be stripped out during early boot? > @@ -181,7 +181,52 @@ dsi_panel_in: endpoint { [ ... ] > <dc { > + bootph-all; > status = "okay"; > > port { [Severity: Low] Does the LCD-TFT display controller need to be present in early boot phases like SPL or TPL? Including it might needlessly inflate the device tree size in SRAM, as display initialization isn't typically required for SD boot. > @@ -191,10 +236,26 @@ ltdc_out_dsi: endpoint { > }; > }; > > +&pinctrl { > + bootph-all; > +}; > + > +&pwrcfg { > + bootph-all; > +}; > + > +&rcc { > + bootph-all; > +}; [Severity: Low] Does appending this new &rcc block create a duplicate node reference? Since an &rcc block already exists earlier in the file, would it be better to add this property to the existing block to keep related properties grouped together? > + > &rtc { > status = "okay"; > }; [ ... ] > @@ -252,6 +314,16 @@ &usart3 { > status = "okay"; > }; [Severity: Medium] Similar to the &usart1 node in stm32429i-eval.dts, the core &usart3 node here is missing the bootph-all tag, even though the pins below receive it. Should the uart node itself be tagged to ensure it is preserved during early boot? > > +&usart3_pins_a { > + bootph-all; -- Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=1 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards 2026-05-26 9:41 ` sashiko-bot @ 2026-05-26 15:52 ` Patrice CHOTARD 0 siblings, 0 replies; 16+ messages in thread From: Patrice CHOTARD @ 2026-05-26 15:52 UTC (permalink / raw) To: sashiko-reviews; +Cc: conor+dt, robh, devicetree On 5/26/26 11:41, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider: > - [High] The `&sdio` controller nodes are missing the `bootph-all` property, contradicting the stated goal of supporting SD boot. > - [Medium] The `bootph-all` flag is missing for the clock nodes (e.g., `&clk_hse`) in `stm32f469-disco.dts`. > - [Medium] UART controller nodes are omitted from `bootph-all` tagging despite the commit message claiming otherwise. > - [Low] The `bootph-all` property is incorrectly added to the LCD-TFT display controller (`<dc`) in `stm32f469-disco.dts`. > - [Low] A duplicate `&rcc` node reference is created in `stm32f469-disco.dts`. > -- > > commit 7a940b6d4b0cb2432e629736b8cac85e1dd3638f > Author: Patrice Chotard <patrice.chotard@foss.st.com> > > ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards > > This commit introduces the bootph-all flag to several device tree nodes across > STM32 f4 boards. It targets nodes like timer, gpio, syscfg, clock, and uart > to ensure they are present during all boot stages for SD boot support. > >> diff --git a/arch/arm/boot/dts/st/stm32429i-eval.dts b/arch/arm/boot/dts/st/stm32429i-eval.dts >> index f4b1c4eb64f28..8a08b9f6b8371 100644 >> --- a/arch/arm/boot/dts/st/stm32429i-eval.dts >> +++ b/arch/arm/boot/dts/st/stm32429i-eval.dts > [ ... ] >> @@ -293,6 +358,10 @@ &sdio { >> max-frequency = <12500000>; >> }; > > [Severity: High] > The commit message states the goal is to ensure SD boot, but the &sdio node > does not receive the bootph-all tag here. Will this cause the SDIO controller > to be stripped from the SPL device tree and break early SD boot capabilities? The property bootph-all is not needed in sdio node as sdio is only needed after U-Boot relocation phase. I will update the commit message accordingly. > >> >> +&syscfg { >> + bootph-all; >> +}; >> + >> &timers1 { >> status = "okay"; > [ ... ] >> @@ -339,6 +409,16 @@ &usart1 { >> status = "okay"; >> }; > > [Severity: Medium] > The commit message mentions adding the tag to uart nodes. While the pinctrl > configuration for the UART receives the tag below, the core &usart1 node does > not. Could this result in the UART controller being omitted during early boot > stages, breaking early console initialization? bootph-all property is only needed for pinctrl configuration of uart1 node. > >> >> +&usart1_pins_a { >> + bootph-all; >> + pins1 { >> + bootph-all; >> + }; > [ ... ] >> diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts >> index 943afba06b5fe..ecd33d6003b34 100644 >> --- a/arch/arm/boot/dts/st/stm32f469-disco.dts >> +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts > > [Severity: Medium] > The commit message states the bootph-all flag is added to clock nodes, and > other boards in this patch update their &clk_hse nodes. Is it missing for > the &clk_hse node in stm32f469-disco.dts, and might this cause the clock to be > stripped out during early boot? bootph-all property is not needed in clk_hse, clk_lse and clk_i2s_ckin nodes of stm32f429-disco.dts and in stm32429i-eval.dts. I will remove them. > >> @@ -181,7 +181,52 @@ dsi_panel_in: endpoint { > [ ... ] >> <dc { >> + bootph-all; >> status = "okay"; >> >> port { > > [Severity: Low] > Does the LCD-TFT display controller need to be present in early boot phases > like SPL or TPL? Including it might needlessly inflate the device tree size > in SRAM, as display initialization isn't typically required for SD boot. The bootph-all property is needed in <dc block as frame buffer memory allocation is done before U-Boot relocation. > >> @@ -191,10 +236,26 @@ ltdc_out_dsi: endpoint { >> }; >> }; >> >> +&pinctrl { >> + bootph-all; >> +}; >> + >> +&pwrcfg { >> + bootph-all; >> +}; >> + >> +&rcc { >> + bootph-all; >> +}; > > [Severity: Low] > Does appending this new &rcc block create a duplicate node reference? Since > an &rcc block already exists earlier in the file, would it be better to add > this property to the existing block to keep related properties grouped > together? Correct, i will merge both &rcc blocks together. > >> + >> &rtc { >> status = "okay"; >> }; > [ ... ] >> @@ -252,6 +314,16 @@ &usart3 { >> status = "okay"; >> }; > > [Severity: Medium] > Similar to the &usart1 node in stm32429i-eval.dts, the core &usart3 node here > is missing the bootph-all tag, even though the pins below receive it. Should > the uart node itself be tagged to ensure it is preserved during early boot? The uart node doesn't need to be tagged with bootph-all. > >> >> +&usart3_pins_a { >> + bootph-all; > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 9:54 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards Patrice Chotard ` (4 subsequent siblings) 6 siblings, 1 reply; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard The bootph-all flag was introduced in dt-schema (dtschema/schemas/bootph.yaml) to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be present in all boot stages, so add missing bootph-all phase flag to these nodes to support SD boot. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/boot/dts/st/stm32746g-eval.dts | 10 +++++ arch/arm/boot/dts/st/stm32f746-disco.dts | 75 +++++++++++++++++++++++++++++++ arch/arm/boot/dts/st/stm32f746.dtsi | 2 +- arch/arm/boot/dts/st/stm32f769-disco.dts | 76 ++++++++++++++++++++++++++++++-- 4 files changed, 158 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/st/stm32746g-eval.dts b/arch/arm/boot/dts/st/stm32746g-eval.dts index 6772c1f9d03e..d66b670de6f2 100644 --- a/arch/arm/boot/dts/st/stm32746g-eval.dts +++ b/arch/arm/boot/dts/st/stm32746g-eval.dts @@ -226,6 +226,16 @@ &usart1 { status = "okay"; }; +&usart1_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_hs { dr_mode = "otg"; phys = <&usbotg_hs_phy>; diff --git a/arch/arm/boot/dts/st/stm32f746-disco.dts b/arch/arm/boot/dts/st/stm32f746-disco.dts index 61ca41ea523e..5db37bbe6c2a 100644 --- a/arch/arm/boot/dts/st/stm32f746-disco.dts +++ b/arch/arm/boot/dts/st/stm32f746-disco.dts @@ -150,6 +150,51 @@ panel_in_rgb: endpoint { &clk_hse { clock-frequency = <25000000>; + bootph-all; +}; + +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; }; &i2c1 { @@ -179,6 +224,7 @@ touchscreen@38 { <dc { pinctrl-0 = <<dc_pins_a>; pinctrl-names = "default"; + bootph-all; status = "okay"; port { @@ -188,6 +234,22 @@ ltdc_out_rgb: endpoint { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + +&soc { + bootph-all; +}; + &sdio1 { status = "okay"; vmmc-supply = <&vcc_3v3>; @@ -203,6 +265,7 @@ &timers5 { /* Override timer5 to act as clockevent */ compatible = "st,stm32-timer"; interrupts = <50>; + bootph-all; status = "okay"; /delete-property/#address-cells; /delete-property/#size-cells; @@ -214,9 +277,21 @@ &timers5 { &usart1 { pinctrl-0 = <&usart1_pins_b>; pinctrl-names = "default"; + bootph-all; status = "okay"; }; + +&usart1_pins_b { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_fs { dr_mode = "host"; pinctrl-0 = <&usbotg_fs_pins_a>; diff --git a/arch/arm/boot/dts/st/stm32f746.dtsi b/arch/arm/boot/dts/st/stm32f746.dtsi index 208f8c6dfc9d..1fede5bdc347 100644 --- a/arch/arm/boot/dts/st/stm32f746.dtsi +++ b/arch/arm/boot/dts/st/stm32f746.dtsi @@ -75,7 +75,7 @@ clk_i2s_ckin: clk-i2s-ckin { }; }; - soc { + soc: soc { timers2: timers@40000000 { #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts index e5854fa1071b..7338e78847b6 100644 --- a/arch/arm/boot/dts/st/stm32f769-disco.dts +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts @@ -128,10 +128,6 @@ vcc_3v3: vcc-3v3 { }; }; -&rcc { - compatible = "st,stm32f769-rcc", "st,stm32f746-rcc", "st,stm32-rcc"; -}; - &cec { pinctrl-0 = <&cec_pins_a>; pinctrl-names = "default"; @@ -140,11 +136,13 @@ &cec { &clk_hse { clock-frequency = <25000000>; + bootph-all; }; &dsi { #address-cells = <1>; #size-cells = <0>; + bootph-all; status = "okay"; ports { @@ -181,6 +179,50 @@ dsi_panel_in: endpoint { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + &i2c1 { pinctrl-0 = <&i2c1_pins_b>; pinctrl-names = "default"; @@ -190,6 +232,7 @@ &i2c1 { }; <dc { + bootph-all; status = "okay"; port { @@ -199,6 +242,19 @@ ltdc_out_dsi: endpoint { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + compatible = "st,stm32f769-rcc", "st,stm32f746-rcc", "st,stm32-rcc"; + bootph-all; +}; + &rtc { status = "okay"; }; @@ -219,6 +275,7 @@ &timers5 { /* Override timer5 to act as clockevent */ compatible = "st,stm32-timer"; interrupts = <50>; + bootph-all; status = "okay"; /delete-property/#address-cells; /delete-property/#size-cells; @@ -230,9 +287,20 @@ &timers5 { &usart1 { pinctrl-0 = <&usart1_pins_a>; pinctrl-names = "default"; + bootph-all; status = "okay"; }; +&usart1_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_hs { dr_mode = "otg"; phys = <&usbotg_hs_phy>; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards 2026-05-26 9:26 ` [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards Patrice Chotard @ 2026-05-26 9:54 ` sashiko-bot 2026-05-26 16:31 ` Patrice CHOTARD 0 siblings, 1 reply; 16+ messages in thread From: sashiko-bot @ 2026-05-26 9:54 UTC (permalink / raw) To: Patrice Chotard; +Cc: devicetree, conor+dt, robh Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider: - [High] The patch completely omits necessary `bootph-all` tags for the `stm32746g-eval.dts` board. - [High] Missing `bootph-all` on SDIO controller nodes despite the patch claiming to support SD boot. - [High] The `&soc` parent bus node lacks the `bootph-all` tag in `stm32f769-disco.dts` and `stm32746g-eval.dts`. - [High] The patch tags `pwrcfg` instead of the `syscfg` node claimed in the commit message, breaking `pinctrl` initialization. - [Low] The patch erroneously adds `bootph-all` tags to display-related nodes (`<dc` and `&dsi`), which are unrelated to SD boot. -- commit 616809e6aaaad31d633ea36ad66133cc44b7b361 Author: Patrice Chotard <patrice.chotard@foss.st.com> ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards The bootph-all flag was introduced in dt-schema to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock, and uart nodes need to be present in all boot stages, so this patch adds the missing flags. > diff --git a/arch/arm/boot/dts/st/stm32746g-eval.dts b/arch/arm/boot/dts/st/stm32746g-eval.dts > --- a/arch/arm/boot/dts/st/stm32746g-eval.dts > +++ b/arch/arm/boot/dts/st/stm32746g-eval.dts [ ... ] > @@ -226,6 +226,16 @@ &usart1 { > status = "okay"; > }; > > +&usart1_pins_a { > + bootph-all; > + pins1 { > + bootph-all; > + }; > + pins2 { > + bootph-all; > + }; > +}; [Severity: High] The commit message mentions adding tags to timer, gpio, syscfg, clock, and uart nodes, but for this board only the usart1 pin configuration is modified. Are controllers like &usart1, &timers5, &clk_hse, &pinctrl, &gpio*, &rcc, and &soc also supposed to be tagged here? Without these tags, the early bootloader (SPL) might drop these nodes, causing the SD boot sequence to fail for this board. Additionally, since the explicit goal of the commit is to support SD boot, should the SD/MMC controller nodes (like &sdio1 and &sdio2) also be tagged with bootph-all? Without the tag, the device tree tooling for U-Boot SPL will prune the SDIO nodes entirely, leaving the bootloader without knowledge of the SD hardware. > diff --git a/arch/arm/boot/dts/st/stm32f746-disco.dts b/arch/arm/boot/dts/st/stm32f746-disco.dts > --- a/arch/arm/boot/dts/st/stm32f746-disco.dts > +++ b/arch/arm/boot/dts/st/stm32f746-disco.dts [ ... ] > @@ -179,6 +224,7 @@ touchscreen@38 { > <dc { > pinctrl-0 = <<dc_pins_a>; > pinctrl-names = "default"; > + bootph-all; > status = "okay"; [Severity: Low] Is bootph-all required on the LCD-TFT Display Controller for SD boot? Retaining this node bloats the memory-constrained early bootloader device tree (SPL) with display hardware nodes that may not be functionally necessary for booting. > port { [ ... ] > @@ -188,6 +234,22 @@ ltdc_out_rgb: endpoint { > }; > }; > > +&pinctrl { > + bootph-all; > +}; > + > +&pwrcfg { > + bootph-all; > +}; [Severity: High] The commit message indicates that the syscfg node needs to be present in all boot stages, but &pwrcfg is tagged here instead. Does this leave the actual syscfg node (syscon@40013800) untagged? The pinctrl node relies on syscfg via a phandle. If the syscfg node is pruned in SPL because it lacks a boot phase tag, will the pinctrl driver fail to probe due to a broken phandle, cascading into GPIO initialization failures? > diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts > --- a/arch/arm/boot/dts/st/stm32f769-disco.dts > +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts [ ... ] > @@ -140,11 +136,13 @@ &cec { > > &clk_hse { > clock-frequency = <25000000>; > + bootph-all; > }; > > &dsi { > #address-cells = <1>; > #size-cells = <0>; > + bootph-all; > status = "okay"; [Severity: Low] Similar to the ltdc node above, is the MIPI DSI host required to be present during the early SPL boot phase for SD boot? > ports { [ ... ] > @@ -199,6 +242,19 @@ ltdc_out_dsi: endpoint { > }; > }; > > +&pinctrl { > + bootph-all; > +}; > + > +&pwrcfg { > + bootph-all; > +}; > + > +&rcc { > + compatible = "st,stm32f769-rcc", "st,stm32f746-rcc", "st,stm32-rcc"; > + bootph-all; > +}; [Severity: High] The &soc node was properly tagged in stm32f746-disco.dts, but it appears to be omitted for stm32f769-disco.dts and stm32746g-eval.dts. If a parent simple-bus node lacks a boot phase tag in U-Boot SPL processing, its properties are stripped and the driver model will not bind to the bus. Should &soc also be tagged with bootph-all here to ensure the children nodes can probe successfully? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=2 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards 2026-05-26 9:54 ` sashiko-bot @ 2026-05-26 16:31 ` Patrice CHOTARD 0 siblings, 0 replies; 16+ messages in thread From: Patrice CHOTARD @ 2026-05-26 16:31 UTC (permalink / raw) To: sashiko-reviews; +Cc: devicetree, conor+dt, robh On 5/26/26 11:54, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider: > - [High] The patch completely omits necessary `bootph-all` tags for the `stm32746g-eval.dts` board. > - [High] Missing `bootph-all` on SDIO controller nodes despite the patch claiming to support SD boot. > - [High] The `&soc` parent bus node lacks the `bootph-all` tag in `stm32f769-disco.dts` and `stm32746g-eval.dts`. > - [High] The patch tags `pwrcfg` instead of the `syscfg` node claimed in the commit message, breaking `pinctrl` initialization. > - [Low] The patch erroneously adds `bootph-all` tags to display-related nodes (`<dc` and `&dsi`), which are unrelated to SD boot. > -- > > commit 616809e6aaaad31d633ea36ad66133cc44b7b361 > Author: Patrice Chotard <patrice.chotard@foss.st.com> > > ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards > > The bootph-all flag was introduced in dt-schema to define node usage > across different boot phases. To ensure SD boot, timer, gpio, syscfg, > clock, and uart nodes need to be present in all boot stages, so this > patch adds the missing flags. > >> diff --git a/arch/arm/boot/dts/st/stm32746g-eval.dts b/arch/arm/boot/dts/st/stm32746g-eval.dts >> --- a/arch/arm/boot/dts/st/stm32746g-eval.dts >> +++ b/arch/arm/boot/dts/st/stm32746g-eval.dts > [ ... ] >> @@ -226,6 +226,16 @@ &usart1 { >> status = "okay"; >> }; >> >> +&usart1_pins_a { >> + bootph-all; >> + pins1 { >> + bootph-all; >> + }; >> + pins2 { >> + bootph-all; >> + }; >> +}; > > [Severity: High] > The commit message mentions adding tags to timer, gpio, syscfg, clock, and > uart nodes, but for this board only the usart1 pin configuration is modified. > > Are controllers like &usart1, &timers5, &clk_hse, &pinctrl, &gpio*, &rcc, > and &soc also supposed to be tagged here? Correct, bootph-all property is missing for &usart1, &timers5, &clk_hse, &pinctrl, &gpio*, &rcc, &pwrcfg nodes for stm32746g-eval.dts. > > Without these tags, the early bootloader (SPL) might drop these nodes, > causing the SD boot sequence to fail for this board. > > Additionally, since the explicit goal of the commit is to support SD boot, > should the SD/MMC controller nodes (like &sdio1 and &sdio2) also be > tagged with bootph-all? The SD/MMC controller nodes soesn't need to be tagged, as SD/MMC is not needed neither in SPL mode nor before U-Boot relocation. > > Without the tag, the device tree tooling for U-Boot SPL will prune the > SDIO nodes entirely, leaving the bootloader without knowledge of the SD > hardware. > >> diff --git a/arch/arm/boot/dts/st/stm32f746-disco.dts b/arch/arm/boot/dts/st/stm32f746-disco.dts >> --- a/arch/arm/boot/dts/st/stm32f746-disco.dts >> +++ b/arch/arm/boot/dts/st/stm32f746-disco.dts > [ ... ] >> @@ -179,6 +224,7 @@ touchscreen@38 { >> <dc { >> pinctrl-0 = <<dc_pins_a>; >> pinctrl-names = "default"; >> + bootph-all; >> status = "okay"; > > [Severity: Low] > Is bootph-all required on the LCD-TFT Display Controller for SD boot? > > Retaining this node bloats the memory-constrained early bootloader device > tree (SPL) with display hardware nodes that may not be functionally > necessary for booting. bootph-all property is needed to be able to allocate the frame buffer before U-Boot relocation. > >> port { > [ ... ] >> @@ -188,6 +234,22 @@ ltdc_out_rgb: endpoint { >> }; >> }; >> >> +&pinctrl { >> + bootph-all; >> +}; >> + >> +&pwrcfg { >> + bootph-all; >> +}; > > [Severity: High] > The commit message indicates that the syscfg node needs to be present in all > boot stages, but &pwrcfg is tagged here instead. Correctn, I will update the commit message accordingly. > > Does this leave the actual syscfg node (syscon@40013800) untagged? > > The pinctrl node relies on syscfg via a phandle. If the syscfg node is > pruned in SPL because it lacks a boot phase tag, will the pinctrl driver > fail to probe due to a broken phandle, cascading into GPIO initialization > failures? > >> diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts >> --- a/arch/arm/boot/dts/st/stm32f769-disco.dts >> +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts > [ ... ] >> @@ -140,11 +136,13 @@ &cec { >> >> &clk_hse { >> clock-frequency = <25000000>; >> + bootph-all; >> }; >> >> &dsi { >> #address-cells = <1>; >> #size-cells = <0>; >> + bootph-all; >> status = "okay"; > > [Severity: Low] > Similar to the ltdc node above, is the MIPI DSI host required to be > present during the early SPL boot phase for SD boot? > >> ports { > [ ... ] >> @@ -199,6 +242,19 @@ ltdc_out_dsi: endpoint { >> }; >> }; >> >> +&pinctrl { >> + bootph-all; >> +}; >> + >> +&pwrcfg { >> + bootph-all; >> +}; >> + >> +&rcc { >> + compatible = "st,stm32f769-rcc", "st,stm32f746-rcc", "st,stm32-rcc"; >> + bootph-all; >> +}; > > [Severity: High] > The &soc node was properly tagged in stm32f746-disco.dts, but it appears to > be omitted for stm32f769-disco.dts and stm32746g-eval.dts. The soc node doesn't need to be tagged in stm32f746-disco.dts. bootph-all will be removed. > > If a parent simple-bus node lacks a boot phase tag in U-Boot SPL processing, > its properties are stripped and the driver model will not bind to the bus. > > Should &soc also be tagged with bootph-all here to ensure the children > nodes can probe successfully? > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 10:02 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 4/7] ARM: dts: stm32: Sort uart nodes by alphabetical order in stm32mp13xx-dhcor-som.dtsi Patrice Chotard ` (3 subsequent siblings) 6 siblings, 1 reply; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard The bootph-all flag was introduced in dt-schema (dtschema/schemas/bootph.yaml) to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be present in all boot stages, so add missing bootph-all phase flag to these nodes to support SD boot. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/boot/dts/st/stm32h743i-disco.dts | 69 ++++++++++++++++++++++++++++++ arch/arm/boot/dts/st/stm32h743i-eval.dts | 69 ++++++++++++++++++++++++++++++ arch/arm/boot/dts/st/stm32h747i-disco.dts | 69 ++++++++++++++++++++++++++++++ arch/arm/boot/dts/st/stm32h750i-art-pi.dts | 69 ++++++++++++++++++++++++++++++ 4 files changed, 276 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32h743i-disco.dts b/arch/arm/boot/dts/st/stm32h743i-disco.dts index 78d55b77db7c..1b4b9bc5c72d 100644 --- a/arch/arm/boot/dts/st/stm32h743i-disco.dts +++ b/arch/arm/boot/dts/st/stm32h743i-disco.dts @@ -107,6 +107,59 @@ u-boot { &clk_hse { clock-frequency = <25000000>; + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_i2s { + bootph-all; +}; + +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; }; &mac { @@ -126,6 +179,18 @@ phy0: ethernet-phy@0 { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a>; @@ -138,6 +203,10 @@ &sdmmc1 { status = "okay"; }; +&timer5 { + bootph-all; +}; + &usart2 { pinctrl-0 = <&usart2_pins_a>; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/st/stm32h743i-eval.dts b/arch/arm/boot/dts/st/stm32h743i-eval.dts index e5e10b0758ee..55674fe05431 100644 --- a/arch/arm/boot/dts/st/stm32h743i-eval.dts +++ b/arch/arm/boot/dts/st/stm32h743i-eval.dts @@ -124,6 +124,59 @@ adc1: adc@0 { &clk_hse { clock-frequency = <25000000>; + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_i2s { + bootph-all; +}; + +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; }; &i2c1 { @@ -155,6 +208,18 @@ phy0: ethernet-phy@0 { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_a>; @@ -169,6 +234,10 @@ &sdmmc1 { status = "okay"; }; +&timer5 { + bootph-all; +}; + &usart1 { pinctrl-0 = <&usart1_pins_a>; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/st/stm32h747i-disco.dts b/arch/arm/boot/dts/st/stm32h747i-disco.dts index c9dcc680e26d..ef36454808d5 100644 --- a/arch/arm/boot/dts/st/stm32h747i-disco.dts +++ b/arch/arm/boot/dts/st/stm32h747i-disco.dts @@ -104,6 +104,59 @@ u-boot { &clk_hse { clock-frequency = <25000000>; + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_i2s { + bootph-all; +}; + +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; }; &mac { @@ -123,6 +176,18 @@ phy0: ethernet-phy@0 { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a>; @@ -136,6 +201,10 @@ &sdmmc1 { status = "okay"; }; +&timer5 { + bootph-all; +}; + &usart1 { pinctrl-0 = <&usart1_pins_b>; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/st/stm32h750i-art-pi.dts b/arch/arm/boot/dts/st/stm32h750i-art-pi.dts index 56c53e262da7..8dddc70c37a1 100644 --- a/arch/arm/boot/dts/st/stm32h750i-art-pi.dts +++ b/arch/arm/boot/dts/st/stm32h750i-art-pi.dts @@ -114,6 +114,15 @@ wlan_pwr: regulator-wlan { &clk_hse { clock-frequency = <25000000>; + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_i2s { + bootph-all; }; &dma1 { @@ -124,6 +133,50 @@ &dma2 { status = "okay"; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + &mac { status = "disabled"; pinctrl-0 = <ðernet_rmii>; @@ -141,6 +194,18 @@ phy0: ethernet-phy@0 { }; }; +&pinctrl { + bootph-all; +}; + +&pwrcfg { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a>; @@ -196,6 +261,10 @@ partition@0 { }; }; +&timer5 { + bootph-all; +}; + &usart2 { pinctrl-0 = <&usart2_pins_a>; pinctrl-names = "default"; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards 2026-05-26 9:26 ` [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards Patrice Chotard @ 2026-05-26 10:02 ` sashiko-bot 0 siblings, 0 replies; 16+ messages in thread From: sashiko-bot @ 2026-05-26 10:02 UTC (permalink / raw) To: Patrice Chotard; +Cc: devicetree, conor+dt, robh Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] The patch fails to add the `bootph-all` property to UART and `syscfg` nodes, contradicting the commit message, and modifies unmentioned nodes. - [Low] Incorrect double-tab indentation for the `bootph-all` property inside the `&timer5` node. -- commit 46ae77600efc54228af475f90f412a5aaa703ea3 Author: Patrice Chotard <patrice.chotard@foss.st.com> ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards The bootph-all flag was introduced to define node usage across different boot phases. This commit adds the bootph-all phase flag to several nodes to ensure SD boot is supported across all boot stages. > To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be > present in all boot stages, so add missing bootph-all phase flag > to these nodes to support SD boot. [Severity: High] The commit message states that syscfg and uart nodes are modified to support SD boot, but the patch doesn't appear to add the bootph-all flag to them. Since the pinctrl node depends on syscfg, if syscfg is missing from the early boot device tree, could pinctrl fail to probe in SPL? Would this prevent SDMMC from functioning and break the early serial console if the UART nodes are also missing? > diff --git a/arch/arm/boot/dts/st/stm32h743i-disco.dts b/arch/arm/boot/dts/st/stm32h743i-disco.dts > index 78d55b77db7ce..1b4b9bc5c72dd 100644 > --- a/arch/arm/boot/dts/st/stm32h743i-disco.dts > +++ b/arch/arm/boot/dts/st/stm32h743i-disco.dts [ ... ] > +&pinctrl { > + bootph-all; > +}; > + > +&pwrcfg { > + bootph-all; > +}; [Severity: High] Was pwrcfg added here by mistake instead of the syscfg node mentioned in the commit message? [ ... ] > +&timer5 { > + bootph-all; > +}; > + > &usart2 { > pinctrl-0 = <&usart2_pins_a>; > pinctrl-names = "default"; [Severity: High] Did this usart node also need the bootph-all property added to support the early serial console, as mentioned in the commit message? > diff --git a/arch/arm/boot/dts/st/stm32h743i-eval.dts b/arch/arm/boot/dts/st/stm32h743i-eval.dts > index e5e10b0758eea..55674fe054311 100644 > --- a/arch/arm/boot/dts/st/stm32h743i-eval.dts > +++ b/arch/arm/boot/dts/st/stm32h743i-eval.dts [ ... ] > +&timer5 { > + bootph-all; > +}; [Severity: Low] This isn't a bug, but there appears to be an extra tab used for indentation here. The same extra tab is also present in stm32h747i-disco.dts and stm32h750i-art-pi.dts. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=3 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v7 4/7] ARM: dts: stm32: Sort uart nodes by alphabetical order in stm32mp13xx-dhcor-som.dtsi 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard ` (2 preceding siblings ...) 2026-05-26 9:26 ` [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 5/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards Patrice Chotard ` (2 subsequent siblings) 6 siblings, 0 replies; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard Sort uart4 and uart7 nodes by alphabetical order. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi | 56 ++++++++++++------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi b/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi index c18156807027..54ece71085c1 100644 --- a/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi +++ b/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi @@ -241,34 +241,6 @@ flash0: flash@0 { }; }; -/* Console UART */ -&uart4 { - pinctrl-names = "default", "sleep", "idle"; - pinctrl-0 = <&uart4_pins_b>; - pinctrl-1 = <&uart4_sleep_pins_b>; - pinctrl-2 = <&uart4_idle_pins_b>; - /delete-property/dmas; - /delete-property/dma-names; - status = "okay"; -}; - -/* Bluetooth */ -&uart7 { - pinctrl-names = "default", "sleep", "idle"; - pinctrl-0 = <&uart7_pins_a>; - pinctrl-1 = <&uart7_sleep_pins_a>; - pinctrl-2 = <&uart7_idle_pins_a>; - uart-has-rtscts; - status = "okay"; - - bluetooth { - compatible = "infineon,cyw43439-bt", "brcm,bcm4329-bt"; - max-speed = <3000000>; - device-wakeup-gpios = <&gpiog 9 GPIO_ACTIVE_HIGH>; - shutdown-gpios = <&gpioi 2 GPIO_ACTIVE_HIGH>; - }; -}; - /* SDIO WiFi */ &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; @@ -312,3 +284,31 @@ &sdmmc2 { vqmmc-supply = <&vdd>; status = "okay"; }; + +/* Console UART */ +&uart4 { + pinctrl-names = "default", "sleep", "idle"; + pinctrl-0 = <&uart4_pins_b>; + pinctrl-1 = <&uart4_sleep_pins_b>; + pinctrl-2 = <&uart4_idle_pins_b>; + /delete-property/dmas; + /delete-property/dma-names; + status = "okay"; +}; + +/* Bluetooth */ +&uart7 { + pinctrl-names = "default", "sleep", "idle"; + pinctrl-0 = <&uart7_pins_a>; + pinctrl-1 = <&uart7_sleep_pins_a>; + pinctrl-2 = <&uart7_idle_pins_a>; + uart-has-rtscts; + status = "okay"; + + bluetooth { + compatible = "infineon,cyw43439-bt", "brcm,bcm4329-bt"; + max-speed = <3000000>; + device-wakeup-gpios = <&gpiog 9 GPIO_ACTIVE_HIGH>; + shutdown-gpios = <&gpioi 2 GPIO_ACTIVE_HIGH>; + }; +}; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v7 5/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard ` (3 preceding siblings ...) 2026-05-26 9:26 ` [PATCH v7 4/7] ARM: dts: stm32: Sort uart nodes by alphabetical order in stm32mp13xx-dhcor-som.dtsi Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 10:16 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 6/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 7/7] arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards Patrice Chotard 6 siblings, 1 reply; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard The bootph-all flag was introduced in dt-schema (dtschema/schemas/bootph.yaml) to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be present in all boot stages, so add missing bootph-all phase flag to these nodes to support SD boot. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/boot/dts/st/stm32mp131.dtsi | 4 +- arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts | 21 +++++ arch/arm/boot/dts/st/stm32mp135f-dk.dts | 101 +++++++++++++++++++++++ arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi | 101 +++++++++++++++++++++++ 4 files changed, 225 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi index 83ae59b73dd0..ec1e91101971 100644 --- a/arch/arm/boot/dts/st/stm32mp131.dtsi +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi @@ -37,7 +37,7 @@ arm_wdt: watchdog { }; firmware { - optee { + optee: optee { method = "smc"; compatible = "linaro,optee-tz"; interrupt-parent = <&intc>; @@ -92,7 +92,7 @@ intc: interrupt-controller@a0021000 { <0xa0022000 0x2000>; }; - psci { + psci: psci { compatible = "arm,psci-1.0"; method = "smc"; }; diff --git a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts index 70d85af46735..06b5b68e5f78 100644 --- a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts +++ b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts @@ -354,6 +354,21 @@ timer@12 { }; }; +&uart4 { + bootph-all; +}; + +&uart4_pins_b { + bootph-all; + + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usart1 { /* Expansion connector: RX:pin33 TX:pin37 */ pinctrl-names = "default", "sleep", "idle"; pinctrl-0 = <&usart1_pins_b>; @@ -371,6 +386,10 @@ &usart2 { /* Expansion connector: RX:pin10 TX:pin8 RTS:pin11 CTS:pin36 */ status = "okay"; }; +&usbphyc { + bootph-all; +}; + &usbh_ehci { phys = <&usbphyc_port0>; status = "okay"; @@ -436,6 +455,7 @@ connector { /* LDO2 is expansion connector 3V3 supply on STM32MP13xx DHCOR DHSBC rev.200 */ &vdd_ldo2 { + bootph-all; regulator-always-on; regulator-boot-on; regulator-min-microvolt = <3300000>; @@ -444,6 +464,7 @@ &vdd_ldo2 { /* LDO5 is carrier board 3V3 supply on STM32MP13xx DHCOR DHSBC rev.200 */ &vdd_sd { + bootph-all; regulator-always-on; regulator-boot-on; regulator-min-microvolt = <3300000>; diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b/arch/arm/boot/dts/st/stm32mp135f-dk.dts index 6022e73f58af..43b8a7eed01b 100644 --- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts +++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts @@ -182,6 +182,10 @@ &arm_wdt { status = "okay"; }; +&bsec { + bootph-all; +}; + &crc1 { status = "okay"; }; @@ -253,6 +257,42 @@ phy0_eth1: ethernet-phy@0 { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + &i2c1 { pinctrl-names = "default", "sleep"; /* SDA on PE8 = CN8.27, SCL on PD12 = CN8.28 */ @@ -388,6 +428,7 @@ goodix: goodix-ts@5d { &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -395,6 +436,7 @@ <dc { pinctrl-names = "default", "sleep"; pinctrl-0 = <<dc_pins_a>; pinctrl-1 = <<dc_sleep_pins_a>; + bootph-some-ram; status = "okay"; port { @@ -404,6 +446,22 @@ ltdc_out_rgb: endpoint { }; }; +&optee { + bootph-all; +}; + +&pinctrl { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + +&rcc { + bootph-all; +}; + &rtc { pinctrl-names = "default"; pinctrl-0 = <&rtc_rsvd_pins_a>; @@ -415,6 +473,14 @@ rtc_lsco_pins_a: rtc-lsco-0 { }; }; +&scmi { + bootph-all; +}; + +&scmi_clk { + bootph-all; +}; + &scmi_regu { scmi_vdd_adc: regulator@10 { reg = <VOLTD_SCMI_STPMIC1_LDO1>; @@ -438,6 +504,10 @@ scmi_v3v3_sw: regulator@19 { }; }; +&scmi_reset { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_clk_pins_a>; @@ -448,9 +518,24 @@ &sdmmc1 { st,neg-edge; bus-width = <4>; vmmc-supply = <&scmi_vdd_sd>; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&sdmmc1_clk_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + /* Wifi */ &sdmmc2 { pinctrl-names = "default", "opendrain", "sleep"; @@ -482,6 +567,10 @@ &spi5 { status = "disabled"; }; +&syscfg { + bootph-all; +}; + &timers3 { /delete-property/dmas; /delete-property/dma-names; @@ -575,9 +664,20 @@ &uart4 { pinctrl-2 = <&uart4_idle_pins_a>; /delete-property/dmas; /delete-property/dma-names; + bootph-all; status = "okay"; }; +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &uart8 { pinctrl-names = "default", "sleep", "idle"; /* TX on PE1 = CN8.37, RX on PF9 = CN8.33 */ @@ -645,6 +745,7 @@ usbotg_hs_ep: endpoint { }; &usbphyc { + bootph-all; status = "okay"; }; diff --git a/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi b/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi index 54ece71085c1..4efaca84a72c 100644 --- a/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi +++ b/arch/arm/boot/dts/st/stm32mp13xx-dhcor-som.dtsi @@ -54,6 +54,46 @@ vin: vin { }; }; +&bsec { + bootph-all; +}; + +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + &i2c3 { i2c-scl-rising-time-ns = <96>; i2c-scl-falling-time-ns = <3>; @@ -216,9 +256,18 @@ eeprom0wl: eeprom@58 { &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + &qspi { pinctrl-names = "default", "sleep"; pinctrl-0 = <&qspi_clk_pins_a @@ -229,6 +278,7 @@ &qspi_bk1_sleep_pins_a &qspi_cs1_sleep_pins_a>; #address-cells = <1>; #size-cells = <0>; + bootph-all; status = "okay"; flash0: flash@0 { @@ -238,9 +288,35 @@ flash0: flash@0 { spi-max-frequency = <108000000>; #address-cells = <1>; #size-cells = <1>; + bootph-all; }; }; +&qspi_clk_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + +&qspi_bk1_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + +&qspi_cs1_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + +&rcc { + bootph-all; +}; + /* SDIO WiFi */ &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; @@ -285,6 +361,10 @@ &sdmmc2 { status = "okay"; }; +&syscfg { + bootph-all; +}; + /* Console UART */ &uart4 { pinctrl-names = "default", "sleep", "idle"; @@ -312,3 +392,24 @@ bluetooth { shutdown-gpios = <&gpioi 2 GPIO_ACTIVE_HIGH>; }; }; + +&vdd { + bootph-all; +}; + +&vddcpu { + bootph-all; +}; + + +&vddcore { + bootph-all; +}; + +&vdd_ddr { + bootph-all; +}; + +&vref_ddr { + bootph-all; +}; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v7 5/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards 2026-05-26 9:26 ` [PATCH v7 5/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards Patrice Chotard @ 2026-05-26 10:16 ` sashiko-bot 0 siblings, 0 replies; 16+ messages in thread From: sashiko-bot @ 2026-05-26 10:16 UTC (permalink / raw) To: Patrice Chotard; +Cc: devicetree, robh, conor+dt Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [High] Missing Parent Boot Phase Tags - [High] Missing Supplier Boot Phase Tags - [High] Unfulfilled Commit Message Claim -- commit 7c0b7128d099d18d1bcdd89ea128ab291f4eeb89 Author: Patrice Chotard <patrice.chotard@foss.st.com> ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards This commit adds bootph-all and bootph-pre-ram flags to various device tree nodes for STMicroelectronics mp13 boards. The stated goal is to ensure these nodes are present in all boot stages to support SD boot. > To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be > present in all boot stages, so add missing bootph-all phase flag > to these nodes to support SD boot. [Severity: High] The commit message mentions adding the bootph-all flag to timer nodes to support SD boot, but no timer nodes appear to be modified in this patch. Does this patch miss the required timer updates, or is the commit message inaccurate? Without the timer node in the early boot device tree, could system timing functions and SD boot break? > diff --git a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts > index 70d85af467353..06b5b68e5f784 100644 > --- a/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts > +++ b/arch/arm/boot/dts/st/stm32mp135f-dhcor-dhsbc.dts [ ... ] > @@ -436,6 +455,7 @@ connector { > > /* LDO2 is expansion connector 3V3 supply on STM32MP13xx DHCOR DHSBC rev.200 */ > &vdd_ldo2 { > + bootph-all; > regulator-always-on; > regulator-boot-on; [Severity: High] Will this bootph-all tag, as well as the ones added to child regulators like vdd_sd, vdd, vddcpu, vddcore, vdd_ddr, and vref_ddr, be effective during early boot? Under U-Boot's fdtgrep reduction rules, while parents of tagged nodes are structurally retained, their properties (including the compatible string) are stripped unless explicitly tagged. Without a compatible string, U-Boot's Driver Model will fail to bind drivers for the PMIC and I2C controller. Do the parent nodes (e.g., the I2C controller and PMIC) also need the bootph-all tag to ensure these regulators are probed in early boot? > diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b/arch/arm/boot/dts/st/stm32mp135f-dk.dts > index 6022e73f58afd..43b8a7eed01b9 100644 > --- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts > +++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts [ ... ] > @@ -448,9 +518,24 @@ &sdmmc1 { > st,neg-edge; > bus-width = <4>; > vmmc-supply = <&scmi_vdd_sd>; > + bootph-pre-ram; > status = "okay"; > }; [Severity: High] Since sdmmc1 is tagged with bootph-pre-ram, does its vmmc-supply (&scmi_vdd_sd) also need a corresponding boot phase tag? If neither the scmi_vdd_sd node nor its parent scmi_regu are given a bootph-pre-ram or bootph-all tag, fdtgrep will strip the target node from the early boot device tree. Could this result in a dangling phandle reference for vmmc-supply that prevents the MMC driver from resolving its power supply during early boot? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=5 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v7 6/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard ` (4 preceding siblings ...) 2026-05-26 9:26 ` [PATCH v7 5/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 10:27 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 7/7] arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards Patrice Chotard 6 siblings, 1 reply; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard The bootph-all flag was introduced in dt-schema (dtschema/schemas/bootph.yaml) to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be present in all boot stages, so add missing bootph-all phase flag to these nodes to support SD boot. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm/boot/dts/st/stm32mp151.dtsi | 2 +- arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts | 19 +++ .../st/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts | 1 + .../dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts | 25 +++ .../dts/st/stm32mp157a-icore-stm32mp1-edimm2.2.dts | 26 +++ .../boot/dts/st/stm32mp157a-icore-stm32mp1.dtsi | 100 ++++++++++++ ...m32mp157a-microgea-stm32mp1-microdev2.0-of7.dts | 27 ++++ .../stm32mp157a-microgea-stm32mp1-microdev2.0.dts | 27 ++++ .../boot/dts/st/stm32mp157a-microgea-stm32mp1.dtsi | 97 ++++++++++++ arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts | 5 + arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 1 + arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts | 19 +++ arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 151 ++++++++++++++++++ arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts | 5 + arch/arm/boot/dts/st/stm32mp157c-ev1.dts | 38 +++++ arch/arm/boot/dts/st/stm32mp157c-lxa-mc1.dts | 1 + arch/arm/boot/dts/st/stm32mp157c-odyssey-som.dtsi | 119 ++++++++++++++ arch/arm/boot/dts/st/stm32mp157c-odyssey.dts | 21 +++ arch/arm/boot/dts/st/stm32mp157c-osd32mp1-red.dts | 1 + arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi | 5 + arch/arm/boot/dts/st/stm32mp157f-dk2.dts | 1 + arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi | 2 +- arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi | 175 +++++++++++++++++++++ .../boot/dts/st/stm32mp15xx-dhcor-avenger96.dtsi | 55 +++++++ .../boot/dts/st/stm32mp15xx-dhcor-drc-compact.dtsi | 50 ++++++ arch/arm/boot/dts/st/stm32mp15xx-dhcor-som.dtsi | 157 ++++++++++++++++++ .../boot/dts/st/stm32mp15xx-dhcor-testbench.dtsi | 50 ++++++ arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi | 122 ++++++++++++++ 28 files changed, 1300 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/st/stm32mp151.dtsi b/arch/arm/boot/dts/st/stm32mp151.dtsi index 84f68e8563d8..57443697e6e0 100644 --- a/arch/arm/boot/dts/st/stm32mp151.dtsi +++ b/arch/arm/boot/dts/st/stm32mp151.dtsi @@ -31,7 +31,7 @@ arm-pmu { interrupt-parent = <&intc>; }; - psci { + psci: psci { compatible = "arm,psci-1.0"; method = "smc"; }; diff --git a/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts b/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts index 847b360f02fc..b81b6e168b67 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts +++ b/arch/arm/boot/dts/st/stm32mp157a-dk1-scmi.dts @@ -65,6 +65,7 @@ &m4_rproc { &optee { interrupt-parent = <&intc>; interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + bootph-some-ram; }; &rcc { @@ -85,3 +86,21 @@ &rng1 { &rtc { clocks = <&scmi_clk CK_SCMI_RTCAPB>, <&scmi_clk CK_SCMI_RTC>; }; + +&scmi { + bootph-some-ram; +}; + +&uart4 { + bootph-all; +}; + +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts index df97e03d2a5a..4ad1313efca9 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts +++ b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts @@ -92,6 +92,7 @@ bridge_out: endpoint { }; <dc { + bootph-some-ram; status = "okay"; port { diff --git a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts index 60ce4425a7fd..ac4e313ca371 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts +++ b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts @@ -35,15 +35,40 @@ &sdmmc1 { pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; st,neg-edge; vmmc-supply = <&v3v3>; + bootph-all; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + }; +}; + &uart4 { pinctrl-names = "default", "sleep", "idle"; pinctrl-0 = <&uart4_pins_a>; pinctrl-1 = <&uart4_sleep_pins_a>; pinctrl-2 = <&uart4_idle_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; + +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + bias-pull-up; + }; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-edimm2.2.dts b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-edimm2.2.dts index f8e404346396..cc24a29fba15 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-edimm2.2.dts +++ b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-edimm2.2.dts @@ -92,6 +92,7 @@ bridge_out_panel: endpoint { }; <dc { + bootph-some-ram; status = "okay"; port { @@ -110,15 +111,40 @@ &sdmmc1 { pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; st,neg-edge; vmmc-supply = <&v3v3>; + bootph-all; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + }; +}; + &uart4 { pinctrl-names = "default", "sleep", "idle"; pinctrl-0 = <&uart4_pins_a>; pinctrl-1 = <&uart4_sleep_pins_a>; pinctrl-2 = <&uart4_idle_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; + +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + bias-pull-up; + }; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1.dtsi b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1.dtsi index 569a7e940ecc..db93934019d1 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1.dtsi +++ b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1.dtsi @@ -61,6 +61,7 @@ vddcore: regulator-vddcore { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; regulator-always-on; + bootph-all; }; vdd: regulator-vdd { @@ -69,6 +70,7 @@ vdd: regulator-vdd { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + bootph-all; }; vdd_usb: regulator-vdd-usb { @@ -77,6 +79,7 @@ vdd_usb: regulator-vdd-usb { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + bootph-all; }; vdda: regulator-vdda { @@ -85,6 +88,7 @@ vdda: regulator-vdda { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + bootph-all; }; vdd_ddr: regulator-vdd-ddr { @@ -93,6 +97,7 @@ vdd_ddr: regulator-vdd-ddr { regulator-min-microvolt = <1350000>; regulator-max-microvolt = <1350000>; regulator-always-on; + bootph-all; }; vtt_ddr: regulator-vtt-ddr { @@ -102,6 +107,7 @@ vtt_ddr: regulator-vtt-ddr { regulator-max-microvolt = <675000>; regulator-always-on; vin-supply = <&vdd>; + bootph-all; }; vref_ddr: regulator-vref-ddr { @@ -111,6 +117,7 @@ vref_ddr: regulator-vref-ddr { regulator-max-microvolt = <675000>; regulator-always-on; vin-supply = <&vdd>; + bootph-all; }; vdd_sd: regulator-vdd-sd { @@ -119,6 +126,7 @@ vdd_sd: regulator-vdd-sd { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + bootph-all; }; v3v3: regulator-v3v3 { @@ -127,6 +135,7 @@ v3v3: regulator-v3v3 { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + bootph-all; }; v2v8: regulator-v2v8 { @@ -136,6 +145,7 @@ v2v8: regulator-v2v8 { regulator-max-microvolt = <2800000>; regulator-always-on; vin-supply = <&v3v3>; + bootph-all; }; v1v8: regulator-v1v8 { @@ -145,13 +155,86 @@ v1v8: regulator-v1v8 { regulator-max-microvolt = <1800000>; regulator-always-on; vin-supply = <&v3v3>; + bootph-all; }; }; +&bsec { + bootph-all; +}; + +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + &dts { status = "okay"; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &i2c2 { i2c-scl-falling-time-ns = <20>; i2c-scl-rising-time-ns = <185>; @@ -167,6 +250,7 @@ &ipcc { &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -180,6 +264,22 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + +&rcc { + bootph-all; +}; + &rng1 { status = "okay"; }; diff --git a/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts b/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts index 5116a7785201..7bfd7da4a8db 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts +++ b/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts @@ -78,6 +78,7 @@ &i2c2 { <dc { pinctrl-names = "default"; pinctrl-0 = <<dc_pins>; + bootph-some-ram; status = "okay"; port { @@ -134,19 +135,45 @@ &sdmmc1 { pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; st,neg-edge; vmmc-supply = <&vdd>; + bootph-all; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-all; + + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + }; +}; + &uart4 { pinctrl-names = "default", "sleep", "idle"; pinctrl-0 = <&uart4_pins_a>; pinctrl-1 = <&uart4_sleep_pins_a>; pinctrl-2 = <&uart4_idle_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_a { + bootph-all; + + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + }; +}; + /* J31: RS323 */ &uart8 { pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0.dts b/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0.dts index d949559be020..a1f79659d7c5 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0.dts +++ b/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1-microdev2.0.dts @@ -36,19 +36,46 @@ &sdmmc1 { pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; st,neg-edge; vmmc-supply = <&vdd>; + bootph-all; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-all; + + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + }; +}; + &uart4 { pinctrl-names = "default", "sleep", "idle"; pinctrl-0 = <&uart4_pins_a>; pinctrl-1 = <&uart4_sleep_pins_a>; pinctrl-2 = <&uart4_idle_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_a { + bootph-all; + + pins1 { + bootph-all; + }; + + pins2 { + bootph-all; + bias-pull-up; + }; +}; + /* J31: RS323 */ &uart8 { pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1.dtsi b/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1.dtsi index a75f50cf7123..4f6f4712d634 100644 --- a/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1.dtsi +++ b/arch/arm/boot/dts/st/stm32mp157a-microgea-stm32mp1.dtsi @@ -61,6 +61,7 @@ vin: regulator-vin { regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; regulator-always-on; + bootph-all; }; vddcore: regulator-vddcore { @@ -70,6 +71,7 @@ vddcore: regulator-vddcore { regulator-max-microvolt = <1200000>; regulator-always-on; vin-supply = <&vin>; + bootph-all; }; vdd: regulator-vdd { @@ -79,6 +81,7 @@ vdd: regulator-vdd { regulator-max-microvolt = <3300000>; regulator-always-on; vin-supply = <&vin>; + bootph-all; }; vddq_ddr: regulator-vddq-ddr { @@ -88,9 +91,34 @@ vddq_ddr: regulator-vddq-ddr { regulator-max-microvolt = <1350000>; regulator-always-on; vin-supply = <&vin>; + bootph-all; }; }; +&bsec { + bootph-all; +}; + +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + &dts { status = "okay"; }; @@ -113,12 +141,61 @@ nand@0 { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &ipcc { status = "okay"; }; &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -132,6 +209,26 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + +&pwr_regulators { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &rng1 { status = "okay"; }; diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts index 43280289759d..e192d033626e 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2-scmi.dts @@ -71,6 +71,7 @@ &m4_rproc { &optee { interrupt-parent = <&intc>; interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + bootph-some-ram; }; &rcc { @@ -91,3 +92,7 @@ &rng1 { &rtc { clocks = <&scmi_clk CK_SCMI_RTCAPB>, <&scmi_clk CK_SCMI_RTC>; }; + +&scmi { + bootph-some-ram; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts index 1ec3b8f2faa9..bf9fdf0d611c 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-dk2.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-dk2.dts @@ -80,6 +80,7 @@ touchscreen@38 { }; <dc { + bootph-some-ram; status = "okay"; port { diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts index 6f27d794d270..f053a70cb254 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-ed1-scmi.dts @@ -70,6 +70,7 @@ &m4_rproc { &optee { interrupt-parent = <&intc>; interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + bootph-some-ram; }; &rcc { @@ -90,3 +91,21 @@ &rng1 { &rtc { clocks = <&scmi_clk CK_SCMI_RTCAPB>, <&scmi_clk CK_SCMI_RTC>; }; + +&scmi { + bootph-some-ram; +}; + +&uart4 { + bootph-all; +}; + +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts index 49dd555cc228..ef71ebd65518 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts @@ -145,6 +145,31 @@ channel@6 { }; }; + +&bsec { + bootph-all; +}; + +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + &crc1 { status = "okay"; }; @@ -170,6 +195,54 @@ &dts { status = "okay"; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &hash1 { status = "okay"; }; @@ -181,7 +254,9 @@ &i2c4 { i2c-scl-rising-time-ns = <185>; i2c-scl-falling-time-ns = <20>; clock-frequency = <400000>; + bootph-all; status = "okay"; + /* spare dmas for other usage */ /delete-property/dmas; /delete-property/dma-names; @@ -192,6 +267,7 @@ pmic: stpmic@33 { interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>; interrupt-controller; #interrupt-cells = <2>; + bootph-all; status = "okay"; regulators { @@ -327,12 +403,20 @@ watchdog { }; }; +&i2c4_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + &ipcc { status = "okay"; }; &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -348,9 +432,26 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + &pwr_regulators { vdd-supply = <&vdd>; vdd_3v3_usbfs-supply = <&vdd_usb>; + bootph-all; +}; + +&rcc { + bootph-all; }; &rng1 { @@ -378,9 +479,30 @@ &sdmmc1 { sd-uhs-sdr25; sd-uhs-sdr50; sd-uhs-ddr50; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc1_dir_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + &sdmmc2 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>; @@ -394,9 +516,27 @@ &sdmmc2 { vmmc-supply = <&v3v3>; vqmmc-supply = <&vdd>; mmc-ddr-3_3v; + bootph-pre-ram; status = "okay"; }; +&sdmmc2_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc2_d47_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + &timers6 { status = "okay"; /* spare dmas for other usage */ @@ -412,11 +552,22 @@ &uart4 { pinctrl-0 = <&uart4_pins_a>; pinctrl-1 = <&uart4_sleep_pins_a>; pinctrl-2 = <&uart4_idle_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usbotg_hs { vbus-supply = <&vbus_otg>; }; diff --git a/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts b/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts index 6ae391bffee5..17295d67ab85 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-ev1-scmi.dts @@ -75,6 +75,7 @@ &m4_rproc { &optee { interrupt-parent = <&intc>; interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + bootph-some-ram; }; &rcc { @@ -95,3 +96,7 @@ &rng1 { &rtc { clocks = <&scmi_clk CK_SCMI_RTCAPB>, <&scmi_clk CK_SCMI_RTC>; }; + +&scmi { + bootph-some-ram; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157c-ev1.dts b/arch/arm/boot/dts/st/stm32mp157c-ev1.dts index 0e65a1862eb5..c4be802ef1e7 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-ev1.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-ev1.dts @@ -283,6 +283,7 @@ &i2c5 { }; <dc { + bootph-some-ram; status = "okay"; port { @@ -314,6 +315,7 @@ &qspi_bk2_sleep_pins_a reg = <0x58003000 0x1000>, <0x70000000 0x4000000>; #address-cells = <1>; #size-cells = <0>; + bootph-pre-ram; status = "okay"; flash0: flash@0 { @@ -323,6 +325,7 @@ flash0: flash@0 { spi-max-frequency = <108000000>; #address-cells = <1>; #size-cells = <1>; + bootph-pre-ram; }; flash1: flash@1 { @@ -335,6 +338,41 @@ flash1: flash@1 { }; }; +&qspi_clk_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_bk1_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_cs1_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_bk2_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_cs2_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + &sdmmc3 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc3_b4_pins_a>; diff --git a/arch/arm/boot/dts/st/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/st/stm32mp157c-lxa-mc1.dts index eada9cf257be..9f513045c559 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-lxa-mc1.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-lxa-mc1.dts @@ -158,6 +158,7 @@ <dc { pinctrl-names = "default", "sleep"; pinctrl-0 = <<dc_pins_c>; pinctrl-1 = <<dc_sleep_pins_c>; + bootph-some-ram; status = "okay"; port { diff --git a/arch/arm/boot/dts/st/stm32mp157c-odyssey-som.dtsi b/arch/arm/boot/dts/st/stm32mp157c-odyssey-som.dtsi index cf7485251490..1c5517f57ecd 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-odyssey-som.dtsi +++ b/arch/arm/boot/dts/st/stm32mp157c-odyssey-som.dtsi @@ -75,11 +75,84 @@ led-blue { }; }; +&bsec { + bootph-all; +}; + +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &i2c2 { pinctrl-names = "default"; pinctrl-0 = <&i2c2_pins_a>; i2c-scl-rising-time-ns = <185>; i2c-scl-falling-time-ns = <20>; + bootph-all; status = "okay"; /* spare dmas for other usage */ /delete-property/dmas; @@ -91,6 +164,7 @@ pmic: stpmic@33 { interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>; interrupt-controller; #interrupt-cells = <2>; + bootph-all; regulators { compatible = "st,stpmic1-regulators"; @@ -218,12 +292,20 @@ watchdog { }; }; +&i2c2_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + &ipcc { status = "okay"; }; &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -237,6 +319,26 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + +&pwr_regulators { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &rng1 { status = "okay"; }; @@ -258,6 +360,23 @@ &sdmmc2 { vmmc-supply = <&v3v3>; vqmmc-supply = <&vdd>; mmc-ddr-3_3v; + bootph-pre-ram; status = "okay"; }; +&sdmmc2_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc2_d47_pins_d { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/st/stm32mp157c-odyssey.dts index a8b3f7a54703..92bc25b3f563 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-odyssey.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-odyssey.dts @@ -75,14 +75,35 @@ &sdmmc1 { st,neg-edge; bus-width = <4>; vmmc-supply = <&v3v3>; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + &uart4 { pinctrl-names = "default"; pinctrl-0 = <&uart4_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; diff --git a/arch/arm/boot/dts/st/stm32mp157c-osd32mp1-red.dts b/arch/arm/boot/dts/st/stm32mp157c-osd32mp1-red.dts index 36e6055b5665..b404ea3752d9 100644 --- a/arch/arm/boot/dts/st/stm32mp157c-osd32mp1-red.dts +++ b/arch/arm/boot/dts/st/stm32mp157c-osd32mp1-red.dts @@ -131,6 +131,7 @@ i2s2_endpoint: endpoint { }; <dc { + bootph-some-ram; status = "okay"; port { diff --git a/arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi b/arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi index 89de85a2eff3..5d29c2154b46 100644 --- a/arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi +++ b/arch/arm/boot/dts/st/stm32mp157f-dk2-scmi.dtsi @@ -87,6 +87,7 @@ &mdma1 { &optee { interrupt-parent = <&intc>; interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; + bootph-some-ram; }; &pwr_regulators { @@ -114,6 +115,10 @@ &rtc { clocks = <&scmi_clk CK_SCMI_RTCAPB>, <&scmi_clk CK_SCMI_RTC>; }; +&scmi { + bootph-some-ram; +}; + &scmi_reguls { scmi_vddcore: regulator@3 { reg = <VOLTD_SCMI_STPMIC1_BUCK1>; diff --git a/arch/arm/boot/dts/st/stm32mp157f-dk2.dts b/arch/arm/boot/dts/st/stm32mp157f-dk2.dts index 8fa61e54d026..4d857b3575fd 100644 --- a/arch/arm/boot/dts/st/stm32mp157f-dk2.dts +++ b/arch/arm/boot/dts/st/stm32mp157f-dk2.dts @@ -97,6 +97,7 @@ stpmic@33 { }; <dc { + bootph-some-ram; status = "okay"; port { diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi index 0075d9391181..d8eb10339679 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-pdk2.dtsi @@ -122,6 +122,7 @@ &i2c5 { /* Header X21 */ pinctrl-0 = <&i2c5_pins_a>; i2c-scl-rising-time-ns = <185>; i2c-scl-falling-time-ns = <20>; + bootph-some-ram; status = "okay"; /* spare dmas for other usage */ /delete-property/dmas; @@ -149,7 +150,6 @@ sgtl5000_rx_endpoint: endpoint@1 { remote-endpoint = <&sai2b_endpoint>; }; }; - }; }; diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi index 4cc633683c6b..04e91d02cc28 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi @@ -103,6 +103,10 @@ channel@1 { }; }; +&bsec { + bootph-all; +}; + &crc1 { status = "okay"; }; @@ -121,6 +125,26 @@ dac2: dac@2 { }; }; +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + &dts { status = "okay"; }; @@ -190,6 +214,7 @@ &gpioa { "", "", "DHCOM-K", "", "", "", "", "", "", "", "", ""; + bootph-all; }; &gpiob { @@ -197,6 +222,7 @@ &gpiob { "", "", "", "", "DHCOM-Q", "", "", "", "", "", "", ""; + bootph-all; }; &gpioc { @@ -204,6 +230,7 @@ &gpioc { "", "", "DHCOM-E", "", "", "", "", "", "", "", "", ""; + bootph-all; }; &gpiod { @@ -211,6 +238,7 @@ &gpiod { "", "", "DHCOM-B", "", "", "", "", "DHCOM-F", "DHCOM-D", "", "", ""; + bootph-all; }; &gpioe { @@ -218,6 +246,7 @@ &gpioe { "", "", "DHCOM-P", "", "", "", "", "", "", "", "", ""; + bootph-all; }; &gpiof { @@ -225,6 +254,7 @@ &gpiof { "", "", "", "", "", "", "", "", "", "", "", ""; + bootph-all; }; &gpiog { @@ -232,6 +262,7 @@ &gpiog { "", "", "", "", "DHCOM-L", "", "", "", "", "", "", ""; + bootph-all; }; &gpioh { @@ -239,6 +270,7 @@ &gpioh { "", "", "", "DHCOM-N", "DHCOM-J", "DHCOM-W", "DHCOM-V", "DHCOM-U", "DHCOM-T", "", "DHCOM-S", ""; + bootph-all; }; &gpioi { @@ -246,6 +278,20 @@ &gpioi { "DHCOM-R", "DHCOM-M", "", "", "", "", "", "", "", "", "", ""; + bootph-all; +}; + +&gpioj { + bootph-all; + +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; }; &i2c4 { @@ -253,6 +299,8 @@ &i2c4 { pinctrl-0 = <&i2c4_pins_a>; i2c-scl-rising-time-ns = <185>; i2c-scl-falling-time-ns = <20>; + bootph-all; + bootph-pre-ram; status = "okay"; /* spare dmas for other usage */ /delete-property/dmas; @@ -269,6 +317,8 @@ pmic: stpmic@33 { interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>; interrupt-controller; #interrupt-cells = <2>; + bootph-all; + bootph-pre-ram; regulators { compatible = "st,stpmic1-regulators"; @@ -279,6 +329,7 @@ regulators { ldo6-supply = <&v3v3>; pwr_sw1-supply = <&bst_out>; pwr_sw2-supply = <&bst_out>; + bootph-pre-ram; vddcore: buck1 { regulator-name = "vddcore"; @@ -409,12 +460,20 @@ eeprom@50 { }; }; +&i2c4_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + &ipcc { status = "okay"; }; &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -428,9 +487,22 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + &pwr_regulators { vdd-supply = <&vdd>; vdd_3v3_usbfs-supply = <&vdd_usb>; + bootph-all; }; &qspi { @@ -444,6 +516,7 @@ &qspi_bk1_sleep_pins_a reg = <0x58003000 0x1000>, <0x70000000 0x4000000>; #address-cells = <1>; #size-cells = <0>; + bootph-pre-ram; status = "okay"; flash0: flash@0 { @@ -453,6 +526,28 @@ flash0: flash@0 { spi-max-frequency = <108000000>; #address-cells = <1>; #size-cells = <1>; + bootph-pre-ram; + }; +}; + +&qspi_clk_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_bk1_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_cs1_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; }; }; @@ -469,6 +564,15 @@ &rcc { assigned-clocks = <&rcc CK_MCO2>, <&rcc PLL4_P>; assigned-clock-parents = <&rcc PLL4_P>; assigned-clock-rates = <50000000>, <100000000>; + bootph-all; +}; + +®11 { + bootph-pre-ram; +}; + +®18 { + bootph-pre-ram; }; &rng1 { @@ -495,6 +599,7 @@ &sdmmc1 { st,ckin-gpios = <&gpioe 4 0>; bus-width = <4>; vmmc-supply = <&vdd_sd>; + bootph-pre-ram; status = "okay"; }; @@ -504,11 +609,24 @@ &sdmmc1_b4_pins_a { * - optional on SoMs with SD voltage translator * - mandatory on SoMs without SD voltage translator */ + bootph-pre-ram; pins1 { bias-pull-up; + bootph-pre-ram; }; pins2 { bias-pull-up; + bootph-pre-ram; + }; +}; + +&sdmmc1_dir_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; }; }; @@ -525,9 +643,27 @@ &sdmmc2 { vmmc-supply = <&v3v3>; vqmmc-supply = <&v3v3>; mmc-ddr-3_3v; + bootph-pre-ram; status = "okay"; }; +&sdmmc2_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc2_d47_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + &sdmmc3 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc3_b4_pins_a>; @@ -545,7 +681,46 @@ &sdmmc3 { &uart4 { pinctrl-names = "default"; pinctrl-0 = <&uart4_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; + +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + +&usb33 { + bootph-pre-ram; +}; + +&usbotg_hs_pins_a { + bootph-pre-ram; +}; + +&usbotg_hs { + bootph-pre-ram; +}; + +&usbphyc { + bootph-pre-ram; +}; + +&usbphyc_port0 { + bootph-pre-ram; +}; + +&usbphyc_port1 { + bootph-pre-ram; +}; + +&vdd_usb { + bootph-pre-ram; +}; diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-avenger96.dtsi index 85d93ddfa12a..c8e2c0a4ec4c 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-avenger96.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-avenger96.dtsi @@ -349,6 +349,7 @@ <dc { pinctrl-names = "default", "sleep"; pinctrl-0 = <<dc_pins_d>; pinctrl-1 = <<dc_sleep_pins_d>; + bootph-some-ram; status = "okay"; port { @@ -396,9 +397,30 @@ &sdmmc1 { bus-width = <4>; vmmc-supply = <&vdd_sd>; vqmmc-supply = <&sd_switch>; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc1_dir_pins_b { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + &sdmmc2 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_c>; @@ -412,9 +434,27 @@ &sdmmc2 { st,neg-edge; vmmc-supply = <&v3v3>; vqmmc-supply = <&vdd_io>; + bootph-pre-ram; status = "okay"; }; +&sdmmc2_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc2_d47_pins_c { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + &sdmmc3 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc3_b4_pins_b>; @@ -449,11 +489,22 @@ &uart4 { label = "LS-UART1"; pinctrl-names = "default"; pinctrl-0 = <&uart4_pins_b>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_b { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &uart7 { /* On Low speed expansion header */ label = "LS-UART0"; @@ -506,3 +557,7 @@ &usbphyc_port0 { &usbphyc_port1 { phy-supply = <&vdd_usb>; }; + +&vdd_io { + bootph-pre-ram; +}; diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-drc-compact.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-drc-compact.dtsi index bc4ddcbdd5cf..9c6a04b4c2e3 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-drc-compact.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-drc-compact.dtsi @@ -231,9 +231,30 @@ &sdmmc1 { /* MicroSD */ bus-width = <4>; vmmc-supply = <&vdd>; vqmmc-supply = <&vdd>; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc1_dir_pins_b { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + &sdmmc2 { /* eMMC */ pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_c>; @@ -246,9 +267,27 @@ &sdmmc2 { /* eMMC */ st,neg-edge; vmmc-supply = <&v3v3>; vqmmc-supply = <&vdd>; + bootph-pre-ram; status = "okay"; }; +&sdmmc2_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc2_d47_pins_c { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + &sdmmc3 { /* SDIO Wi-Fi */ pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc3_b4_pins_a>; @@ -276,11 +315,22 @@ &uart4 { label = "UART0"; pinctrl-names = "default"; pinctrl-0 = <&uart4_pins_d>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_d { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &uart5 { /* X11 UART */ label = "X11-UART5"; pinctrl-names = "default"; diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-som.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-som.dtsi index 89881a26c614..3d469e29d41a 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-som.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-som.dtsi @@ -63,6 +63,30 @@ retram: retram@38000000 { }; }; +&bsec { + bootph-all; +}; + +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + &crc1 { status = "okay"; }; @@ -71,11 +95,61 @@ &dts { status = "okay"; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &i2c4 { pinctrl-names = "default"; pinctrl-0 = <&i2c4_pins_a>; i2c-scl-rising-time-ns = <185>; i2c-scl-falling-time-ns = <20>; + bootph-all; + bootph-pre-ram; status = "okay"; /delete-property/dmas; /delete-property/dma-names; @@ -86,6 +160,8 @@ pmic: stpmic@33 { interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>; interrupt-controller; #interrupt-cells = <2>; + bootph-all; + bootph-pre-ram; status = "okay"; regulators { @@ -98,6 +174,7 @@ regulators { ldo6-supply = <&v3v3>; pwr_sw1-supply = <&bst_out>; pwr_sw2-supply = <&bst_out>; + bootph-pre-ram; vddcore: buck1 { regulator-name = "vddcore"; @@ -215,12 +292,20 @@ watchdog { }; }; +&i2c4_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + &ipcc { status = "okay"; }; &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -234,9 +319,23 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + &pwr_regulators { vdd-supply = <&vdd>; vdd_3v3_usbfs-supply = <&vdd_usb>; + bootph-all; + bootph-pre-ram; }; &qspi { @@ -250,6 +349,7 @@ &qspi_bk1_sleep_pins_a reg = <0x58003000 0x1000>, <0x70000000 0x200000>; #address-cells = <1>; #size-cells = <0>; + bootph-pre-ram; status = "okay"; flash0: flash@0 { @@ -262,6 +362,35 @@ flash0: flash@0 { }; }; +&qspi_clk_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_bk1_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +&qspi_cs1_pins_a { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + +®11 { + bootph-pre-ram; +}; + +®18 { + bootph-pre-ram; +}; + &rng1 { status = "okay"; }; @@ -269,3 +398,31 @@ &rng1 { &rtc { status = "okay"; }; + +&usb33 { + bootph-pre-ram; +}; + +&usbotg_hs_pins_a { + bootph-pre-ram; +}; + +&usbotg_hs { + bootph-pre-ram; +}; + +&usbphyc { + bootph-pre-ram; +}; + +&usbphyc_port0 { + bootph-pre-ram; +}; + +&usbphyc_port1 { + bootph-pre-ram; +}; + +&vdd_usb { + bootph-pre-ram; +}; diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-testbench.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-testbench.dtsi index 6e79c4b6fe32..3b5debd0ffc9 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcor-testbench.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcor-testbench.dtsi @@ -131,9 +131,30 @@ &sdmmc1 { bus-width = <4>; vmmc-supply = <&vdd_sd>; vqmmc-supply = <&sd_switch>; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc1_dir_pins_b { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + &sdmmc2 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_c>; @@ -147,17 +168,46 @@ &sdmmc2 { st,neg-edge; vmmc-supply = <&v3v3>; vqmmc-supply = <&v3v3>; + bootph-pre-ram; status = "okay"; }; +&sdmmc2_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + +&sdmmc2_d47_pins_c { + bootph-pre-ram; + pins { + bootph-pre-ram; + }; +}; + &uart4 { pinctrl-names = "default"; pinctrl-0 = <&uart4_pins_b>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_b { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &uart7 { pinctrl-names = "default"; pinctrl-0 = <&uart7_pins_a>; diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi index 599ea07bdb19..4b190d1e5a78 100644 --- a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi @@ -144,6 +144,10 @@ channel@19 { }; }; +&bsec { + bootph-all; +}; + &cec { pinctrl-names = "default", "sleep"; pinctrl-0 = <&cec_pins_b>; @@ -151,6 +155,26 @@ &cec { status = "okay"; }; +&clk_hse { + bootph-all; +}; + +&clk_hsi { + bootph-all; +}; + +&clk_lse { + bootph-all; +}; + +&clk_lsi { + bootph-all; +}; + +&clk_csi { + bootph-all; +}; + &crc1 { status = "okay"; }; @@ -199,6 +223,54 @@ &dts { status = "okay"; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + ðernet0 { status = "okay"; pinctrl-0 = <ðernet0_rgmii_pins_a>; @@ -304,6 +376,7 @@ &i2c4 { i2c-scl-rising-time-ns = <185>; i2c-scl-falling-time-ns = <20>; clock-frequency = <400000>; + bootph-all; status = "okay"; /* spare dmas for other usage */ /delete-property/dmas; @@ -339,6 +412,7 @@ pmic: stpmic@33 { interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>; interrupt-controller; #interrupt-cells = <2>; + bootph-all; status = "okay"; regulators { @@ -477,6 +551,13 @@ watchdog { }; }; +&i2c4_pins_a { + bootph-all; + pins { + bootph-all; + }; +}; + &i2c5 { pinctrl-names = "default", "sleep"; pinctrl-0 = <&i2c5_pins_a>; @@ -513,6 +594,7 @@ &ipcc { &iwdg2 { timeout-sec = <32>; + bootph-all; status = "okay"; }; @@ -520,6 +602,7 @@ <dc { pinctrl-names = "default", "sleep"; pinctrl-0 = <<dc_pins_a>; pinctrl-1 = <<dc_sleep_pins_a>; + bootph-some-ram; status = "okay"; port { @@ -541,9 +624,26 @@ &m4_rproc { status = "okay"; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-some-ram; +}; + &pwr_regulators { vdd-supply = <&vdd>; vdd_3v3_usbfs-supply = <&vdd_usb>; + bootph-all; +}; + +&rcc { + bootph-all; }; &rng1 { @@ -608,9 +708,20 @@ &sdmmc1 { st,neg-edge; bus-width = <4>; vmmc-supply = <&v3v3>; + bootph-pre-ram; status = "okay"; }; +&sdmmc1_b4_pins_a { + bootph-pre-ram; + pins1 { + bootph-pre-ram; + }; + pins2 { + bootph-pre-ram; + }; +}; + &sdmmc3 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc3_b4_pins_a>; @@ -731,11 +842,22 @@ &uart4 { pinctrl-0 = <&uart4_pins_a>; pinctrl-1 = <&uart4_sleep_pins_a>; pinctrl-2 = <&uart4_idle_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&uart4_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &uart7 { pinctrl-names = "default", "sleep", "idle"; pinctrl-0 = <&uart7_pins_c>; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v7 6/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards 2026-05-26 9:26 ` [PATCH v7 6/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards Patrice Chotard @ 2026-05-26 10:27 ` sashiko-bot 0 siblings, 0 replies; 16+ messages in thread From: sashiko-bot @ 2026-05-26 10:27 UTC (permalink / raw) To: Patrice Chotard; +Cc: conor+dt, robh, devicetree Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: - [High] Missing boot phase tag on the secondary flash node. - [High] Conflicting pinctrl properties due to missing `/delete-property/`. - [Medium] Meaningful code and commit message mismatch regarding the scope of added tags. - [Low] Redundant boot phase properties on the same node. -- commit 14d5fc0d2bb2bdd48adf7a7f9c0b21cba6b63b86 Author: Patrice Chotard <patrice.chotard@foss.st.com> ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards The bootph-all flag was introduced in dt-schema to define node usage across different boot phases. This patch adds these flags to ensure SD boot for various stm32 boards. > To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be > present in all boot stages, so add missing bootph-all phase flag [Severity: Medium] Is this commit message accurate regarding the scope of the changes? The text only mentions adding the bootph-all flag to timer, gpio, syscfg, clock and uart nodes. However, the patch also introduces bootph-pre-ram and bootph-some-ram tags to other subsystems like QSPI, PMIC, LTDC, OPTEE, SCMI, PSCI, and SDMMC. Could the message be updated to reflect the full scope of the modifications? > diff --git a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts > index 60ce4425a7fdd..ac4e313ca3716 100644 > --- a/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts > +++ b/arch/arm/boot/dts/st/stm32mp157a-icore-stm32mp1-ctouch2.dts [ ... ] > @@ -53,6 +53,16 @@ &uart4 { > status = "okay"; > }; > + > +&uart4_pins_a { > + bootph-all; > + pins1 { > + bootph-all; > + }; > + > + pins2 { > + bootph-all; > + bias-pull-up; > + }; > +}; [Severity: High] Does this introduce mutually exclusive electrical configurations? The base definition for these pins in stm32mp15-pinctrl.dtsi already specifies bias-disable. Because Device Tree append semantics merge node contents, the resulting tree will contain both bias-disable and bias-pull-up. Should this include /delete-property/ bias-disable before setting the pull-up? > diff --git a/arch/arm/boot/dts/st/stm32mp157c-ev1.dts b/arch/arm/boot/dts/st/stm32mp157c-ev1.dts > index 0e65a1862eb53..c4be802ef1e78 100644 > --- a/arch/arm/boot/dts/st/stm32mp157c-ev1.dts > +++ b/arch/arm/boot/dts/st/stm32mp157c-ev1.dts [ ... ] > @@ -314,6 +315,7 @@ &qspi_bk2_sleep_pins_a > reg = <0x58003000 0x1000>, <0x70000000 0x4000000>; > #address-cells = <1>; > #size-cells = <0>; > + bootph-pre-ram; > status = "okay"; > > flash0: flash@0 { > @@ -323,6 +325,7 @@ flash0: flash@0 { > spi-max-frequency = <108000000>; > #address-cells = <1>; > #size-cells = <1>; > + bootph-pre-ram; > }; > > flash1: flash@1 { > @@ -335,6 +338,41 @@ flash1: flash@1 { > }; > }; [ ... ] > +&qspi_bk2_pins_a { > + bootph-pre-ram; > + pins { > + bootph-pre-ram; > + }; > +}; > + > +&qspi_cs2_pins_a { > + bootph-pre-ram; > + pins { > + bootph-pre-ram; > + }; > +}; [Severity: High] Will this omission prevent the secondary flash from being accessible during the SPL boot phase? The patch adds the bootph-pre-ram tag to the QSPI controller, flash0, and the pinmux definitions dedicated to the secondary flash (qspi_bk2_pins_a and qspi_cs2_pins_a), but it is omitted from the flash1 node itself. Should the tag be added to flash1 as well? > diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi > index 4cc633683c6b7..04e91d02cc287 100644 > --- a/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi > +++ b/arch/arm/boot/dts/st/stm32mp15xx-dhcom-som.dtsi [ ... ] > @@ -253,6 +299,8 @@ &i2c4 { > pinctrl-0 = <&i2c4_pins_a>; > i2c-scl-rising-time-ns = <185>; > i2c-scl-falling-time-ns = <20>; > + bootph-all; > + bootph-pre-ram; [Severity: Low] Are both of these properties necessary? Since the bootph-all property inherently specifies that a node is present in all boot phases, adding bootph-pre-ram to the same node appears redundant. > status = "okay"; > /* spare dmas for other usage */ > /delete-property/dmas; -- Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=6 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v7 7/7] arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard ` (5 preceding siblings ...) 2026-05-26 9:26 ` [PATCH v7 6/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards Patrice Chotard @ 2026-05-26 9:26 ` Patrice Chotard 2026-05-26 10:38 ` sashiko-bot 6 siblings, 1 reply; 16+ messages in thread From: Patrice Chotard @ 2026-05-26 9:26 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Patrick Delaunay, Christoph Niedermaier, Marek Vasut Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel, kernel, Patrice Chotard The bootph-all flag was introduced in dt-schema (dtschema/schemas/bootph.yaml) to define node usage across different boot phases. To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be present in all boot stages, so add missing bootph-all phase flag to these nodes to support SD boot. Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> --- arch/arm64/boot/dts/st/stm32mp211.dtsi | 4 +- arch/arm64/boot/dts/st/stm32mp215f-dk.dts | 29 ++++++++ arch/arm64/boot/dts/st/stm32mp231.dtsi | 4 +- arch/arm64/boot/dts/st/stm32mp235f-dk.dts | 95 ++++++++++++++++++++++++++ arch/arm64/boot/dts/st/stm32mp251.dtsi | 4 +- arch/arm64/boot/dts/st/stm32mp255.dtsi | 2 +- arch/arm64/boot/dts/st/stm32mp257f-dk.dts | 103 ++++++++++++++++++++++++++++ arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 105 +++++++++++++++++++++++++++++ 8 files changed, 339 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/st/stm32mp211.dtsi b/arch/arm64/boot/dts/st/stm32mp211.dtsi index 4bfd58b26b51..a79c056fdfb1 100644 --- a/arch/arm64/boot/dts/st/stm32mp211.dtsi +++ b/arch/arm64/boot/dts/st/stm32mp211.dtsi @@ -47,7 +47,7 @@ ck_flexgen_51: clock-200000000 { }; firmware { - optee { + optee: optee { compatible = "linaro,optee-tz"; method = "smc"; }; @@ -70,7 +70,7 @@ scmi_reset: protocol@16 { }; }; - psci { + psci: psci { compatible = "arm,psci-1.0"; method = "smc"; }; diff --git a/arch/arm64/boot/dts/st/stm32mp215f-dk.dts b/arch/arm64/boot/dts/st/stm32mp215f-dk.dts index a1285abc80ca..100f787168d6 100644 --- a/arch/arm64/boot/dts/st/stm32mp215f-dk.dts +++ b/arch/arm64/boot/dts/st/stm32mp215f-dk.dts @@ -48,6 +48,35 @@ &bsec { bootph-all; }; +&optee { + bootph-all; +}; + +&psci { + bootph-all; +}; + +&rifsc { + bootph-all; +}; + +&scmi { + bootph-all; +}; + +&scmi_clk { + bootph-all; +}; + +&scmi_reset { + bootph-all; +}; + +&syscfg { + bootph-all; +}; + &usart2 { + bootph-all; status = "okay"; }; diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi index 9e1d240888ff..8942a5a29a1c 100644 --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi @@ -65,7 +65,7 @@ optee: optee { interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>; }; - scmi { + scmi: scmi { compatible = "linaro,scmi-optee"; #address-cells = <1>; #size-cells = <0>; @@ -117,7 +117,7 @@ scmi_vdda18adc: regulator@7 { }; }; - psci { + psci: psci { compatible = "arm,psci-1.0"; method = "smc"; diff --git a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts index dd4efbe5a46e..0608b978cbe5 100644 --- a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts +++ b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts @@ -131,6 +131,10 @@ &arm_wdt { status = "okay"; }; +&bsec { + bootph-all; +}; + ðernet1 { pinctrl-0 = <ð1_rgmii_pins_b>; pinctrl-1 = <ð1_rgmii_sleep_pins_b>; @@ -153,6 +157,46 @@ phy1_eth1: ethernet-phy@1 { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &i2c2 { pinctrl-names = "default", "sleep"; pinctrl-0 = <&i2c2_pins_b>; @@ -219,6 +263,38 @@ lvds_out0: endpoint { }; }; +&optee { + bootph-all; +}; + +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-all; +}; + +&rcc { + bootph-all; +}; + +&rifsc { + bootph-all; +}; + +&scmi { + bootph-all; +}; + +&scmi_clk { + bootph-all; +}; + &scmi_regu { scmi_vddio1: regulator@0 { regulator-min-microvolt = <1800000>; @@ -258,6 +334,10 @@ scmi_vdd_sdcard: regulator@23 { }; }; +&scmi_reset { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a>; @@ -272,12 +352,27 @@ &sdmmc1 { status = "okay"; }; +&syscfg { + bootph-all; +}; + &usart2 { pinctrl-names = "default", "idle", "sleep"; pinctrl-0 = <&usart2_pins_a>; pinctrl-1 = <&usart2_idle_pins_a>; pinctrl-2 = <&usart2_sleep_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; + +&usart2_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi index 673fbc5632e6..190877cec012 100644 --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi @@ -68,7 +68,7 @@ optee: optee { interrupts = <GIC_PPI 15 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>; }; - scmi { + scmi: scmi { compatible = "linaro,scmi-optee"; #address-cells = <1>; #size-cells = <0>; @@ -139,7 +139,7 @@ v2m0: v2m@48090000 { }; }; - psci { + psci: psci { compatible = "arm,psci-1.0"; method = "smc"; diff --git a/arch/arm64/boot/dts/st/stm32mp255.dtsi b/arch/arm64/boot/dts/st/stm32mp255.dtsi index 7a598f53a2a0..3ba4e6166586 100644 --- a/arch/arm64/boot/dts/st/stm32mp255.dtsi +++ b/arch/arm64/boot/dts/st/stm32mp255.dtsi @@ -40,4 +40,4 @@ venc: venc@480e0000 { clocks = <&rcc CK_BUS_VENC>; access-controllers = <&rifsc 90>; }; -}; \ No newline at end of file +}; diff --git a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts index 8daf3dfd5133..7e0b6502467e 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts @@ -138,6 +138,10 @@ &arm_wdt { status = "okay"; }; +&bsec { + bootph-all; +}; + ðernet1 { pinctrl-0 = <ð1_rgmii_pins_b>; pinctrl-1 = <ð1_rgmii_sleep_pins_b>; @@ -160,6 +164,54 @@ phy1_eth1: ethernet-phy@1 { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &i2c2 { pinctrl-names = "default", "sleep"; pinctrl-0 = <&i2c2_pins_b>; @@ -226,6 +278,38 @@ lvds_out0: endpoint { }; }; +&optee { + bootph-all; +}; + +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-all; +}; + +&rcc { + bootph-all; +}; + +&rifsc { + bootph-all; +}; + +&scmi { + bootph-all; +}; + +&scmi_clk { + bootph-all; +}; + &scmi_regu { scmi_vddio1: regulator@0 { regulator-min-microvolt = <1800000>; @@ -265,6 +349,10 @@ scmi_vdd_sdcard: regulator@23 { }; }; +&scmi_reset { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a>; @@ -279,12 +367,27 @@ &sdmmc1 { status = "okay"; }; +&syscfg { + bootph-all; +}; + &usart2 { pinctrl-names = "default", "idle", "sleep"; pinctrl-0 = <&usart2_pins_a>; pinctrl-1 = <&usart2_idle_pins_a>; pinctrl-2 = <&usart2_sleep_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; + +&usart2_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts index 14e033f365e3..dab54742e01c 100644 --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts @@ -167,6 +167,10 @@ &arm_wdt { status = "okay"; }; +&bsec { + bootph-all; +}; + &combophy { clocks = <&rcc CK_BUS_USB3PCIEPHY>, <&rcc CK_KER_USB3PCIEPHY>, <&pad_clk>; clock-names = "apb", "ker", "pad"; @@ -253,6 +257,54 @@ phy0_eth2: ethernet-phy@1 { }; }; +&gpioa { + bootph-all; +}; + +&gpiob { + bootph-all; +}; + +&gpioc { + bootph-all; +}; + +&gpiod { + bootph-all; +}; + +&gpioe { + bootph-all; +}; + +&gpiof { + bootph-all; +}; + +&gpiog { + bootph-all; +}; + +&gpioh { + bootph-all; +}; + +&gpioi { + bootph-all; +}; + +&gpioj { + bootph-all; +}; + +&gpiok { + bootph-all; +}; + +&gpioz { + bootph-all; +}; + &i2c2 { pinctrl-names = "default", "sleep"; pinctrl-0 = <&i2c2_pins_a>; @@ -344,6 +396,7 @@ timer { }; <dc { + bootph-all; status = "okay"; port { ltdc_ep0_out: endpoint { @@ -353,6 +406,7 @@ ltdc_ep0_out: endpoint { }; &lvds { + bootph-all; status = "okay"; ports { #address-cells = <1>; @@ -374,6 +428,10 @@ lvds_out0: endpoint { }; }; +&optee { + bootph-all; +}; + &pcie_ep { pinctrl-names = "default", "init"; pinctrl-0 = <&pcie_pins_a>; @@ -395,10 +453,38 @@ pcie@0,0 { }; }; +&pinctrl { + bootph-all; +}; + +&pinctrl_z { + bootph-all; +}; + +&psci { + bootph-all; +}; + +&rcc { + bootph-all; +}; + &rtc { status = "okay"; }; +&rifsc { + bootph-all; +}; + +&scmi { + bootph-all; +}; + +&scmi_clk { + bootph-all; +}; + &scmi_regu { scmi_vddio1: regulator@0 { regulator-min-microvolt = <1800000>; @@ -430,6 +516,10 @@ scmi_vdd_sdcard: regulator@23 { }; }; +&scmi_reset { + bootph-all; +}; + &sdmmc1 { pinctrl-names = "default", "opendrain", "sleep"; pinctrl-0 = <&sdmmc1_b4_pins_a>; @@ -444,6 +534,10 @@ &sdmmc1 { status = "okay"; }; +&syscfg { + bootph-all; +}; + &spi3 { pinctrl-names = "default", "sleep"; pinctrl-0 = <&spi3_pins_a>; @@ -521,11 +615,22 @@ &usart2 { pinctrl-0 = <&usart2_pins_a>; pinctrl-1 = <&usart2_idle_pins_a>; pinctrl-2 = <&usart2_sleep_pins_a>; + bootph-all; /delete-property/dmas; /delete-property/dma-names; status = "okay"; }; +&usart2_pins_a { + bootph-all; + pins1 { + bootph-all; + }; + pins2 { + bootph-all; + }; +}; + &usart6 { pinctrl-names = "default", "idle", "sleep"; pinctrl-0 = <&usart6_pins_a>; -- 2.43.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v7 7/7] arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards 2026-05-26 9:26 ` [PATCH v7 7/7] arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards Patrice Chotard @ 2026-05-26 10:38 ` sashiko-bot 0 siblings, 0 replies; 16+ messages in thread From: sashiko-bot @ 2026-05-26 10:38 UTC (permalink / raw) To: Patrice Chotard; +Cc: robh, conor+dt, devicetree Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [High] The patch aims to support SD boot by adding `bootph-all` tags to necessary nodes, but it fails to add them to the SDMMC node (`&sdmmc1`), its pinctrl configurations (e.g., `sdmmc1_b4_pins_a`), and its required regulators (e.g., `scmi_vdd_sdcard`). - [High] The commit message explicitly claims to add the `bootph-all` tag to timer nodes, but the patch completely omits them. - [Medium] Display controller nodes (`<dc` and `&lvds`) in `stm32mp257f-ev1.dts` are inappropriately tagged with `bootph-all`. -- commit ece19a3ebae334de3035a4297c45927575316f46 Author: Patrice Chotard <patrice.chotard@foss.st.com> arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards This commit introduces bootph-all tags to multiple device tree nodes across STMicroelectronics mp2 boards. The stated goal is to preserve essential nodes like timer, gpio, syscfg, clock, and uart across all boot phases to ensure SD boot works. > To ensure SD boot, timer, gpio, syscfg, clock and uart nodes need to be > present in all boot stages, so add missing bootph-all phase flag > to these nodes to support SD boot. [Severity: High] Does this patch actually add the bootph-all property to the timer nodes? Looking through the diff, the base arm architected timer and other timer nodes don't appear to be updated. If the early boot stages rely on the device tree for timer initialization, will this omission prevent SD boot from working properly? > diff --git a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts > index dd4efbe5a46e8..0608b978cbe5a 100644 > --- a/arch/arm64/boot/dts/st/stm32mp235f-dk.dts > +++ b/arch/arm64/boot/dts/st/stm32mp235f-dk.dts [ ... ] > @@ -258,6 +334,10 @@ scmi_vdd_sdcard: regulator@23 { > }; > }; > > +&scmi_reset { > + bootph-all; > +}; > + > &sdmmc1 { > pinctrl-names = "default", "opendrain", "sleep"; > pinctrl-0 = <&sdmmc1_b4_pins_a>; > @@ -272,12 +352,27 @@ &sdmmc1 { > status = "okay"; > }; [Severity: High] Should the &sdmmc1 node, along with its required regulators (like scmi_vdd_sdcard) and pin configurations (like sdmmc1_b4_pins_a), also receive the bootph-all tag? Since the boot loader will remove device tree nodes without early boot tags, it seems the SD controller itself might be missing from the early device tree, which would break the SD boot support. [ ... ] > diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts > index 14e033f365e39..dab54742e01c1 100644 > --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts > +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts [ ... ] > @@ -344,6 +396,7 @@ timer { > }; > > <dc { > + bootph-all; > status = "okay"; > port { > ltdc_ep0_out: endpoint { [Severity: Medium] Are display controller nodes like <dc required during the early SD boot stages? Including these nodes in the heavily memory-constrained early device tree might cause unnecessary binary bloat. Could this safely be left out if it isn't strictly needed for early boot? > @@ -353,6 +406,7 @@ ltdc_ep0_out: endpoint { > }; > > &lvds { > + bootph-all; > status = "okay"; > ports { > #address-cells = <1>; [Severity: Medium] Similar to the <dc node above, does the &lvds node need to be present in all boot stages? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260526-upstream_uboot_properties-v7-0-e17cd424d5db@foss.st.com?part=7 ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2026-05-26 16:31 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-05-26 9:26 [PATCH v7 0/7] Add boot phase tags for STMicroelectronics boards Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 1/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f4 boards Patrice Chotard 2026-05-26 9:41 ` sashiko-bot 2026-05-26 15:52 ` Patrice CHOTARD 2026-05-26 9:26 ` [PATCH v7 2/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics f7 boards Patrice Chotard 2026-05-26 9:54 ` sashiko-bot 2026-05-26 16:31 ` Patrice CHOTARD 2026-05-26 9:26 ` [PATCH v7 3/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics h7 boards Patrice Chotard 2026-05-26 10:02 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 4/7] ARM: dts: stm32: Sort uart nodes by alphabetical order in stm32mp13xx-dhcor-som.dtsi Patrice Chotard 2026-05-26 9:26 ` [PATCH v7 5/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp13 boards Patrice Chotard 2026-05-26 10:16 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 6/7] ARM: dts: stm32: Add boot phase tags for STMicroelectronics mp15 boards Patrice Chotard 2026-05-26 10:27 ` sashiko-bot 2026-05-26 9:26 ` [PATCH v7 7/7] arm64: dts: st: Add boot phase tags for STMicroelectronics mp2 boards Patrice Chotard 2026-05-26 10:38 ` sashiko-bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox