From: Jonathan Cameron <jic23@kernel.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: lars@metafoo.de, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux@roeck-us.net, jdelvare@suse.com,
ak@it-klinger.de, linux-iio@vger.kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 0/4] iio: add Sensirion SLF3x liquid flow sensor support
Date: Tue, 26 May 2026 17:12:14 +0100 [thread overview]
Message-ID: <20260526171214.750c2e25@jic23-huawei> (raw)
In-Reply-To: <20260524205112.26638-1-wafgo01@gmail.com>
On Sun, 24 May 2026 22:49:35 +0200
Wadim Mueller <wafgo01@gmail.com> wrote:
> From: Wadim Mueller <wadim.mueller@cmblu.de>
>
> Hi all,
>
> this RFC adds support for the Sensirion SLF3x family of liquid-flow
> sensors (SLF3S-0600F and SLF3S-4000B). Before I send it as a normal
> patch I'd like to ask three things:
>
> 1. Subsystem. Liquid-flow sensors don't seem to have a home in
> mainline yet. iio/ feels like the natural place for me, but
> please correct me if hwmon (or somewhere else) is prefered.
I'm fine with this type of sensor in IIO, but open to hear from others!
>
> 2. Channel type. IIO has no flow channel type so far. The series
> adds IIO_VOLUMEFLOW with _scale in litres per second per LSB,
> so drivers reporting smaller units only need a fractional scale.
> IIO_MASSFLOW (for gas-flow sensors) was left out on purpose --
> happy to add it in the same series if that's more usefull.
Would be good to have a little more detail on difference etc to have
that discussion. Superficially I'm assuming this is a compressible vs
non compressible thing?
>
> 3. Subdirectory. I put the driver in a new drivers/iio/flow/
> since there is no flow subsytem in iio yet. If colocating with
> drivers/iio/pressure/ (next to sdp500) is preferred I'll respin.
This is easy to change later if we make a wrong decision. For now I think
iio/flow is fine.
Thanks
Jonathan
>
> Patches:
>
> 1/4 iio: types: add IIO_VOLUMEFLOW channel type
> 2/4 dt-bindings: iio: flow: add sensirion,slf3s binding
> 3/4 iio: flow: add Sensirion SLF3x driver
> 4/4 MAINTAINERS: add entry
>
> Tested with a SLF3S-0600F on a TI AM64x platform.
>
> Thanks,
> Wadim
>
> Wadim Mueller (4):
> iio: types: add IIO_VOLUMEFLOW channel type
> dt-bindings: iio: flow: add Sensirion SLF3x liquid flow sensor
> iio: flow: add Sensirion SLF3x liquid flow sensor driver
> MAINTAINERS: add entry for Sensirion SLF3x flow sensor driver
>
> Documentation/ABI/testing/sysfs-bus-iio | 17 ++
> .../bindings/iio/flow/sensirion,slf3s.yaml | 49 ++++
> MAINTAINERS | 7 +
> drivers/iio/Kconfig | 1 +
> drivers/iio/Makefile | 1 +
> drivers/iio/flow/Kconfig | 22 ++
> drivers/iio/flow/Makefile | 7 +
> drivers/iio/flow/slf3x.c | 264 ++++++++++++++++++
> drivers/iio/industrialio-core.c | 1 +
> include/uapi/linux/iio/types.h | 1 +
> tools/iio/iio_event_monitor.c | 2 +
> 11 files changed, 372 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/flow/sensirion,slf3s.yaml
> create mode 100644 drivers/iio/flow/Kconfig
> create mode 100644 drivers/iio/flow/Makefile
> create mode 100644 drivers/iio/flow/slf3x.c
>
>
> base-commit: 3cd8b194bf3428dfa53120fee47e827a7c495815
next prev parent reply other threads:[~2026-05-26 16:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 20:49 [RFC PATCH v1 0/4] iio: add Sensirion SLF3x liquid flow sensor support Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 1/4] iio: types: add IIO_VOLUMEFLOW channel type Wadim Mueller
2026-05-24 21:08 ` sashiko-bot
2026-05-24 21:39 ` Guenter Roeck
2026-05-26 15:59 ` Jonathan Cameron
2026-05-27 14:35 ` Wadim Mueller
2026-05-27 14:35 ` Wadim Mueller
2026-05-26 16:13 ` Jonathan Cameron
2026-05-27 14:35 ` Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 2/4] dt-bindings: iio: flow: add Sensirion SLF3x liquid flow sensor Wadim Mueller
2026-05-24 21:10 ` sashiko-bot
2026-05-26 16:19 ` Jonathan Cameron
2026-05-27 14:35 ` Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 3/4] iio: flow: add Sensirion SLF3x liquid flow sensor driver Wadim Mueller
2026-05-24 21:37 ` sashiko-bot
2026-05-24 21:40 ` Guenter Roeck
2026-05-26 16:06 ` Jonathan Cameron
2026-05-27 14:35 ` Wadim Mueller
2026-05-27 14:35 ` Wadim Mueller
2026-05-26 16:35 ` Jonathan Cameron
2026-05-27 14:35 ` Wadim Mueller
2026-05-26 16:43 ` Jonathan Cameron
2026-05-27 14:34 ` Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 4/4] MAINTAINERS: add entry for Sensirion SLF3x " Wadim Mueller
2026-05-26 16:36 ` Jonathan Cameron
2026-05-27 14:35 ` Wadim Mueller
2026-05-27 14:42 ` Maxwell Doose
2026-05-27 18:36 ` Wadim Mueller
2026-05-26 16:12 ` Jonathan Cameron [this message]
2026-05-27 14:34 ` [RFC PATCH v1 0/4] iio: add Sensirion SLF3x liquid flow sensor support Wadim Mueller
2026-05-27 18:32 ` Jonathan Cameron
2026-05-27 18:42 ` [PATCH v2 0/3] iio: flow: Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-05-27 18:42 ` [PATCH v2 2/3] dt-bindings: iio: flow: add " Wadim Mueller
2026-05-27 19:11 ` sashiko-bot
2026-05-28 9:07 ` Krzysztof Kozlowski
2026-05-30 20:42 ` Wadim Mueller
2026-05-28 10:14 ` [PATCH v2 0/3] iio: flow: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526171214.750c2e25@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=wafgo01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox