Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: lars@metafoo.de, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux@roeck-us.net, jdelvare@suse.com,
	ak@it-klinger.de, linux-iio@vger.kernel.org,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 0/4] iio: add Sensirion SLF3x liquid flow sensor support
Date: Wed, 27 May 2026 19:32:41 +0100	[thread overview]
Message-ID: <20260527193241.308f67b6@jic23-huawei> (raw)
In-Reply-To: <20260527143515.102794-1-wafgo01@gmail.com>

On Wed, 27 May 2026 16:34:58 +0200
Wadim Mueller <wafgo01@gmail.com> wrote:

> On Tue, 26 May 2026 17:12:14 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
> 
> > > 1. Subsystem.  Liquid-flow sensors don't seem to have a home in
> > >    mainline yet.  iio/ feels like the natural place for me, but
> > >    please correct me if hwmon (or somewhere else) is prefered.    
> > 
> > I'm fine with this type of sensor in IIO, but open to hear from others!  
> 
> Thanks - keeping it in iio/ for v2.
> 
> > > 2. Channel type.  IIO has no flow channel type so far.  The series
> > >    adds IIO_VOLUMEFLOW with _scale in litres per second per LSB,
> > >    so drivers reporting smaller units only need a fractional scale.
> > >    IIO_MASSFLOW (for gas-flow sensors) was left out on purpose --
> > >    happy to add it in the same series if that's more usefull.    
> > 
> > Would be good to have a little more detail on difference etc to have
> > that discussion.  Superficially I'm assuming this is a compressible vs
> > non compressible thing?  
> 
> Right - that was the distinction I had in mind:
> 
>   - IIO_VOLUMEFLOW: volumetric rate (m^3/s in SI, exposed as l/s),
>     well-defined for an incompressible fluid where the volume at the
>     sensor equals the volume delivered.  This matches all "liquid
>     flow" sensors I'm aware of (and the SLF3S family in particular).
> 
>   - IIO_MASSFLOW: mass rate (kg/s), the natural unit for gases because
>     the volumetric rate depends on temperature and pressure.  Most
>     "gas flow" parts on the market (Sensirion SFM3xxx, SFC, MFC
>     devices) actually report a "standard volume flow" (e.g. slm at
>     0 degC and 1013 mbar) which is just a fixed-density restatement
>     of mass flow.
Makes sense.
> 
> I left IIO_MASSFLOW out of this series because I don't have a driver
> needing it right now, but if you'd prefer I add it as a stub here
> (name + ABI entry) so the two siblings land together, I can fold that
> in for v2 -- happy either way.
> 

Nope. Good to discuss what it would look like in this over letter, but
the actual introduction needs to wait for a driver that uses it.

> > > 3. Subdirectory.  I put the driver in a new drivers/iio/flow/
> > >    since there is no flow subsytem in iio yet.  If colocating with
> > >    drivers/iio/pressure/ (next to sdp500) is preferred I'll respin.    
> > 
> > This is easy to change later if we make a wrong decision. For now I think
> > iio/flow is fine.  
> 
> Sticking with drivers/iio/flow/ for v2.
> 
> Thanks!
> 
> v2 is up, addressing the inline review feedback from you and Guenter.
> Dropping the RFC tag since the three high-level questions are
> answered.
> 
> Wadim


  reply	other threads:[~2026-05-27 18:32 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 20:49 [RFC PATCH v1 0/4] iio: add Sensirion SLF3x liquid flow sensor support Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 1/4] iio: types: add IIO_VOLUMEFLOW channel type Wadim Mueller
2026-05-24 21:08   ` sashiko-bot
2026-05-24 21:39   ` Guenter Roeck
2026-05-26 15:59     ` Jonathan Cameron
2026-05-27 14:35       ` Wadim Mueller
2026-05-27 14:35     ` Wadim Mueller
2026-05-26 16:13   ` Jonathan Cameron
2026-05-27 14:35     ` Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 2/4] dt-bindings: iio: flow: add Sensirion SLF3x liquid flow sensor Wadim Mueller
2026-05-24 21:10   ` sashiko-bot
2026-05-26 16:19   ` Jonathan Cameron
2026-05-27 14:35     ` Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 3/4] iio: flow: add Sensirion SLF3x liquid flow sensor driver Wadim Mueller
2026-05-24 21:37   ` sashiko-bot
2026-05-24 21:40   ` Guenter Roeck
2026-05-26 16:06     ` Jonathan Cameron
2026-05-27 14:35       ` Wadim Mueller
2026-05-27 14:35     ` Wadim Mueller
2026-05-26 16:35   ` Jonathan Cameron
2026-05-27 14:35     ` Wadim Mueller
2026-05-26 16:43   ` Jonathan Cameron
2026-05-27 14:34     ` Wadim Mueller
2026-05-24 20:49 ` [RFC PATCH v1 4/4] MAINTAINERS: add entry for Sensirion SLF3x " Wadim Mueller
2026-05-26 16:36   ` Jonathan Cameron
2026-05-27 14:35     ` Wadim Mueller
2026-05-27 14:42       ` Maxwell Doose
2026-05-27 18:36         ` Wadim Mueller
2026-05-26 16:12 ` [RFC PATCH v1 0/4] iio: add Sensirion SLF3x liquid flow sensor support Jonathan Cameron
2026-05-27 14:34   ` Wadim Mueller
2026-05-27 18:32     ` Jonathan Cameron [this message]
2026-05-27 18:42 ` [PATCH v2 0/3] iio: flow: Sensirion SLF3S liquid flow sensor Wadim Mueller
2026-05-27 18:42   ` [PATCH v2 2/3] dt-bindings: iio: flow: add " Wadim Mueller
2026-05-27 19:11     ` sashiko-bot
2026-05-28  9:07     ` Krzysztof Kozlowski
2026-05-30 20:42       ` Wadim Mueller
2026-05-28 10:14   ` [PATCH v2 0/3] iio: flow: " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260527193241.308f67b6@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=wafgo01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox