Re: [PATCH v3 1/3] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2162 bytes --]

On Wed, May 27, 2026 at 09:28:13PM +0800, CL Wang wrote:
> Document devicetree bindings for Andes ATCDMAC300 DMA engine
> 
> ATCDMAC300 is the IP name, which is embedded in AndesCore-based
> platforms or SoCs such as AE350 and Qilai.
> 
> Signed-off-by: CL Wang <cl634@andestech.com>
> 
> ---
>   Changes for v3:
>     - Rename DT binding file from andestech,qilai-dma.yaml to
>       andestech,ae350-dma.yaml
>     - Deprecate IP-core-based compatible usage and align with
>       SoC/platform-based
>     - Dropped Acked-by tag from Conor Dooley due to the above change.
> ---
>  .../bindings/dma/andestech,ae350-dma.yaml     | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> 
> diff --git a/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> new file mode 100644
> index 000000000000..0f5ffdf1d160
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/andestech,ae350-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes ATCDMAC300 DMA Controller
> +
> +maintainers:
> +  - CL Wang <cl634@andestech.com>
> +
> +allOf:
> +  - $ref: dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - andestech,qilai-dma
> +          - const: andestech,ae350-dma
> +      - const: andestech,ae350-dma
> +
> +  reg:
> +    minItems: 1
> +    maxItems: 2
> +    description:
> +      First entry is the DMA controller register range (required).
> +      Second entry is the cache control in IOCP controller (optional).

This can be an items list FYI. Syntax is
reg:
  minItems: 1
  items:
    - description: foo
    - description: bar

Fix that and you can re-add my ack
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]