Re: [PATCH v3 1/3] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect use of 'additionalProperties: false' when referencing a common schema.
--

commit f1fe6e40b9cc08af2c1dbda4fec526d830ad7eb3
Author: CL Wang <cl634@andestech.com>

dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine

This commit documents the devicetree bindings for the Andes ATCDMAC300 DMA
engine, which is embedded in platforms like AE350 and Qilai.

> diff --git a/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml
> new file mode 100644
> index 0000000000000..0f5ffdf1d1609
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/andestech,ae350-dma.yaml

[ ... ]

> +allOf:
> +  - $ref: dma-controller.yaml#
> +

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#dma-cells"
> +
> +additionalProperties: false

[Severity: Low]
Should this be unevaluatedProperties: false instead?

Since this binding references the common dma-controller.yaml schema via an
allOf block, using additionalProperties: false will cause dt_binding_check
to reject standard DMA properties (like dma-channels or dma-requests)
because they aren't explicitly defined in this file. 

Using unevaluatedProperties: false allows properties defined in referenced
schemas to be properly evaluated and permitted.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527132815.1211195-1-cl634@andestech.com?part=1