Re: [PATCH v9 1/3] dt-bindings: clock: imx95-blk-ctl: Allow child nodes

[Krzysztof Kozlowski <krzk@kernel.org>]

On Tue, May 26, 2026 at 04:57:20PM +0800, Guoniu Zhou wrote:
> Add support for child nodes in the imx95-blk-ctl binding to match
> the driver implementation which calls devm_of_platform_populate().

This is a new device, not a legacy, so you do not have exception to
document things post factum.

> 
> Add #address-cells, #size-cells properties and patternProperties
> to allow child device nodes with their own bindings.
> 
> Signed-off-by: Guoniu Zhou <guoniu.zhou@oss.nxp.com>
> ---
> Changes in v9:
> - New patch to address the issue of formatter acting as a child node of syscon
> ---
>  .../devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml          | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> index 27403b4c52d6..33ad1c15cc9c 100644
> --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> @@ -39,6 +39,17 @@ properties:
>        ID in its "clocks" phandle cell. See
>        include/dt-bindings/clock/nxp,imx95-clock.h
>  
> +  '#address-cells':

Use consistent quotes, either ' or "

> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +patternProperties:
> +  "^.*@[0-9a-f]+$":
> +    type: object
> +    description: Child nodes with their own bindings

No, you need SPECIFIC children listed here.

Also, description is completely redundant. You did not say anything
useful here.

Best regards,
Krzysztof