Re: [PATCH v9 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The atomic_check callback modifies the global connector->display_info state, which violates the DRM atomic API contract. This problem wasn't introduced by this patch, but modifying persistent objects in atomic_check causes test-only commits to have side effects.
--

commit 644453a6e6cb6a36d4d9248a4a519cc2c40ae524
Author: Damon Ding <damon.ding@rock-chips.com>

drm/bridge: analogix_dp: Rename and simplify is_rockchip()

This commit renames the inline helper is_rockchip() to
analogix_dp_is_rockchip() to follow driver namespace conventions. It also
replaces chained equality comparisons with a switch-case layout for better
readability.

> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 8cf6b73bceac0..116de3bd83a30 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -870,7 +870,7 @@ static int analogix_dp_bridge_atomic_check(struct drm_bridge *bridge,
>  	struct drm_display_info *di = &conn_state->connector->display_info;
>  	u32 mask = BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444) | BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR422);
>  
> -	if (is_rockchip(dp->plat_data->dev_type)) {
> +	if (analogix_dp_is_rockchip(dp->plat_data->dev_type)) {
>  		if ((di->color_formats & mask)) {
>  			DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n");
>  			di->color_formats &= ~mask;
>  			di->color_formats |= BIT(DRM_OUTPUT_COLOR_FORMAT_RGB444);
>  			di->bpc = 8;

[Severity: High]
This isn't a bug introduced by this patch, but does modifying di->color_formats
and di->bpc violate the DRM atomic API contract?

The atomic_check callbacks can be executed for both real and test-only
commits. By modifying conn_state->connector->display_info directly, aren't we
altering the persistent connector state rather than the duplicated atomic
state?

This could cause test-only commits from userspace to incorrectly mutate global
state and potentially break subsequent real commits or format negotiations.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527024336.191433-1-damon.ding@rock-chips.com?part=8