Re: [PATCH v9 10/10] drm/rockchip: analogix_dp: Add support for RK3576

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Incomplete hardware configuration or mandatory syscon lookup failure for RK3576 eDP.
--

commit dba937ab560aacd4dd5f156770d047256a5462b7
Author: Damon Ding <damon.ding@rock-chips.com>

drm/rockchip: analogix_dp: Add support for RK3576

This commit adds Analogix eDP support for the RK3576 platform.
It introduces a new chip data table and device tree matching entry
for basic eDP functionality.

> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index d2af5eb29dbb5..d4c5dd61e95bb 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
[ ... ]
> @@ -522,6 +522,14 @@ static const struct rockchip_dp_chip_data rk3288_dp[] = {
>  	{ /* sentinel */ }
>  };
>  
> +static const struct rockchip_dp_chip_data rk3576_edp[] = {
> +	{
> +		.chip_type = RK3576_EDP,
> +		.reg = 0x27dc0000,

[Severity: High]
The commit message states RK3576 fully matches the RK3588 design. RK3588 uses
the .edp_mode GRF field to switch the combo PHY into eDP mode during
rockchip_dp_poweron(). Is the .edp_mode field intentionally omitted here? If
RK3576 requires this bit like RK3588, will the hardware fail to power on
correctly without it?

Additionally, if RK3576 genuinely does not use the GRF for this and it is
intentionally omitted, does rockchip_dp_of_probe() still unconditionally call
syscon_regmap_lookup_by_phandle(np, "rockchip,grf")? If so, will omitting the
property from the device tree cause an immediate probe failure?

> +	},
> +	{ /* sentinel */ }
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527024336.191433-1-damon.ding@rock-chips.com?part=10