From: sashiko-bot@kernel.org
To: "Junhui Liu" <junhui.liu@pigmoral.tech>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] riscv: dts: spacemit: k1: Add Banana Pi BPI-CM6 IO board
Date: Thu, 28 May 2026 06:19:17 +0000 [thread overview]
Message-ID: <20260528061918.300F91F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260528-bpi-cm6-v2-3-d0eb3f236cea@pigmoral.tech>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `&sdhci0` node references `&mmc1_cfg` and `&mmc1_uhs_cfg` via `pinctrl-0` and `pinctrl-1`, but these nodes are not defined anywhere in the included DTSI files or the patch itself.
--
commit c74b8c1d21d14e7c0a04fc8690e5deac751ac08a
Author: Junhui Liu <junhui.liu@pigmoral.tech>
riscv: dts: spacemit: k1: Add Banana Pi BPI-CM6 IO board
This commit adds initial support for the Banana Pi BPI-CM6 IO board, which
combines the BPI-CM6 compute module with an IO carrier board. It introduces
the necessary device tree nodes to enable peripherals like UART, eMMC, SD
card, I2C, PCIe, USB, and dual Ethernet interfaces.
Link: https://docs.banana-pi.org/en/BPI-CM6/BananaPi_BPI-CM6
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-cm6-io.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-cm6-io.dts
> new file mode 100644
> index 0000000000000..137b7ef3fc7b4
> --- /dev/null
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-cm6-io.dts
[ ... ]
> +&sdhci0 {
> + pinctrl-names = "default", "uhs";
> + pinctrl-0 = <&mmc1_cfg>;
> + pinctrl-1 = <&mmc1_uhs_cfg>;
[Severity: Low]
Will this cause a device tree compilation failure?
It appears that mmc1_cfg and mmc1_uhs_cfg are not defined in the included
dtsi files or in this patch. Could this result in an unresolved phandle
error when building the device tree?
> + bus-width = <4>;
> + cd-gpios = <&gpio K1_GPIO(80) (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260528-bpi-cm6-v2-0-d0eb3f236cea@pigmoral.tech?part=3
prev parent reply other threads:[~2026-05-28 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 5:22 [PATCH v2 0/3] spacemit: k1: Add support for Banana Pi BPI-CM6 IO board Junhui Liu
2026-05-28 5:22 ` [PATCH v2 1/3] dt-bindings: riscv: spacemit: Add Banana Pi BPI-CM6 compatible Junhui Liu
2026-05-28 5:22 ` [PATCH v2 2/3] riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups Junhui Liu
2026-05-28 5:45 ` sashiko-bot
2026-05-28 5:22 ` [PATCH v2 3/3] riscv: dts: spacemit: k1: Add Banana Pi BPI-CM6 IO board Junhui Liu
2026-05-28 6:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528061918.300F91F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=junhui.liu@pigmoral.tech \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox