Re: [PATCH v2 2/3] riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The patch separates `gmac_clk_ref` pins into independent pinctrl groups but fails to update the OrangePi RV2 board device tree (`k1-orangepi-rv2.dts`), silently dropping its Ethernet reference clock pinmux configuration.
--

commit 4736202eaeb8dff5f83c1f6977e4a98ac6644bcc
Author: Junhui Liu <junhui.liu@pigmoral.tech>

riscv: dts: spacemit: k1: Split gmac_clk_ref into independent pinctrl groups

The gmac_clk_ref signal is optional for the GMAC controller and is not
strictly required for all hardware designs. The pins for gmac0_clk_ref
(GPIO 45) and gmac1_clk_ref (GPIO 46) may also be used as GPIOs for
other functions even when the Ethernet controller is active.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> index b13dcb10f4d66..39682e8b4ed91 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> @@ -27,8 +27,16 @@ gmac0-pins {
>  				 <K1_PADCONF(11, 1)>,	/* gmac0_tx_en */
>  				 <K1_PADCONF(12, 1)>,	/* gmac0_mdc */
>  				 <K1_PADCONF(13, 1)>,	/* gmac0_mdio */
> -				 <K1_PADCONF(14, 1)>,	/* gmac0_int_n */
> -				 <K1_PADCONF(45, 1)>;	/* gmac0_clk_ref */
> +				 <K1_PADCONF(14, 1)>;	/* gmac0_int_n */
> +
> +			bias-pull-up = <0>;
> +			drive-strength = <21>;
> +		};
> +	};

[ ... ]

> @@ -51,8 +59,16 @@ gmac1-pins {
>  				 <K1_PADCONF(40, 1)>,	/* gmac1_tx_en */
>  				 <K1_PADCONF(41, 1)>,	/* gmac1_mdc */
>  				 <K1_PADCONF(42, 1)>,	/* gmac1_mdio */
> -				 <K1_PADCONF(43, 1)>,	/* gmac1_int_n */
> -				 <K1_PADCONF(46, 1)>;	/* gmac1_clk_ref */
> +				 <K1_PADCONF(43, 1)>;	/* gmac1_int_n */
> +
> +			bias-pull-up = <0>;
> +			drive-strength = <21>;
> +		};
> +	};

[Severity: High]
Does this change silently drop the Ethernet reference clock pinmux
configuration for the OrangePi RV2 board?

The k1-orangepi-rv2.dts board file still relies on &gmac0_cfg and &gmac1_cfg
but wasn't updated in this patch to include the new &gmac0_clk_ref_cfg and
&gmac1_clk_ref_cfg groups. Without this update, OrangePi RV2 will lose the
pinmux configurations for GPIO 45 and 46, which may cause network failure.

The commit message mentions an intent to preserve the previous pinmux behavior
for boards without public schematics. It seems the omission of OrangePi RV2
breaks this contract. A search forward in the patch series confirms this issue
is not resolved by a later commit.

Could k1-orangepi-rv2.dts be updated to include the new pinmux groups to
preserve its original configuration?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528-bpi-cm6-v2-0-d0eb3f236cea@pigmoral.tech?part=2