From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org,
imx@lists.linux.dev, Frank.Li@kernel.org
Subject: Re: [PATCH v1 1/1] arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO
Date: Thu, 28 May 2026 22:25:29 +0000 [thread overview]
Message-ID: <20260528222530.3DAB01F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260528220550.34891-1-stefano.r@variscite.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete implementation for Sonata carrier board: missing TPM reset GPIO for i.MX91 DTS.
--
commit 0e430ef40e9b74a6759e3f9cd5622101a105206c
Author: Stefano Radaelli <stefano.r@variscite.com>
arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO
Add the reset GPIO for the TPM device on the Sonata carrier board and
label the node accordingly.
> diff --git a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
> index 0f3d2e488f4a9..d2c7d83e1624a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
> @@ -274,6 +274,8 @@ pca6408_2: gpio@21 {
> st33ktpm2xi2c: tpm@2e {
> compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
> reg = <0x2e>;
> + label = "tpm";
> + reset-gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
[Severity: Medium]
Since the commit message indicates the reset GPIO is added for the TPM device
on the Sonata carrier board, is there a regression here where
arch/arm64/boot/dts/freescale/imx91-var-dart-sonata.dts is missing this
update?
The Sonata carrier board is used with both i.MX95 and i.MX91 SoMs, and
imx91-var-dart-sonata.dts instantiates the exact same PCA9534 GPIO expander
and ST33K TPM hardware.
Should it be updated to include the reset-gpios and label properties as well
to avoid leaving the TPM uninitialized on the i.MX91 configuration?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260528220550.34891-1-stefano.r@variscite.com?part=1
prev parent reply other threads:[~2026-05-28 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 22:05 [PATCH v1 1/1] arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO Stefano Radaelli
2026-05-28 22:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528222530.3DAB01F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox