[PATCH v1 1/1] arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO

[PATCH v1 1/1] arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO

[Stefano Radaelli]

From: Stefano Radaelli <stefano.r@variscite.com>

Add the reset GPIO for the TPM device on the Sonata carrier board and
label the node accordingly.

Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
 arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
index 7985a42f5785..7a58ad38ffb4 100644
--- a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
+++ b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
@@ -278,6 +278,8 @@ pca6408_2: gpio@21 {
 	st33ktpm2xi2c: tpm@2e {
 		compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
 		reg = <0x2e>;
+		label = "tpm";
+		reset-gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
 	};
 };
 
-- 
2.47.3

Re: [PATCH v1 1/1] arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete implementation for Sonata carrier board: missing TPM reset GPIO for i.MX91 DTS.
--

commit 0e430ef40e9b74a6759e3f9cd5622101a105206c
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: imx95-var-dart-sonata: add TPM reset GPIO

Add the reset GPIO for the TPM device on the Sonata carrier board and
label the node accordingly.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
> index 0f3d2e488f4a9..d2c7d83e1624a 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-var-dart-sonata.dts
> @@ -274,6 +274,8 @@ pca6408_2: gpio@21 {
>  	st33ktpm2xi2c: tpm@2e {
>  		compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
>  		reg = <0x2e>;
> +		label = "tpm";
> +		reset-gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
Since the commit message indicates the reset GPIO is added for the TPM device
on the Sonata carrier board, is there a regression here where
arch/arm64/boot/dts/freescale/imx91-var-dart-sonata.dts is missing this
update?

The Sonata carrier board is used with both i.MX95 and i.MX91 SoMs, and
imx91-var-dart-sonata.dts instantiates the exact same PCA9534 GPIO expander
and ST33K TPM hardware.

Should it be updated to include the reset-gpios and label properties as well
to avoid leaving the TPM uninitialized on the i.MX91 configuration?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260528220550.34891-1-stefano.r@variscite.com?part=1