Re: [PATCH v8 4/5] arm64: dts: qcom: purwa: Override Iris clocks and operating points

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree references an undefined macro `VIDEO_CC_MVS0_BSE_CLK`, which will cause a build failure.
--

commit b94ef34ae2cd7814137efba66c178dd0760ea44d
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>

arm64: dts: qcom: purwa: Override Iris clocks and operating points

This commit modifies the device tree for the Purwa platform to override the
Iris clocks and operating points. It provides a new OPP table specific to the
X1P42100 platform to ensure correct performance levels.

> diff --git a/arch/arm64/boot/dts/qcom/purwa.dtsi b/arch/arm64/boot/dts/qcom/purwa.dtsi
> index 9ab4f26b35f29..b842ce5e7262e 100644
> --- a/arch/arm64/boot/dts/qcom/purwa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/purwa.dtsi

[ ... ]

> @@ -157,6 +158,55 @@ &gpucc {
>  	compatible = "qcom,x1p42100-gpucc";
>  };
>  
> +&iris {
> +	compatible = "qcom,x1p42100-iris";
> +
> +	clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
> +		 <&videocc VIDEO_CC_MVS0C_CLK>,
> +		 <&videocc VIDEO_CC_MVS0_CLK>,
> +		 <&videocc VIDEO_CC_MVS0_BSE_CLK>;

[Severity: Low]
Is VIDEO_CC_MVS0_BSE_CLK defined anywhere in the kernel? 

It appears this macro might be missing from the clock dt-bindings headers, 
which would cause the C preprocessor to leave it unexpanded as a string 
literal. Does this cause a dtc syntax error and break the device tree build?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-enable_iris_on_purwa-v8-0-b1b9670459ab@oss.qualcomm.com?part=4