Re: [PATCH v8 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing required properties in the conditional block for `qcom,x1p42100-iris` allows incomplete device tree nodes to pass validation.
- [Medium] Broken schema conditional matching for `qcom,x1p42100-iris` causes valid device tree nodes to fail validation.
--

commit f911896de9da99ee2b5652949237c15bf6d78f44
Author: Wangao Wang <wangao.wang@oss.qualcomm.com>

dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible

Document the new compatible string "qcom,x1p42100-iris". Unlike SM8550 where
the BSE is clocked implicitly, x1p42100 exposes a dedicated BSE clock that
requires explicit configuration.

> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> index 9c4b760508b50..0400ca1bff05d 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml

[ ... ]

> @@ -115,6 +119,23 @@ allOf:
>            maxItems: 1
>          reset-names:
>            maxItems: 1
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,x1p42100-iris

[Severity: Medium]
Should this use "contains: enum" or "contains: const" instead of a direct
enum match?

Since the compatible property is evaluated as an array of strings in device
tree validation, a direct enum match will fail against an array. This could
cause the condition to always evaluate to false, falling through to the else
block which restricts clocks to maxItems: 3, causing correctly configured
nodes to fail validation.

> +    then:
> +      properties:
> +        clocks:
> +          minItems: 4
> +        clock-names:
> +          minItems: 4

[Severity: Medium]
Since minItems constraints only apply if the property is actually present,
should clocks and clock-names be added to a required list in this block?

Without them, a device tree node omitting the clocks entirely might silently
pass schema validation, even though the fourth clock is mandatory for this
variant to operate.

> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 3
> +        clock-names:
> +          maxItems: 3

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-enable_iris_on_purwa-v8-0-b1b9670459ab@oss.qualcomm.com?part=1