Re: [PATCH v3 01/15] dt-bindings: display: ti: Move ti,am62l-dss binding to a new binding file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Moving ti,am62l-dss to a separate schema file dropped validation constraints on the 'ports' node, allowing invalid device trees to pass validation.
--

commit 85fc6244328cdbbf7ce0fee4d16b0be90b2b65a0
Author: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

dt-bindings: display: ti: Move ti,am62l-dss binding to a new binding file

This commit moves the ti,am62l-dss binding out of the ti,am65x-dss.yaml
schema into its own dedicated file. This change is intended to simplify the
original file and adhere to a "binding file per DSS model" structure.

> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am62l-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am62l-dss.yaml
> new file mode 100644
> index 0000000000000..ce6185dca18d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am62l-dss.yaml
[ ... ]
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description:
> +          The DSS DPI output port node from video port 1, which may be
> +          connected to the external DPI pins or to the internal DSI Tx
> +          controller.
> +
> +    required:
> +      - port@0
> +

[Severity: Medium]
Does moving this binding to a separate file drop the validation constraint on
the ports node?

In the original ti,am65x-dss.yaml file, the ti,am62l-dss hardware was
restricted by explicitly setting port@1: false inside the ports node (as
seen in the removed block below). This enforced the single-output limitation.

Because graph.yaml handles ports using patternProperties, it allows any
number of ports by default. Without an explicit restriction here (such as
port@1: false or additionalProperties: false), will dt-validate now silently
accept invalid device tree nodes that define extra spurious output ports?

[ ... ]
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> index 49a007cbcd3aa..75d9640398f0a 100644
> --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
> +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml
[ ... ]
> @@ -189,38 +164,7 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: ti,am62l-dss
> -    then:
> -      properties:
> -        ports:
> -          properties:
> -            port@1: false
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-beagley-ai-display-v3-0-7fefdc5d1adf@ideasonboard.com?part=1