From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 2/2] ARM: tegra: Add device-tree for Motorola Atrix 4G and Droid X2
Date: Fri, 29 May 2026 09:01:41 +0000 [thread overview]
Message-ID: <20260529090142.334F81F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260529083752.44796-3-clamor95@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Makefile entries are not sorted in alphabetical order.
--
commit 603a9b9432cb122e3832a30e5f3ca3092b240477
Author: Svyatoslav Ryhel <clamor95@gmail.com>
ARM: tegra: Add device-tree for Motorola Atrix 4G and Droid X2
This commit adds device-tree files for the Motorola Atrix 4G and Droid X2,
which are NVIDIA Tegra20-based smartphones.
> diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
> index faf591485ada7..3075f26131d4c 100644
> --- a/arch/arm/boot/dts/nvidia/Makefile
> +++ b/arch/arm/boot/dts/nvidia/Makefile
> @@ -21,6 +21,8 @@ dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) += \
> tegra20-colibri-eval-v3.dtb \
> tegra20-colibri-iris.dtb \
> tegra20-medcom-wide.dtb \
> + tegra20-motorola-olympus.dtb \
> + tegra20-motorola-daytona.dtb \
[Severity: Low]
This isn't a bug, but should these Makefile entries be sorted alphabetically?
Placing tegra20-motorola-daytona.dtb before tegra20-motorola-olympus.dtb
would maintain the existing order of the list.
> tegra20-paz00.dtb \
> tegra20-plutux.dtb \
> tegra20-seaboard.dtb \
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529083752.44796-1-clamor95@gmail.com?part=2
prev parent reply other threads:[~2026-05-29 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 8:37 [PATCH v1 0/2] ARM: tegra: Add device-tree for Motorola Atrix 4G and Droid X2 Svyatoslav Ryhel
2026-05-29 8:37 ` [PATCH v1 1/2] dt-bindings: arm: tegra: Add Motorola Artix " Svyatoslav Ryhel
2026-05-29 16:39 ` Conor Dooley
2026-05-29 8:37 ` [PATCH v1 2/2] ARM: tegra: Add device-tree for Motorola Atrix " Svyatoslav Ryhel
2026-05-29 9:01 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529090142.334F81F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox