From: sashiko-bot@kernel.org
To: "Mark Tseng" <chun-jen.tseng@mediatek.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/1] arm64: dts: mediatek: mt8186: change CCI OPP scaling mapping
Date: Fri, 29 May 2026 10:15:45 +0000 [thread overview]
Message-ID: <20260529101545.E976B1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260529100514.52082-2-chun-jen.tseng@mediatek.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Logic inversion in commit message due to a grammatical error.
--
commit fce735e343be0e6db7c638f33d66995b238098d4
Author: Mark Tseng <chun-jen.tseng@mediatek.com>
arm64: dts: mediatek: mt8186: change CCI OPP scaling mapping
This commit updates the CCI OPP table frequencies for the MT8186, raising the
minimum frequency from 500MHz to 800MHz to prevent the system from stalling.
> The original CCI OPP table minimum frequency 500Mhz is too low to cause
> system stall, So it need update to new version, 1.4G ~ 0.8G.
[Severity: Low]
This isn't a bug, but the phrase "too low to cause system stall" literally
reads as though the frequency is not high enough to cause a stall.
Would it be clearer to write something like "too low, causing a system stall"
or "so low that it causes a system stall" to avoid inverting the intended
meaning?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529100514.52082-2-chun-jen.tseng@mediatek.com?part=1
prev parent reply other threads:[~2026-05-29 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 10:05 [PATCH v1 0/1] arm64: dts: mediatek: mt8186: change CCI OPP scaling mapping Mark Tseng
2026-05-29 10:05 ` [PATCH v1 1/1] " Mark Tseng
2026-05-29 10:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529101545.E976B1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=chun-jen.tseng@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox