Re: [PATCH v5 01/10] ACPI: APEI: GHES: share macros via a private header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The patch un-staticizes and exposes 7 core internal functions without documenting this behavior in the commit message.
- [Low] The new header `include/acpi/ghes_cper.h` uses `enum fixed_addresses` in function prototypes without including `<asm/fixmap.h>`.
--

commit 30e8939fe8b7b5fe0f59a4dfeee62c476774ac25
Author: Ahmed Tiba <ahmed.tiba@arm.com>

ACPI: APEI: GHES: share macros via a private header

This patch moves CPER helper macros from ghes.c to a new private header.
It aims to allow sharing these macros with upcoming helper files without
functional changes.

> Carve the CPER helper macros out of ghes.c and place them in a private
> header so they can be shared with upcoming helper files. This is a
> mechanical include change with no functional differences.

[Severity: Medium]
Is this description accurate?

The patch removes the static keyword from seven internal functions (such as
ghes_new() and ghes_fini()), exposing them.

Could the commit message be more precise about these function visibility
changes?

> diff --git a/include/acpi/ghes_cper.h b/include/acpi/ghes_cper.h
> new file mode 100644
> index 0000000000000..6b7632cfaf667
> --- /dev/null
> +++ b/include/acpi/ghes_cper.h
[ ... ]
> +#include <acpi/ghes.h>
[ ... ]
> +#ifdef CONFIG_ACPI_APEI
> +struct ghes *ghes_new(struct acpi_hest_generic *generic);
> +void ghes_fini(struct ghes *ghes);
> +
> +int ghes_read_estatus(struct ghes *ghes,
> +		      struct acpi_hest_generic_status *estatus,
> +		      u64 *buf_paddr, enum fixed_addresses fixmap_idx);

[Severity: Low]
Does this header need to include <asm/fixmap.h>?

Without it, is enum fixed_addresses treated as a new incomplete type scoped
to the parameter list, potentially causing a conflicting types compilation
error when the functions are defined?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-topics-ahmtib01-ras_ffh_arm_internal_review-v5-0-2e0500d42642@arm.com?part=1