From: sashiko-bot@kernel.org
To: "Jun Yan" <jerrysteve1101@gmail.com>
Cc: conor+dt@kernel.org, neil.armstrong@linaro.org,
devicetree@vger.kernel.org, robh@kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: amlogic: meson-axg: Add missing nand_rb0 pin to nand_all_pins
Date: Fri, 29 May 2026 14:27:47 +0000 [thread overview]
Message-ID: <20260529142747.6184A1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260529140605.1070764-2-jerrysteve1101@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] eMMC boot failure due to BOOT_13 pinctrl conflict. Fix: Add status = "disabled" to the nfc node in meson-axg.dtsi.
--
commit c218ae59948e8bab6c68fcfdc539ef678ec3bdba
Author: Jun Yan <jerrysteve1101@gmail.com>
arm64: dts: amlogic: meson-axg: Add missing nand_rb0 pin to nand_all_pins
This commit updates the nand_all_pins pinctrl node to include the missing
nand_rb0 pin for the meson-axg platform. This ensures the ready/busy pin
is properly configured for NAND controller operation.
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index f1f53fd98ae25..b7a7f4fae7dc2 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
[ ... ]
> @@ -481,7 +481,8 @@ mux {
> "nand_ale",
> "nand_cle",
> "nand_wen_clk",
> - "nand_ren_wr";
> + "nand_ren_wr",
> + "nand_rb0";
[Severity: High]
This isn't a bug introduced by this patch, but adding this pin exposes a
pre-existing issue where the nfc node unconditionally claims nand_all_pins.
Since nand_rb0 and emmc_ds share the BOOT_13 pin, does this force a strict
pinctrl collision between the NAND and eMMC nodes?
If this collision causes the eMMC storage probe to fail and breaks the boot
process, should we add status = "disabled" to the nfc node in meson-axg.dtsi
to prevent this conflict when NAND is not actively used?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529140605.1070764-1-jerrysteve1101@gmail.com?part=1
next prev parent reply other threads:[~2026-05-29 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 14:05 [PATCH 0/3] arm64: dts: amlogic: meson-axg: NAND fix and PCIe PHY adjustment Jun Yan
2026-05-29 14:05 ` [PATCH 1/3] arm64: dts: amlogic: meson-axg: Add missing nand_rb0 pin to nand_all_pins Jun Yan
2026-05-29 14:27 ` sashiko-bot [this message]
2026-05-29 14:05 ` [PATCH 2/3] arm64: dts: amlogic: meson-axg: Disable pcie_phy node by default Jun Yan
2026-05-29 14:05 ` [PATCH 3/3] arm64: dts: amlogic: meson-axg-s400: Enable pcie_phy Jun Yan
2026-05-29 15:13 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529142747.6184A1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jerrysteve1101@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox