Re: [PATCH 3/3] arm64: dts: amlogic: meson-axg-s400: Enable pcie_phy

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The commit enables `&pcie_phy` to support PCIe on the `meson-axg-s400` board, but fails to enable its required analog PHY dependency `&mipi_pcie_analog_dphy`, leaving PCIe completely non-functional.
--

commit 655f261362c29dc56c1723f3469b32281d8fffb8
Author: Jun Yan <jerrysteve1101@gmail.com>

arm64: dts: amlogic: meson-axg-s400: Enable pcie_phy

This commit enables pcie_phy on the meson-axg-s400 board to support PCIe
functionality, as it is now disabled by default in the meson-axg dtsi.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 285c6ac1dd613..7ba249cc3d569 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -448,6 +448,10 @@ &pcieB {
>  	status = "okay";
>  };
>  
> +&pcie_phy {
> +	status = "okay";
> +};

[Severity: High]
Does this node also need to enable the mipi_pcie_analog_dphy dependency?

In meson-axg.dtsi, the pcie_phy node depends on mipi_pcie_analog_dphy via
the property phys = <&mipi_pcie_analog_dphy>. Because the analog PHY is
disabled by default, the core driver model does not instantiate its platform
device and no PHY provider is registered.

This causes devm_phy_get(dev, "analog") to return -EPROBE_DEFER during
the probe of pcie_phy, which in turn causes the PCIe controllers (pcieA
and pcieB) to infinitely defer probing as well.

> +
>  &pwm_ab {
>  	status = "okay";
>  	pinctrl-0 = <&pwm_a_x20_pins>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529140605.1070764-1-jerrysteve1101@gmail.com?part=3