Re: [PATCH 2/2] PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `reboot-mode` child nodes added under `&psci` lack a `compatible` property, preventing driver probing, and they violate the existing PSCI devicetree schema.
- [High] The two-cell reboot mode values provided in the device tree will be silently truncated to a single 32-bit integer by the reboot-mode core framework.
--

commit e9bed285e77f6bca37ffc7e1d8b65ad73aaf1000
Author: Xin Liu <xin.liu@oss.qualcomm.com>

PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support

This commit adds PSCI SYSTEM_RESET2 reboot-modes for kaanapali-mtp and
kaanapali-qrd for use by the psci-reboot-mode driver. It defines bootloader
and edl modes.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> index 07247dc98b701..0fac663f8773f 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts

[ ... ]

> @@ -1321,3 +1321,10 @@ &ufs_mem_phy {
>  
>  	status = "okay";
>  };
> +
> +&psci {
> +	reboot-mode {

[Severity: High]
Does the lack of a compatible property prevent the reboot-mode driver from
probing? Because the parent PSCI core driver does not instantiate child
platform devices via of_platform_populate(), it appears the core framework
will not instantiate a platform device here.

Additionally, will this cause a dtbs_check validation failure since the
official PSCI bindings in Documentation/devicetree/bindings/arm/psci.yaml
define additionalProperties: false and do not allow a reboot-mode child
node?

> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;

[Severity: High]
Will these two-cell values be silently truncated by the reboot-mode core
framework?

The standard reboot-mode subsystem in drivers/power/reset/reboot-mode.c
reads magic values using of_property_read_u32(), which extracts only the
first 32-bit cell.

Furthermore, include/linux/reboot-mode.h defines the API callback as:
int (*write)(struct reboot_mode_driver *, unsigned int magic);

This strictly enforces a single 32-bit integer argument, meaning the
secondary cell will be dropped.

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com?part=2