Re: [PATCH 1/2] PENDING: arm64: dts: qcom: sm8750: add reboot-mode support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] The `reboot-mode` child node lacks a `compatible` string, which will prevent standard Open Firmware (OF) driver binding and probing.
- [Medium] SoC-specific `reboot-mode` properties are unnecessarily duplicated across multiple board files instead of being defined in the common SoC `.dtsi` file.
- [Medium] The addition of the `reboot-mode` child node directly violates the existing `arm,psci` device tree binding schema, causing `make dtbs_check` to fail.
--

commit 617db56b43f1f719cf41b6a802c5ad389fa5c24f
Author: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
PENDING: arm64: dts: qcom: sm8750: add reboot-mode support

This commit adds psci system reset2 reboot-modes for the sm8750-mtp and
sm8750-qrd boards. It defines bootloader and edl modes to be used by the
psci-reboot-mode driver.

> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
[ ... ]
> +&psci {
> +	reboot-mode {

[Severity: Medium]
Does adding this node cause a dtbs_check failure? The core psci device tree
binding schema in Documentation/devicetree/bindings/arm/psci.yaml sets
additionalProperties: false and does not currently permit a reboot-mode
sub-node.

[Severity: High]
Is a compatible string required here for the reboot-mode driver to probe?
Without a property like compatible = "arm,psci-reboot-mode", the device tree
subsystem might skip node instantiation during of_platform_populate(),
preventing the psci-reboot-mode driver from functioning.

> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;
> +	};
> +};

> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
[ ... ]
> +&psci {
> +	reboot-mode {
> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;
> +	};
> +};

[Severity: Medium]
Could these values be consolidated into the common sm8750.dtsi file? Since
the system reset2 edl and bootloader modes are defined by the SoC firmware,
they appear to be tied to the sm8750 architecture rather than individual
board designs.

Moving them to the common dtsi would reduce duplication across the board
files.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com?part=1