* [PATCH 1/2] PENDING: arm64: dts: qcom: sm8750: add reboot-mode support
2026-05-29 14:11 [PATCH 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards Anurag Pateriya
@ 2026-05-29 14:11 ` Anurag Pateriya
2026-05-29 14:39 ` sashiko-bot
2026-05-29 14:11 ` [PATCH 2/2] PENDING: arm64: dts: qcom: kaanapali: " Anurag Pateriya
2026-05-29 14:58 ` [PATCH 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards Anurag Pateriya
2 siblings, 1 reply; 6+ messages in thread
From: Anurag Pateriya @ 2026-05-29 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Shivendra Pratap, Lorenzo Pieralisi, linux-arm-msm, devicetree,
linux-kernel, Anurag Pateriya
Add PSCI SYSTEM_RESET2 reboot-modes for sm8750-mtp and sm8750-qrd for
use by the psci-reboot-mode driver.
The following modes are defined:
- bootloader: reboot into fastboot mode for fastboot flashing.
- edl: reboot into emergency download mode for image loading via
the Firehose protocol.
Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 7 +++++++
arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 7 +++++++
arch/arm64/boot/dts/qcom/sm8750.dtsi | 2 +-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index de19b4dc214e..e5e2efa2218c 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1425,3 +1425,10 @@ &usb_hsphy {
status = "okay";
};
+
+&psci {
+ reboot-mode {
+ mode-bootloader = <0x80010001 0x2>;
+ mode-edl = <0x80000000 0x1>;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 801c46d55602..795d0d34e47e 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1154,3 +1154,10 @@ &usb_hsphy {
status = "okay";
};
+
+&psci {
+ reboot-mode {
+ mode-bootloader = <0x80010001 0x2>;
+ mode-edl = <0x80000000 0x1>;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 5d6374a23e3e..58ff34e91893 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -261,7 +261,7 @@ pmu {
interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
};
- psci {
+ psci: psci {
compatible = "arm,psci-1.0";
method = "smc";
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] PENDING: arm64: dts: qcom: sm8750: add reboot-mode support
2026-05-29 14:11 ` [PATCH 1/2] PENDING: arm64: dts: qcom: sm8750: add reboot-mode support Anurag Pateriya
@ 2026-05-29 14:39 ` sashiko-bot
0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-05-29 14:39 UTC (permalink / raw)
To: Anurag Pateriya; +Cc: conor+dt, devicetree, robh
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] The `reboot-mode` child node lacks a `compatible` string, which will prevent standard Open Firmware (OF) driver binding and probing.
- [Medium] SoC-specific `reboot-mode` properties are unnecessarily duplicated across multiple board files instead of being defined in the common SoC `.dtsi` file.
- [Medium] The addition of the `reboot-mode` child node directly violates the existing `arm,psci` device tree binding schema, causing `make dtbs_check` to fail.
--
commit 617db56b43f1f719cf41b6a802c5ad389fa5c24f
Author: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
PENDING: arm64: dts: qcom: sm8750: add reboot-mode support
This commit adds psci system reset2 reboot-modes for the sm8750-mtp and
sm8750-qrd boards. It defines bootloader and edl modes to be used by the
psci-reboot-mode driver.
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
[ ... ]
> +&psci {
> + reboot-mode {
[Severity: Medium]
Does adding this node cause a dtbs_check failure? The core psci device tree
binding schema in Documentation/devicetree/bindings/arm/psci.yaml sets
additionalProperties: false and does not currently permit a reboot-mode
sub-node.
[Severity: High]
Is a compatible string required here for the reboot-mode driver to probe?
Without a property like compatible = "arm,psci-reboot-mode", the device tree
subsystem might skip node instantiation during of_platform_populate(),
preventing the psci-reboot-mode driver from functioning.
> + mode-bootloader = <0x80010001 0x2>;
> + mode-edl = <0x80000000 0x1>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
[ ... ]
> +&psci {
> + reboot-mode {
> + mode-bootloader = <0x80010001 0x2>;
> + mode-edl = <0x80000000 0x1>;
> + };
> +};
[Severity: Medium]
Could these values be consolidated into the common sm8750.dtsi file? Since
the system reset2 edl and bootloader modes are defined by the SoC firmware,
they appear to be tied to the sm8750 architecture rather than individual
board designs.
Moving them to the common dtsi would reduce duplication across the board
files.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support
2026-05-29 14:11 [PATCH 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards Anurag Pateriya
2026-05-29 14:11 ` [PATCH 1/2] PENDING: arm64: dts: qcom: sm8750: add reboot-mode support Anurag Pateriya
@ 2026-05-29 14:11 ` Anurag Pateriya
2026-05-29 15:09 ` sashiko-bot
2026-05-29 14:58 ` [PATCH 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards Anurag Pateriya
2 siblings, 1 reply; 6+ messages in thread
From: Anurag Pateriya @ 2026-05-29 14:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Shivendra Pratap, Lorenzo Pieralisi, linux-arm-msm, devicetree,
linux-kernel, Anurag Pateriya, Xin Liu
From: Xin Liu <xin.liu@oss.qualcomm.com>
Add PSCI SYSTEM_RESET2 reboot-modes for kaanapali-mtp and kaanapali-qrd
for use by the psci-reboot-mode driver.
The following modes are defined:
- bootloader: reboot into fastboot mode for fastboot flashing.
- edl: reboot into emergency download mode for image loading via
the Firehose protocol.
Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++
arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++
arch/arm64/boot/dts/qcom/kaanapali.dtsi | 2 +-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
index 7bce5653ea74..6429d91eba62 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
@@ -1356,3 +1356,10 @@ &usb_dp_qmpphy {
status = "okay";
};
+
+&psci {
+ reboot-mode {
+ mode-bootloader = <0x80010001 0x2>;
+ mode-edl = <0x80000000 0x1>;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
index 95dce0812725..85007e53c456 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
@@ -851,3 +851,10 @@ &usb_dp_qmpphy {
status = "okay";
};
+
+&psci {
+ reboot-mode {
+ mode-bootloader = <0x80010001 0x2>;
+ mode-edl = <0x80000000 0x1>;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
index 63c828c80920..d8203b2dbc8c 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
+++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
@@ -274,7 +274,7 @@ pmu {
interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
};
- psci {
+ psci: psci {
compatible = "arm,psci-1.0";
method = "smc";
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support
2026-05-29 14:11 ` [PATCH 2/2] PENDING: arm64: dts: qcom: kaanapali: " Anurag Pateriya
@ 2026-05-29 15:09 ` sashiko-bot
0 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-05-29 15:09 UTC (permalink / raw)
To: Anurag Pateriya; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `reboot-mode` child nodes added under `&psci` lack a `compatible` property, preventing driver probing, and they violate the existing PSCI devicetree schema.
- [High] The two-cell reboot mode values provided in the device tree will be silently truncated to a single 32-bit integer by the reboot-mode core framework.
--
commit e9bed285e77f6bca37ffc7e1d8b65ad73aaf1000
Author: Xin Liu <xin.liu@oss.qualcomm.com>
PENDING: arm64: dts: qcom: kaanapali: add reboot-mode support
This commit adds PSCI SYSTEM_RESET2 reboot-modes for kaanapali-mtp and
kaanapali-qrd for use by the psci-reboot-mode driver. It defines bootloader
and edl modes.
> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> index 07247dc98b701..0fac663f8773f 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
[ ... ]
> @@ -1321,3 +1321,10 @@ &ufs_mem_phy {
>
> status = "okay";
> };
> +
> +&psci {
> + reboot-mode {
[Severity: High]
Does the lack of a compatible property prevent the reboot-mode driver from
probing? Because the parent PSCI core driver does not instantiate child
platform devices via of_platform_populate(), it appears the core framework
will not instantiate a platform device here.
Additionally, will this cause a dtbs_check validation failure since the
official PSCI bindings in Documentation/devicetree/bindings/arm/psci.yaml
define additionalProperties: false and do not allow a reboot-mode child
node?
> + mode-bootloader = <0x80010001 0x2>;
> + mode-edl = <0x80000000 0x1>;
[Severity: High]
Will these two-cell values be silently truncated by the reboot-mode core
framework?
The standard reboot-mode subsystem in drivers/power/reset/reboot-mode.c
reads magic values using of_property_read_u32(), which extracts only the
first 32-bit cell.
Furthermore, include/linux/reboot-mode.h defines the API callback as:
int (*write)(struct reboot_mode_driver *, unsigned int magic);
This strictly enforces a single 32-bit integer argument, meaning the
secondary cell will be dropped.
> + };
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards
2026-05-29 14:11 [PATCH 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards Anurag Pateriya
2026-05-29 14:11 ` [PATCH 1/2] PENDING: arm64: dts: qcom: sm8750: add reboot-mode support Anurag Pateriya
2026-05-29 14:11 ` [PATCH 2/2] PENDING: arm64: dts: qcom: kaanapali: " Anurag Pateriya
@ 2026-05-29 14:58 ` Anurag Pateriya
2 siblings, 0 replies; 6+ messages in thread
From: Anurag Pateriya @ 2026-05-29 14:58 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Shivendra Pratap, Lorenzo Pieralisi, linux-arm-msm, devicetree,
linux-kernel, Xin Liu
On 5/29/2026 7:41 PM, Anurag Pateriya wrote:
> Adding PSCI SYSTEM_RESET2 reboot-modes for sm8750 and
> kaanapali based boards.
Please ignore this patch. I have sent v2 fixing the commit
subject line.
Thanks,
Anurag Pateriya
^ permalink raw reply [flat|nested] 6+ messages in thread