[PATCH v2 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards

[PATCH v2 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards

[Anurag Pateriya]

Adding PSCI SYSTEM_RESET2 reboot-modes for sm8750 and 
kaanapali based boards.

These DT patches depend on PSCI SYSTEM_RESET2 support introduced in: 
https://lore.kernel.org/all/20260514-arm-psci-system_reset2-vendor-reboots-v22-0-28a5bde07483@oss.qualcomm.com/

To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
Cc: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
---
Changes in v2:
- Fixed subject lines.
- Link to v1: https://lore.kernel.org/r/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com

---
Anurag Pateriya (1):
      arm64: dts: qcom: sm8750: add reboot-mode support

Xin Liu (1):
      arm64: dts: qcom: kaanapali: add reboot-mode support

 arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/kaanapali.dtsi    | 2 +-
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts    | 7 +++++++
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts    | 7 +++++++
 arch/arm64/boot/dts/qcom/sm8750.dtsi       | 2 +-
 6 files changed, 30 insertions(+), 2 deletions(-)
---
base-commit: 6ee02bbf328be8a8586487e3af73b65a906cce58
change-id: 20260529-psci_sys_reset-dt-changes-for-pakala-a09fc0e2a8a8

Best regards,
-- 
Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>

[PATCH v2 1/2] arm64: dts: qcom: sm8750: add reboot-mode support

[Anurag Pateriya]

Add PSCI SYSTEM_RESET2 reboot-modes for sm8750-mtp and sm8750-qrd for
use by the psci-reboot-mode driver.

The following modes are defined:
- bootloader: reboot into fastboot mode for fastboot flashing.
- edl: reboot into emergency download mode for image loading via
  the Firehose protocol.

Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/sm8750.dtsi    | 2 +-
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index de19b4dc214e..e5e2efa2218c 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1425,3 +1425,10 @@ &usb_hsphy {
 
 	status = "okay";
 };
+
+&psci {
+	reboot-mode {
+		mode-bootloader = <0x80010001 0x2>;
+		mode-edl = <0x80000000 0x1>;
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 801c46d55602..795d0d34e47e 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1154,3 +1154,10 @@ &usb_hsphy {
 
 	status = "okay";
 };
+
+&psci {
+	reboot-mode {
+		mode-bootloader = <0x80010001 0x2>;
+		mode-edl = <0x80000000 0x1>;
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 5d6374a23e3e..58ff34e91893 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -261,7 +261,7 @@ pmu {
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
 	};
 
-	psci {
+	psci: psci {
 		compatible = "arm,psci-1.0";
 		method = "smc";
 

-- 
2.43.0

Re: [PATCH v2 1/2] arm64: dts: qcom: sm8750: add reboot-mode support

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [Medium] The reboot mode properties define multiple 32-bit values which will be truncated if using the generic reboot-mode framework.
- [Low] Adding a `reboot-mode` child node to the `psci` node violates the PSCI device tree binding schema.
- [Low] The newly added `reboot-mode` node lacks a `compatible` property, preventing platform drivers from probing it.
- [Low] The commit adds device tree nodes for a `psci-reboot-mode` driver that does not exist in the kernel tree.
--

commit 29b2e890de1b3d908134e3a9d75f1f250b9a8f44
Author: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>

arm64: dts: qcom: sm8750: add reboot-mode support

This commit adds PSCI SYSTEM_RESET2 reboot-modes for sm8750-mtp and
sm8750-qrd. It defines bootloader and edl modes for use by the
psci-reboot-mode driver.

> Add PSCI SYSTEM_RESET2 reboot-modes for sm8750-mtp and sm8750-qrd for
> use by the psci-reboot-mode driver.

[Severity: Low]
Is the psci-reboot-mode driver available in the kernel tree? It does not
appear to exist in the current tree or in this patch series, which leaves
these device tree nodes as unused code.

> diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> index 3837f6785320d..af4b548d39e91 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
[ ... ]
> @@ -1426,3 +1426,10 @@ &usb_hsphy {
>  
>  	status = "okay";
>  };
> +
> +&psci {
> +	reboot-mode {

[Severity: Low]
Does this new child node violate the PSCI device tree binding schema? The
Documentation/devicetree/bindings/arm/psci.yaml schema specifies
additionalProperties: false at the top level and does not define a
reboot-mode child node, which might cause schema validation to fail with an
additional properties error.

[Severity: Low]
How will the system bind a driver to this node without a compatible
property? Without it, the platform bus will not instantiate a device for
the child node, preventing drivers from probing it natively.

> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;

[Severity: Medium]
Are the second 32-bit cells in these properties going to be ignored? If the
driver hooks into the generic reboot-mode framework in
drivers/power/reset/reboot-mode.c, the framework reads properties prefixed
with mode- using of_property_read_u32().

This function reads strictly the first 32-bit value into the magic field,
so the second parameter might be silently truncated and lost.

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v2-0-1964ebf1924c@oss.qualcomm.com?part=1

[PATCH v2 2/2] arm64: dts: qcom: kaanapali: add reboot-mode support

[Anurag Pateriya]

From: Xin Liu <xin.liu@oss.qualcomm.com>

Add PSCI SYSTEM_RESET2 reboot-modes for kaanapali-mtp and kaanapali-qrd
for use by the psci-reboot-mode driver.

The following modes are defined:
- bootloader: reboot into fastboot mode for fastboot flashing.
- edl: reboot into emergency download mode for image loading via
  the Firehose protocol.

Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++
 arch/arm64/boot/dts/qcom/kaanapali.dtsi    | 2 +-
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
index 7bce5653ea74..6429d91eba62 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
@@ -1356,3 +1356,10 @@ &usb_dp_qmpphy {
 
 	status = "okay";
 };
+
+&psci {
+	reboot-mode {
+		mode-bootloader = <0x80010001 0x2>;
+		mode-edl = <0x80000000 0x1>;
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
index 95dce0812725..85007e53c456 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
@@ -851,3 +851,10 @@ &usb_dp_qmpphy {
 
 	status = "okay";
 };
+
+&psci {
+	reboot-mode {
+		mode-bootloader = <0x80010001 0x2>;
+		mode-edl = <0x80000000 0x1>;
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
index 63c828c80920..d8203b2dbc8c 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
+++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
@@ -274,7 +274,7 @@ pmu {
 		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
 	};
 
-	psci {
+	psci: psci {
 		compatible = "arm,psci-1.0";
 		method = "smc";
 

-- 
2.43.0

Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: add reboot-mode support

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added `reboot-mode` child nodes under `&psci` lack a `compatible` property, preventing the intended driver from probing.
- [Low] Adding a `reboot-mode` child node to the `psci` node causes a DT schema validation failure.
--

commit 079cf5018c165ba61e6369f973cc92a5ec2da280
Author: Xin Liu <xin.liu@oss.qualcomm.com>

arm64: dts: qcom: kaanapali: add reboot-mode support

This commit adds PSCI SYSTEM_RESET2 reboot-modes for the kaanapali-mtp
and kaanapali-qrd boards. It defines the bootloader and edl modes for
use by the psci-reboot-mode driver.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
[ ... ]
> @@ -1321,3 +1321,10 @@ &ufs_mem_phy {
>  
>  	status = "okay";
>  };
> +
> +&psci {
> +	reboot-mode {

[Severity: Low]
Will this new child node cause a device tree schema validation failure?

The core PSCI schema (Documentation/devicetree/bindings/arm/psci.yaml)
enforces additionalProperties: false at the top level and does not currently
document or allow a reboot-mode child node.

The binding schema may need to be updated to explicitly allow the
reboot-mode node to avoid errors during dtbs_check.

[Severity: Medium]
Does this node need a compatible string to successfully probe the driver?

Standard device tree matching via of_platform_populate() requires a
compatible property to bind a device node to a platform driver.

Without a compatible property (such as compatible = "qcom,psci-reboot-mode";),
the driver core will likely ignore these nodes, leaving the bootloader and edl
reboot functionality inoperative.

> +		mode-bootloader = <0x80010001 0x2>;
> +		mode-edl = <0x80000000 0x1>;
> +	};
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529-psci_sys_reset-dt-changes-for-pakala-v2-0-1964ebf1924c@oss.qualcomm.com?part=2

Re: [PATCH v2 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards

[Loic Poulain]

Hi Anurag,

On Fri, May 29, 2026 at 4:29 PM Anurag Pateriya
<anurag.pateriya@oss.qualcomm.com> wrote:
>
> Adding PSCI SYSTEM_RESET2 reboot-modes for sm8750 and
> kaanapali based boards.

I would like to highlight that when Linux/EFI is enabled, which is a
common config, efi_reboot is used as the primary reboot path (see
machine_restart). As a result, the PSCI reboot hook is not invoked in
this scenario, assuming Qualcomm firmware provides EFI runtime
services. As a follow-up, it would therefore be beneficial to also
improve the EFI path to support such custom mode(s)...

Regards,
Loic



>
> These DT patches depend on PSCI SYSTEM_RESET2 support introduced in:
> https://lore.kernel.org/all/20260514-arm-psci-system_reset2-vendor-reboots-v22-0-28a5bde07483@oss.qualcomm.com/
>
> To: Bjorn Andersson <andersson@kernel.org>
> To: Konrad Dybcio <konradybcio@kernel.org>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> Cc: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
> ---
> Changes in v2:
> - Fixed subject lines.
> - Link to v1: https://lore.kernel.org/r/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com
>
> ---
> Anurag Pateriya (1):
>       arm64: dts: qcom: sm8750: add reboot-mode support
>
> Xin Liu (1):
>       arm64: dts: qcom: kaanapali: add reboot-mode support
>
>  arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++
>  arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++
>  arch/arm64/boot/dts/qcom/kaanapali.dtsi    | 2 +-
>  arch/arm64/boot/dts/qcom/sm8750-mtp.dts    | 7 +++++++
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts    | 7 +++++++
>  arch/arm64/boot/dts/qcom/sm8750.dtsi       | 2 +-
>  6 files changed, 30 insertions(+), 2 deletions(-)
> ---
> base-commit: 6ee02bbf328be8a8586487e3af73b65a906cce58
> change-id: 20260529-psci_sys_reset-dt-changes-for-pakala-a09fc0e2a8a8
>
> Best regards,
> --
> Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
>
>

Re: [PATCH v2 0/2] Add psci_sys_reset2 reboot modes for Qualcomm boards

[Lorenzo Pieralisi]

On Wed, Jun 10, 2026 at 02:57:19PM +0200, Loic Poulain wrote:
> Hi Anurag,
> 
> On Fri, May 29, 2026 at 4:29 PM Anurag Pateriya
> <anurag.pateriya@oss.qualcomm.com> wrote:
> >
> > Adding PSCI SYSTEM_RESET2 reboot-modes for sm8750 and
> > kaanapali based boards.
> 
> I would like to highlight that when Linux/EFI is enabled, which is a
> common config, efi_reboot is used as the primary reboot path (see
> machine_restart). As a result, the PSCI reboot hook is not invoked in
> this scenario, assuming Qualcomm firmware provides EFI runtime
> services. As a follow-up, it would therefore be beneficial to also
> improve the EFI path to support such custom mode(s)...

I have not checked but we should probably put in a place a way for user
space to check that PSCI is _not_ the reboot method that will be
used, lest it would be allowed to send commands to the kernel that
would be duly ignored.

Need to go through the whole thing again before commenting any further.

Thanks,
Lorenzo

> Regards,
> Loic
> 
> 
> 
> >
> > These DT patches depend on PSCI SYSTEM_RESET2 support introduced in:
> > https://lore.kernel.org/all/20260514-arm-psci-system_reset2-vendor-reboots-v22-0-28a5bde07483@oss.qualcomm.com/
> >
> > To: Bjorn Andersson <andersson@kernel.org>
> > To: Konrad Dybcio <konradybcio@kernel.org>
> > To: Rob Herring <robh@kernel.org>
> > To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > To: Conor Dooley <conor+dt@kernel.org>
> > Cc: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> >
> > Signed-off-by: Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
> > ---
> > Changes in v2:
> > - Fixed subject lines.
> > - Link to v1: https://lore.kernel.org/r/20260529-psci_sys_reset-dt-changes-for-pakala-v1-0-7c32161cf50b@oss.qualcomm.com
> >
> > ---
> > Anurag Pateriya (1):
> >       arm64: dts: qcom: sm8750: add reboot-mode support
> >
> > Xin Liu (1):
> >       arm64: dts: qcom: kaanapali: add reboot-mode support
> >
> >  arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++
> >  arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++
> >  arch/arm64/boot/dts/qcom/kaanapali.dtsi    | 2 +-
> >  arch/arm64/boot/dts/qcom/sm8750-mtp.dts    | 7 +++++++
> >  arch/arm64/boot/dts/qcom/sm8750-qrd.dts    | 7 +++++++
> >  arch/arm64/boot/dts/qcom/sm8750.dtsi       | 2 +-
> >  6 files changed, 30 insertions(+), 2 deletions(-)
> > ---
> > base-commit: 6ee02bbf328be8a8586487e3af73b65a906cce58
> > change-id: 20260529-psci_sys_reset-dt-changes-for-pakala-a09fc0e2a8a8
> >
> > Best regards,
> > --
> > Anurag Pateriya <anurag.pateriya@oss.qualcomm.com>
> >
> >