Re: [net-next v4 2/5] dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect fallback compatibility for `starfive,jhb100-dwmac` and nested schema logic
--

commit 6b46c7eda188eefbc105849442bf373d3049d603
Author: Minda Chen <minda.chen@starfivetech.com>

dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 support

This commit adds device tree bindings for the jhb100 GMAC. It notes
that the hardware is similar to jh7100 but only has one reset signal
and one interrupt line.

> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> @@ -30,6 +30,10 @@ properties:
>        - items:
>            - const: starfive,jh7110-dwmac
>            - const: snps,dwmac-5.20
> +      - items:
> +          - const: starfive,jhb100-dwmac
> +          - const: starfive,jh7110-dwmac
> +          - const: snps,dwmac-5.20

Is it correct to use starfive,jh7110-dwmac as a fallback compatible string 
here? 

A fallback compatible implies that an older OS driver written for the jh7110
can successfully drive the jhb100 hardware. Since the jh7110 expects 3
interrupts and 2 resets, won't an older driver fail to probe the jhb100
because of missing required resources?

[ ... ]

> @@ -107,20 +111,39 @@ allOf:
>            contains:
>              const: starfive,jh7110-dwmac
>      then:
> -      properties:
> -        interrupts:
> -          minItems: 3
> -          maxItems: 3
> -
> -        interrupt-names:
> -          minItems: 3
> -          maxItems: 3
> -
> -        resets:
> -          minItems: 2
> -
> -        reset-names:
> -          minItems: 2
> +      if:
> +        properties:
> +          compatible:
> +            contains:
> +              const: starfive,jhb100-dwmac
> +      then:
> +        properties:
> +          interrupts:
> +            maxItems: 1

Because of the fallback compatible, the schema patch nests the jhb100
constraints inside the jh7110 'if' block in allOf.

If starfive,jh7110-dwmac is removed from the jhb100 compatible list, could
these constraints be defined in an independent 'if' block instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519101436.111476-1-minda.chen@starfivetech.com?part=2