Re: [net-next v4 3/5] dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 sgmii rx clk

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Relaxed dt-binding schema for older generations allows invalid configurations to pass validation.
--

commit f6b7d4c26e8b69a59239f5f0ceb9244961ac4979
Author: Minda Chen <minda.chen@starfivetech.com>

dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 sgmii rx clk

This commit adds a 6th clock, the SGMII RX clock, to the starfive,jh7110-dwmac
binding for the jhb100 SGMII interface. It updates the global clocks and
clock-names properties to allow up to 6 items.

> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> index 06aeaa0f6f009..fdcc61c65f87d 100644
> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
[ ... ]
> @@ -39,20 +39,24 @@ properties:
>      maxItems: 1
>  
>    clocks:
> +    minItems: 5
>      items:
>        - description: GMAC main clock
>        - description: GMAC AHB clock
>        - description: PTP clock
>        - description: TX clock
>        - description: GTX clock
> +      - description: SGMII RX clock
>  
>    clock-names:
> +    minItems: 5
>      items:
>        - const: stmmaceth
>        - const: pclk
>        - const: ptp_ref
>        - const: tx
>        - const: gtx
> +      - const: sgmii_rx

Should the schema restrict older generations to a maximum of 5 clocks using
an allOf block?

Since the global list now contains 6 items, the schema implicitly allows up to
6 clocks for all compatible strings. If prior hardware generations or standard
RMII/RGMII variants only support 5 clocks, they could silently pass validation
even if an invalid 6th clock is mistakenly specified in their device tree node.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519101436.111476-1-minda.chen@starfivetech.com?part=3