Re: [PATCH 3/4] arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add QCC2072 Bluetooth M.2 overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `sw_ctrl` pinctrl node is defined but never utilized, and the required GPIO binding is missing from the bluetooth node.
- [High] UART7 is unconditionally disabled in the base industrial mezzanine overlay instead of the M.2-specific overlay, breaking onboard Bluetooth for non-M.2 users.
--

commit 9cd1abaeac0567d92c13345a6a51b9b649ec7b1e
Author: Yepuri Siddu <yepuri.siddu@oss.qualcomm.com>

arm64: dts: qcom: qcs6490-rb3gen2-industrial-mezzanine: Add QCC2072 Bluetooth M.2 overlay

This commit adds a DTSO overlay for the QCS6490 RB3 Gen2 industrial
mezzanine board when the M.2 E-key slot is populated with a QCC2072
Bluetooth module. It configures UART4, sets sleep pin states, maps
host wakeup and power sequencing, and disables UART7 in the base overlay.

> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso
> new file mode 100644
> index 0000000000000..905a40f4b938f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso

[ ... ]

> +	sw_ctrl: sw-ctrl-state {
> +		pins = "gpio86";
> +		function = "gpio";
> +		bias-pull-down;
> +	};
> +};

[ ... ]

> +	bluetooth: bluetooth {
> +		compatible = "qcom,qcc2072-bt";
> +		max-speed = <3200000>;
> +	};
> +};

[Severity: High]
The commit message mentions "SW_CTRL is mapped to gpio86 for power
sequencing." Are we missing a reference to the sw_ctrl pinctrl node here?

It looks like the bluetooth node is missing a GPIO assignment (such as
enable-gpios or swctrl-gpios) and the corresponding pinctrl properties to
utilize the sw_ctrl state. Without these, will the Bluetooth driver be
able to request gpio86 and perform the intended power sequencing?

> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
> index 83908db335afa..c96c7f52ea7a0 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso

[ ... ]

> @@ -288,3 +288,7 @@ pcie1_tc9563_resx_n: pcie1-tc9563-resx-state {
>  &wifi {
>         status = "disabled";
>  };
> +
> +&uart7 {
> +	status = "disabled";
> +};

[Severity: High]
Does unconditionally disabling uart7 in the base industrial mezzanine
overlay break the onboard Bluetooth for non-M.2 users?

The commit message states this is done "as it is not used when the M.2 slot
is populated". Should this &uart7 override be placed in the M.2-specific
qcs6490-rb3gen2-industrial-mezzanine-m2-cologne.dtso overlay instead, so
it only applies when the M.2 slot is actually populated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529180234.3373056-1-yepuri.siddu@oss.qualcomm.com?part=3