[PATCH net-next v3 13/14] dt-bindings: net: add onsemi's S2500

[PATCH net-next v3 13/14] dt-bindings: net: add onsemi's S2500

[Selvamani Rajagopal]

Add YAML device tree binding for the onsemi S2500 IEEE 802.3cg
compliant Ethernet transceiver device.

Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
---
 .../devicetree/bindings/net/onnn,s2500.yaml   | 62 +++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/onnn,s2500.yaml

diff --git a/Documentation/devicetree/bindings/net/onnn,s2500.yaml b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
new file mode 100644
index 000000000000..8b20d1f76027
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/onnn,s2500.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: onsemi S2500 10BASE-T1S MACPHY Ethernet Controllers
+
+maintainers:
+  - Piergiorgio Beruto <pier.beruto@onsemi.com>
+  - Selva Rajagopal <Selvamani.Rajagopal@onsemi.com>
+
+description:
+  The S2500 combines a Media Access Controller (MAC) and an
+  Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access
+  Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC,
+  compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer
+  transceiver integrated into the S2500. The communication between
+  the host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x
+  MACPHY Serial Interface (TC6).
+
+allOf:
+  - $ref: /schemas/net/ethernet-controller.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    const: onnn,s2500
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description:
+      Interrupt from MAC-PHY asserted in the event of Receive Chunks
+      Available, Transmit Chunk Credits Available and Extended Status
+      Event.
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      ethernet@0 {
+        compatible = "onnn,s2500";
+        reg = <0>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&eth0_pins>;
+        interrupt-parent = <&gpio>;
+        interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
+      };
+    };
-- 
2.43.0

Re: [PATCH net-next v3 13/14] dt-bindings: net: add onsemi's S2500

[Krzysztof Kozlowski]

On Fri, May 29, 2026 at 06:41:35PM +0000, Selvamani Rajagopal wrote:
> Add YAML device tree binding for the onsemi S2500 IEEE 802.3cg
> compliant Ethernet transceiver device.
> 
> Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> ---
>  .../devicetree/bindings/net/onnn,s2500.yaml   | 62 +++++++++++++++++++
>  1 file changed, 62 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/onnn,s2500.yaml

Where is the rest of patches? Where is any changelog or cover letter? I
downloaded entire thread and there is nothing.

Best regards,
Krzysztof

Re: [PATCH net-next v3 13/14] dt-bindings: net: add onsemi's S2500

[Andrew Lunn]

On Sat, May 30, 2026 at 11:00:02AM +0200, Krzysztof Kozlowski wrote:
> On Fri, May 29, 2026 at 06:41:35PM +0000, Selvamani Rajagopal wrote:
> > Add YAML device tree binding for the onsemi S2500 IEEE 802.3cg
> > compliant Ethernet transceiver device.
> > 
> > Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> > ---
> >  .../devicetree/bindings/net/onnn,s2500.yaml   | 62 +++++++++++++++++++
> >  1 file changed, 62 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/net/onnn,s2500.yaml
> 
> Where is the rest of patches? Where is any changelog or cover letter? I
> downloaded entire thread and there is nothing.

Hi Krzysztof

The threading is broken. And there is no cover letter. There will be
another version, so you can wait and review that.

    Andrew

RE: [PATCH net-next v3 13/14] dt-bindings: net: add onsemi's S2500

[Selvamani Rajagopal]

> > >
> > > Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> > > ---
> > > .../devicetree/bindings/net/onnn,s2500.yaml | 62 +++++++++++++++++++
> > > 1 file changed, 62 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/net/onnn,s2500.yaml
> >
> > Where is the rest of patches? Where is any changelog or cover letter? I
> > downloaded entire thread and there is nothing.
> 
> Hi Krzysztof
> 
> The threading is broken. And there is no cover letter. There will be
> another version, so you can wait and review that.

To answer few questions in this subject, It is due to the fact that I don't have access to SMTP mail server. With little search, I found that I can use b4 utility, . Will re-submit with b4.

Will add a cover letter as well.

> 
> Andrew

Re: [PATCH net-next v3 13/14] dt-bindings: net: add onsemi's S2500

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `spi-max-frequency` in the device tree binding properties, required list, and example for an SPI peripheral.
--

commit ad5dbf88af08e186c5df6e55d01443c7fc4840ab
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

dt-bindings: net: add onsemi's S2500

Add YAML device tree binding for the onsemi S2500 IEEE 802.3cg
compliant Ethernet transceiver device.

> diff --git a/Documentation/devicetree/bindings/net/onnn,s2500.yaml b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/onnn,s2500.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: onnn,s2500
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description:
> +      Interrupt from MAC-PHY asserted in the event of Receive Chunks
> +      Available, Transmit Chunk Credits Available and Extended Status
> +      Event.
> +    maxItems: 1

[Severity: Medium]
Since this is an SPI peripheral, should spi-max-frequency be defined in the
properties section with device-specific maximum frequency constraints?

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

[Severity: Medium]
Would it be appropriate to add spi-max-frequency to this required list?
Omitting it allows incomplete device tree nodes to pass schema validation,
even though the SPI host controller needs it to configure the bus clock
speed.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethernet@0 {
> +        compatible = "onnn,s2500";
> +        reg = <0>;
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&eth0_pins>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 IRQ_TYPE_LEVEL_LOW>;

[Severity: Medium]
Is spi-max-frequency missing from this example? If developers copy this node
configuration, could it fail to configure the SPI host properly at runtime
without the max frequency property?

> +      };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/CY8PR02MB92494D02A1209BC9BC72EAC883162@CY8PR02MB9249.namprd02.prod.outlook.com?part=13