From: sashiko-bot@kernel.org
To: "Marek Vasut" <marek.vasut+renesas@mailbox.org>
Cc: wsa+renesas@sang-engineering.com, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: r8a78000: Enable application CPU cores via PSCI
Date: Mon, 01 Jun 2026 11:45:13 +0000 [thread overview]
Message-ID: <20260601114514.43B581F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260601113919.8327-1-marek.vasut+renesas@mailbox.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `/psci` firmware node prevents PSCI initialization and secondary CPU bring-up.
--
commit 48b96f528db39732a93e926dab244c4a13787175
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
arm64: dts: renesas: r8a78000: Enable application CPU cores via PSCI
This commit adds the PSCI enable-method property to all 32 application CPU
cores in the r8a78000 device tree. This is intended to allow the OS to manage
the secondary CPUs using PSCI firmware.
> diff --git a/arch/arm64/boot/dts/renesas/r8a78000.dtsi b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> index 3e1c98903cea0..1ed98545990f2 100644
> --- a/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a78000.dtsi
> @@ -143,6 +143,7 @@ a720_0: cpu@0 {
> compatible = "arm,cortex-a720ae";
> reg = <0x0 0x0>;
> device_type = "cpu";
> + enable-method = "psci";
[Severity: High]
Does this device tree lack the required /psci firmware node?
Looking at the new enable-method properties, the CPUs are configured to use
PSCI, but there doesn't appear to be a corresponding psci node in the root
of the device tree.
During early boot, psci_dt_init() in drivers/firmware/psci/psci.c searches
for a node compatible with arm,psci or arm,psci-1.0. If the node is entirely
absent, psci_dt_init() returns -ENODEV and PSCI operations are not registered.
Will this omission cause SMP initialization to fail, leaving the system
forced to run only on the primary boot CPU?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260601113919.8327-1-marek.vasut+renesas@mailbox.org?part=1
prev parent reply other threads:[~2026-06-01 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 11:38 [PATCH] arm64: dts: renesas: r8a78000: Enable application CPU cores via PSCI Marek Vasut
2026-06-01 11:45 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601114514.43B581F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox