Re: [PATCH v4 2/3] arm64: dts: freescale: add Aquila iMX95 support

[Francesco Dolcini <francesco@dolcini.it>]

On Mon, Jun 01, 2026 at 03:42:15PM -0400, Frank Li wrote:
> On Thu, May 21, 2026 at 05:30:19PM +0000, sashiko-bot@kernel.org wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/imx95-aquila.dtsi b/arch/arm64/boot/dts/freescale/imx95-aquila.dtsi
> > > new file mode 100644
> > > index 0000000000000..69dc962a24a1d
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx95-aquila.dtsi
> > > @@ -0,0 +1,1160 @@
> > [ ... ]
> > > +	reg_dp_1p2v: regulator-dp-1p2v {
> > > +		compatible = "regulator-fixed";
> > > +		/* CTRL_DP_BRIDGE_EN */
> > > +		gpios = <&som_gpio_expander_0 7 GPIO_ACTIVE_HIGH>;
> > > +		enable-active-high;
> > > +		regulator-always-on;
> > > +		regulator-max-microvolt = <1200000>;
> > > +		regulator-min-microvolt = <1200000>;
> > > +		regulator-name = "On-module +V1.2_DP";
> > > +		vin-supply = <&reg_1p8v>;
> > > +	};
> >
> > [Severity: Medium]
> > Since this regulator is a dedicated power supply for som_dsi2dp_bridge which
> > is marked as status = "disabled" below, is it necessary to have the
> > regulator-always-on property here?
> 
> This one make sense. Does this regulator-dp-1p2v really need always on.

Yes, it is wanted to be like that.

Keeping it as always-on is a HW decision from the vendor, Toradex.

If this is disabled at run-time, for example in some stand-by use case,
it does not work properly afterward.

Francesco