Re: [PATCH v4 2/3] arm64: dts: freescale: add Aquila iMX95 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The DisplayPort connector references a disabled DisplayPort bridge, leaving dangling references and rendering the connector non-functional while wasting power.
- [Medium] The dedicated power supply regulator for the disabled DSI-to-DP bridge is incorrectly marked as always-on, wasting power.
--

commit 3392fc6b669bcc9dccbd369d342a80d81c494ed6
Author: João Paulo Gonçalves <joao.goncalves@toradex.com>

arm64: dts: freescale: add Aquila iMX95 support

This commit adds support for the Toradex Aquila iMX95 computer-on-module
and its corresponding development carrier board.

Link: https://www.toradex.com/computer-on-modules/aquila-arm-family/nxp-imx95
Link: https://www.toradex.com/products/carrier-board/aquila-development-board-kit

> diff --git a/arch/arm64/boot/dts/freescale/imx95-aquila-dev.dts b/arch/arm64/boot/dts/freescale/imx95-aquila-dev.dts
> new file mode 100644
> index 0000000000000..3df17700b632f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-aquila-dev.dts
> @@ -0,0 +1,389 @@
[ ... ]
> +	aliases {
> +		eeprom1 = &carrier_eeprom;
> +	};
> +
> +	dp_1_connector: dp0-connector {
> +		compatible = "dp-connector";
> +		dp-pwr-supply = <&reg_dp_3p3v>;
> +		type = "full-size";
> +
> +		port {
> +			dp_1_connector_in: endpoint {
> +				remote-endpoint = <&dsi2dp_out>;
> +			};
> +		};
> +	};

[Severity: Medium]
Since som_dsi2dp_bridge is disabled by default in imx95-aquila.dtsi and not
explicitly enabled in this device tree, does this connector node leave
dangling references?

Without status = "disabled" on this node, the display-connector driver will
probe successfully and unconditionally enable its dp-pwr-supply (reg_dp_3p3v),
wasting power on the carrier board for an unusable interface.

Should this connector be disabled by default or have the bridge enabled here?

> diff --git a/arch/arm64/boot/dts/freescale/imx95-aquila.dtsi b/arch/arm64/boot/dts/freescale/imx95-aquila.dtsi
> new file mode 100644
> index 0000000000000..69dc962a24a1d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-aquila.dtsi
> @@ -0,0 +1,1160 @@
[ ... ]
> +	reg_dp_1p2v: regulator-dp-1p2v {
> +		compatible = "regulator-fixed";
> +		/* CTRL_DP_BRIDGE_EN */
> +		gpios = <&som_gpio_expander_0 7 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		regulator-always-on;
> +		regulator-max-microvolt = <1200000>;
> +		regulator-min-microvolt = <1200000>;
> +		regulator-name = "On-module +V1.2_DP";
> +		vin-supply = <&reg_1p8v>;
> +	};

[Severity: Medium]
Since this regulator is a dedicated power supply for som_dsi2dp_bridge which
is marked as status = "disabled" below, is it necessary to have the
regulator-always-on property here?

The always-on property bypasses the driver and forces the regulator core to
unconditionally assert the CTRL_DP_BRIDGE_EN GPIO at boot, continuously
powering the bridge chip on the module even when disabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-add-aquila-imx95-v4-0-5a7f86c824f5@toradex.com?part=2