Re: [PATCH v2 4/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI with adapter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree overlay introduces an undocumented 'riverdi' vendor prefix and an unlisted compatible string for 'panel-lvds'.
--

commit 99fbcf48f1baef1bcb344b1c59410f3c79e90a6e
Author: Vitor Soares <vitor.soares@toradex.com>

arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 7" DSI with adapter

This commit adds a device tree overlay for the Toradex Capacitive Touch Display
7" DSI used with the Toradex DSI Display Adapter on the Aquila Development
Board. It configures the internal SN65DSI83 DSI-to-LVDS bridge, the Riverdi
TFT LCD panel, and the Ilitek capacitive touch controller.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-7inch-dsi
Link: https://developer.toradex.com/hardware/accessories/add-ons/dsi-display-adapter

> diff --git a/arch/arm64/boot/dts/ti/k3-am69-aquila-adapter-panel-cap-touch-7inch-dsi.dtso b/arch/arm64/boot/dts/ti/k3-am69-aquila-adapter-panel-cap-touch-7inch-dsi.dtso
> new file mode 100644
> index 0000000000000..36d3746c8bd08
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am69-aquila-adapter-panel-cap-touch-7inch-dsi.dtso

[ ... ]

> +&{/} {
> +	backlight_pwm3: backlight-pwm3 {
> +		compatible = "pwm-backlight";
> +		brightness-levels = <0 45 63 88 119 158 203 255>;
> +		default-brightness-level = <4>;
> +		/* Aquila PWM_3_DSI (AQUILA B46) */
> +		pwms = <&main_ehrpwm5 0 6666667 0>;
> +	};
> +
> +	panel-lvds-bridge {
> +		compatible = "riverdi,rvt70hslnwca0", "panel-lvds";

[Severity: Low]
This isn't a bug, but are the vendor prefix "riverdi" and the specific
compatible string "riverdi,rvt70hslnwca0" documented in the devicetree
bindings?

Since Documentation/devicetree/bindings/display/panel/panel-lvds.yaml strictly
enumerates valid specific compatible strings for the panel-lvds fallback, will
this cause "make dtbs_check" validation errors if it hasn't been added to the
bindings?

> +		backlight = <&backlight_pwm3>;
> +		data-mapping = "vesa-24";
> +		height-mm = <86>;
> +		width-mm = <154>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602115123.1324474-9-ivitro@gmail.com?part=4