Re: [PATCH v2 5/7] arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 10.1" DSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces undocumented compatible strings ('riverdi,rvt101hvlnwc00' and 'riverdi,rvt70hslnwca0') and a new vendor prefix ('riverdi'), violating DT schema constraints.
--

commit f3ae8be063492bba7bf6849a36601078aae31f5f
Author: Vitor Soares <vitor.soares@toradex.com>

arm64: dts: ti: k3-am69-aquila: Add Toradex Capacitive Touch Display 10.1" DSI

This patch adds a device tree overlay for the Toradex Capacitive Touch
Display 10.1" DSI on the Aquila DSI_1 interface. The display uses a TI
SN65DSI83 bridge driving a Riverdi RVT101HVLNWC00 10.1" TFT LCD panel.
It also includes an ILI2132 capacitive touch controller.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-101inch-dsi

> diff --git a/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-10inch-dsi.dtso b/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-10inch-dsi.dtso
> new file mode 100644
> index 0000000000000..c5d597873440f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am69-aquila-panel-cap-touch-10inch-dsi.dtso

[ ... ]

> +&{/} {
> +	backlight_pwm3: backlight-pwm3 {
> +		compatible = "pwm-backlight";
> +		brightness-levels = <0 45 63 88 119 158 203 255>;
> +		default-brightness-level = <4>;
> +		/* Aquila PWM_3_DSI (AQUILA B46) */
> +		pwms = <&main_ehrpwm5 0 6666667 0>;
> +	};
> +
> +	panel-lvds-bridge {
> +		compatible = "riverdi,rvt101hvlnwc00", "panel-lvds";
[Severity: Low]
Are the new vendor prefix and compatible strings documented in the device
tree bindings?

The vendor prefix riverdi does not appear to be documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml.

Also, since panel-lvds uses a strict enum for compatible strings, using
riverdi,rvt101hvlnwc00 will cause make dtbs_check to report validation
errors unless it is added to the allowed list.

> +		backlight = <&backlight_pwm3>;
> +		data-mapping = "vesa-24";
> +		height-mm = <136>;
> +		width-mm = <217>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602115123.1324474-9-ivitro@gmail.com?part=5