Devicetree
 help / color / mirror / Atom feed
From: Herman van Hazendonk <github.com@herrie.org>
To: lee@kernel.org, robh@kernel.org
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Herman van Hazendonk <github.com@herrie.org>
Subject: Re: [PATCH 1/1] dt-bindings: mfd: add ti,lm8502 combo LED + haptic controller
Date: Wed,  3 Jun 2026 10:17:45 +0200	[thread overview]
Message-ID: <20260603081746.932652-1-github.com@herrie.org> (raw)
In-Reply-To: <20260603080256.853037-2-github.com@herrie.org>

Thank you for the review feedback.

Acknowledged — the ti,lm8502-leds / ti,lm8502-haptic compatible strings
are a Linux MFD driver artifact rather than a hardware description. The
description text also mentions the OS split, which should be removed.

Before preparing v2 I wanted to ask how you would prefer this structured:

Option A — LP55xx style (no sub-node compatibles):
Individual led@N nodes (reg 0..9 = D1..D10) go directly on the parent,
following leds-lp55xx.yaml. The haptic function is a plain haptic sub-node
(config container for ti,invert-direction) with no compatible. The parent
driver instantiates children via mfd_cells[] keyed on platform device name;
DT parsing is done in the parent driver. This requires companion changes to
the MFD core and child drivers.

Option B — Single flat node:
Fold everything into the parent node. LED channels and haptic described via
properties directly on the I2C device node, no sub-nodes at all. Simpler
binding, but per-LED led-max-microamp config becomes a list property rather
than per-node, which is less readable for a 10-channel device.

My inclination is Option A as it matches the LP55xx precedent, but happy to
follow your preference or any third approach you have in mind.

Signed-off-by: Herman van Hazendonk <github.com@herrie.org>

      parent reply	other threads:[~2026-06-03  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  8:02 [PATCH 0/1] dt-bindings: mfd: add ti,lm8502 LED + haptic controller Herman van Hazendonk
2026-06-03  8:02 ` [PATCH 1/1] dt-bindings: mfd: add ti,lm8502 combo " Herman van Hazendonk
2026-06-03  8:08   ` sashiko-bot
2026-06-03  8:17   ` Herman van Hazendonk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603081746.932652-1-github.com@herrie.org \
    --to=github.com@herrie.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox