Re: [PATCH v5 06/14] media: mediatek: vcodec: define MT8196 vcodec levels.

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces the undeclared identifier `MTK_VDEC_MT8196` before it is defined, causing a compilation error and breaking `git bisect`.
--

commit 918de5bcb94623dd2782fada54c8dcb18dc11b48
Author: Yunfei Dong <yunfei.dong@mediatek.com>

media: mediatek: vcodec: define MT8196 vcodec levels.

The patch updates various vcodec control configuration functions to add
support for the MT8196 chip by setting the maximum profiles and levels for
H264, HEVC, and VP9.

> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> index ab1894fba0d90..472ece5713a56 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c
> @@ -577,6 +577,7 @@ static void mtk_vcodec_dec_fill_h264_level(struct v4l2_ctrl_config *cfg,
>  		cfg->max = V4L2_MPEG_VIDEO_H264_LEVEL_5_2;
>  		break;
>  	case MTK_VDEC_MT8195:
> +	case MTK_VDEC_MT8196:

[Severity: Low]
Does this introduce a build break for git bisect?

The MTK_VDEC_MT8196 identifier appears to be undeclared at this point in the
commit history. While it is fixed later in the series by the commit "media:
mediatek: vcodec: add decoder compatible to support mt8196", using the
identifier before it is defined will cause compilation errors and break git
bisect.

>  		cfg->max = V4L2_MPEG_VIDEO_H264_LEVEL_6_0;
>  		break;
>  	case MTK_VDEC_MT8183:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603084045.17488-1-kyrie.wu@mediatek.com?part=6