Re: [PATCH v5 12/14] media: mediatek: vcodec: add decoder compatible to support mt8196

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Patch series breaks git bisect due to usage of undeclared identifier MTK_VDEC_MT8196 before it is defined.
--

commit ea2155f52be3df7e341354e244a5cf63f836a145
Author: Yunfei Dong <yunfei.dong@mediatek.com>

media: mediatek: vcodec: add decoder compatible to support mt8196

This commit adds the MT8196 compatible string and device data for the
MediaTek vcodec decoder. It also introduces the MTK_VDEC_MT8196 enum value
used to identify the chip.

> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> index 15e437323af5a..53d1708b012b7 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> @@ -29,6 +29,7 @@ enum mtk_vcodec_dec_chip_name {
>  	MTK_VDEC_MT8188 = 8188,
>  	MTK_VDEC_MT8192 = 8192,
>  	MTK_VDEC_MT8195 = 8195,
> +	MTK_VDEC_MT8196 = 8196,

[Severity: Low]
Does this series break git bisect?

Since MTK_VDEC_MT8196 is first defined here, wouldn't compiling earlier
commits in this series (such as "media: mediatek: vcodec: define MT8196
vcodec levels." or "media: mediatek: vcodec: support 36bit iova address")
fail with an undeclared identifier error?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603084045.17488-1-kyrie.wu@mediatek.com?part=12