Re: [PATCH 5/5] iommu/arm-smmu: Add qcom,shikra-mdss to Qualcomm SMMU client tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The entries for `qcom,shikra-mdss` are inserted out of alphabetical order in the device match tables.
--

commit c3b00b57dda4a11308898354c0f31b116dd3d96c
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>

iommu/arm-smmu: Add qcom,shikra-mdss to Qualcomm SMMU client tables
    
Register the Shikra MDSS display subsystem in both the SMMU ACTLR
client table and the SMMU client match table.

> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> index e2c914fccd6fc..3dfee947e2c9f 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
> @@ -45,6 +45,8 @@ static const struct of_device_id qcom_smmu_actlr_client_of_match[] = {
>  			.data = (const void *) (PREFETCH_DEFAULT | CMTLB) },
>  	{ .compatible = "qcom,qcm2290-mdss",
>  			.data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
> +	{ .compatible = "qcom,shikra-mdss",
> +			.data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },

[Severity: Low]
This isn't a bug, but should this entry be placed in alphabetical order?

It looks like it was inserted right after qcm2290-mdss because it mirrors the
hardware prefetch settings. However, it seems these match tables are usually
kept in strict alphabetical order to prevent merge conflicts and duplicates.
Would it be better placed between sc8280xp-mdss and sm6115-mdss?

>  	{ .compatible = "qcom,sa8775p-mdss",
>  			.data = (const void *) (PREFETCH_DEFAULT | CMTLB) },
>  	{ .compatible = "qcom,sc7280-mdss",

[ ... ]

> @@ -410,6 +412,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>  	{ .compatible = "qcom,mdp4" },
>  	{ .compatible = "qcom,mdss" },
>  	{ .compatible = "qcom,qcm2290-mdss" },
> +	{ .compatible = "qcom,shikra-mdss" },

[Severity: Low]
Similarly, should this be placed alphabetically between sdm845-mss-pil and
sm6115-mdss to maintain the list ordering?

>  	{ .compatible = "qcom,sar2130p-mdss" },
>  	{ .compatible = "qcom,sc7180-mdss" },
>  	{ .compatible = "qcom,sc7180-mss-pil" },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com?part=5