From: Conor Dooley <conor@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Paul Walmsley <pjw@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bartosz Golaszewski <brgl@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
Subject: Re: [PATCH v3 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl
Date: Thu, 4 Jun 2026 18:06:35 +0100 [thread overview]
Message-ID: <20260604-sprout-zips-c2c29e26fe1d@spud> (raw)
In-Reply-To: <ZQ4PR01MB12022B5C460A34260ABFCE9FF2102@ZQ4PR01MB1202.CHNPR01.prod.partner.outlook.cn>
[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]
On Thu, Jun 04, 2026 at 01:37:00AM +0000, Changhuang Liang wrote:
> Hi, Conor
>
> Thanks for the review.
>
> > On Tue, Jun 02, 2026 at 10:53:29PM -0700, Changhuang Liang wrote:
> >
> > > + slew-rate:
> > > + enum: [ 0, 1 ]
> > > + default: 0
> > > + description: |
> > > + 0: slow (half frequency)
> >
> > Half frequency? Slew rates are usually measured in volts per second, not hertz.
> > Do you know what the slew rates actually are and could put them in here as
> > the real units? Or is it just "slow" and "fast" in your docs with no precise
> > numbers?
>
> Yes, there are no precise numbers in our documentation. I will remove "(half frequency)" in the next version.
If the rate is actually half, then you can say that. It's just
"frequency" I was objecting to.
>
> > I've got no questions other than this, so once this question is sorted, I'll be
> > happy to ack all the bindings provided they're effectively the same.
> >
> > > + 1: fast
>
> Best Regards,
> Changhuang
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-06-04 17:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 5:53 [PATCH v3 00/21] Add basic pinctrl drivers for JHB100 SoC Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 01/21] dt-bindings: pincfg-node: Add property 'input-debounce-ns' Changhuang Liang
2026-06-03 15:16 ` Conor Dooley
2026-06-03 5:53 ` [PATCH v3 02/21] pinctrl: pinconf-generic: " Changhuang Liang
2026-06-03 15:18 ` Conor Dooley
2026-06-11 8:10 ` Linus Walleij
2026-06-03 5:53 ` [PATCH v3 03/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0-pinctrl Changhuang Liang
2026-06-03 16:43 ` Conor Dooley
2026-06-04 1:37 ` Changhuang Liang
2026-06-04 17:06 ` Conor Dooley [this message]
2026-06-05 5:13 ` Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 04/21] pinctrl: starfive: Add StarFive JHB100 sys0 controller driver Changhuang Liang
2026-06-03 8:41 ` Philipp Zabel
2026-06-03 10:17 ` Changhuang Liang
2026-06-11 11:37 ` Linus Walleij
2026-06-19 8:41 ` Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 05/21] dt-bindings: pinctrl: Add starfive,jhb100-sys0h-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 06/21] pinctrl: starfive: Add StarFive JHB100 sys0h controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 07/21] dt-bindings: pinctrl: Add starfive,jhb100-sys1-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 08/21] pinctrl: starfive: Add StarFive JHB100 sys1 controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 09/21] dt-bindings: pinctrl: Add starfive,jhb100-sys2-pinctrl Changhuang Liang
2026-06-04 17:13 ` Conor Dooley
2026-06-05 5:14 ` Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 10/21] pinctrl: starfive: Add StarFive JHB100 sys2 controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 11/21] dt-bindings: pinctrl: Add starfive,jhb100-per0-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 12/21] pinctrl: starfive: Add StarFive JHB100 per0 controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 13/21] dt-bindings: pinctrl: Add starfive,jhb100-per1-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 14/21] pinctrl: starfive: Add StarFive JHB100 per1 controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 15/21] dt-bindings: pinctrl: Add starfive,jhb100-per2-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 16/21] pinctrl: starfive: Add StarFive JHB100 per2 controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 17/21] dt-bindings: pinctrl: Add starfive,jhb100-per2pok-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 18/21] pinctrl: starfive: Add StarFive JHB100 per2pok controller driver Changhuang Liang
2026-06-08 14:45 ` Bartosz Golaszewski
2026-06-09 9:13 ` Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 19/21] dt-bindings: pinctrl: Add starfive,jhb100-per3-pinctrl Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 20/21] pinctrl: starfive: Add StarFive JHB100 per3 controller driver Changhuang Liang
2026-06-03 5:53 ` [PATCH v3 21/21] riscv: dts: starfive: jhb100: Add pinctrl nodes Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604-sprout-zips-c2c29e26fe1d@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=brgl@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox