Re: [PATCH v13 10/22] dt-bindings: media: i2c: max96712: add control-channel-port property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema definition for `maxim,control-channel-port` is missing the `default: 0` attribute, despite the description claiming it defaults to 0.
--

commit b689fa03621039bc6085fead24c8d25685588cc6
Author: Dumitru Ceclan <dumitru.ceclan@analog.com>

dt-bindings: media: i2c: max96712: add control-channel-port property

This commit adds the maxim,control-channel-port property to the MAX96712
device tree binding. It allows platforms to specify which deserializer
control-channel port connects to the upstream I2C host.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index 161d40acdd28f..538b639d4f542 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -41,6 +41,14 @@ properties:
>  
>    enable-gpios: true
>  
> +  maxim,control-channel-port:
> +    description:
> +      Selects which deserializer control-channel port is connected to the
> +      upstream I2C segment when the device resets. 0 selects port 0, 1 selects
> +      port 1. Defaults to 0 when omitted.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]

[Severity: Low]
The property description states it defaults to 0 when omitted. Should the
schema explicitly include a default: 0 attribute alongside the $ref and
enum keywords? Adding the explicit default would ensure that dt-schema
validators and other device tree tooling can formalize and properly validate
this behavior.

> +
>    i2c-alias-pool:
>      maxItems: 4

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-gmsl2-3_serdes-v13-0-9d8a4919983b@analog.com?part=10