Re: [PATCH v13 07/22] dt-bindings: media: i2c: max96712: add support for I2C ATR

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The numeric constraints `minimum` and `maximum` for the `reg` property are incorrectly placed under an `items` dictionary, causing them to be silently ignored during schema validation.
--

commit c417c9ed09d3bf57f1a0ad62e4ec0a271c4f0578
Author: Cosmin Tanislav <demonsingur@gmail.com>

dt-bindings: media: i2c: max96712: add support for I2C ATR

Document the capability of the MAX96712 and MAX96724 to change the I2C
address of connected serializers. This adds the i2c-atr object and
required properties to the device tree bindings.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index 583bbd60157c6..abacc3c874a9f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
[ ... ]
> @@ -36,6 +36,30 @@ properties:
>  
>    enable-gpios: true
>  
> +  i2c-alias-pool:
> +    maxItems: 4
> +
> +  i2c-atr:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:
> +      '^i2c@[0-3]$':
> +        $ref: /schemas/i2c/i2c-controller.yaml#
> +        unevaluatedProperties: false
> +        properties:
> +          reg:
> +            items:
> +              minimum: 0
> +              maximum: 3

[Severity: Low]
Is this the correct way to specify numeric constraints for the reg property?

In dt-schema, the reg property is evaluated as an array of arrays of integers.
By nesting minimum and maximum inside items, these numeric constraints apply to
the outer array's elements (which are arrays), and JSON Schema silently ignores
numeric constraints evaluated against non-numeric instances.

This allows device trees with out-of-bounds register values (e.g., reg = <4>)
to pass dt_binding_check without generating warnings.

Should the constraints be placed directly under reg instead, which dt-schema
automatically translates?

Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml seems to have
the same logic error for its reg bounds introduced in this patchset.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-gmsl2-3_serdes-v13-0-9d8a4919983b@analog.com?part=7