Re: [PATCH v3 02/10] arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit silently removes the `status = "okay";` override for the `&dispcc1` node and the `regulator-always-on` property from the `vreg_l6b` regulator without mentioning these functional changes in the commit message.
--

commit 225c01f9a1d48e2b3f638fa8c5a506daa682de98
Author: Jérôme de Bretagne <jerome.debretagne@gmail.com>

arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display

This commit adds the vreg_edp_3p3, edp_reg_en, and mdss0_dp3 nodes
to enable the eDP-based LCD display on the Surface Pro 9 5G.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
> index f24f60dc73afe..476e17415da27 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
[ ... ]
> @@ -344,7 +360,6 @@ vreg_l6b: ldo6 {
>  			regulator-max-microvolt = <880000>;
>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>  			regulator-boot-on;
> -			regulator-always-on;	// FIXME: VDD_A_EDP_0_0P9

[Severity: Medium]
The removal of regulator-always-on allows dynamic power management, which
seems correct for eDP enablement. Could this functional power management
cleanup be documented in the commit message?

>  		};
>  	};
>  
[ ... ]
> @@ -448,10 +463,6 @@ &dispcc0 {
>  	status = "okay";
>  };
>  
> -&dispcc1 {
> -	status = "okay";
> -};
> -

[Severity: Medium]
Is the silent removal of the dispcc1 status override intentional? 

Disabling the clock controller is a functional change. Should it be 
mentioned in the commit message to clarify the patch's impact and aid 
future bisectability?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-surface-sp9-5g-for-next-v3-0-6aa6f6612c10@gmail.com?part=2