Re: [PATCH v3 08/10] arm64: dts: qcom: sc8280xp-arcata: model the PMU of the on-board wcn6855

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between commit message claim and DT bindings for the bluetooth node's vddrfa supply.
--

commit 62919a7033473f4fbba869d7f0a02d1322f1605a
Author: Jérôme de Bretagne <jerome.debretagne@gmail.com>

arm64: dts: qcom: sc8280xp-arcata: model the PMU of the on-board wcn6855

This commit aligns the Surface Pro 9 5G model with other sc8280xp-based
models by adding a node for the PMU of the WCN6855. It reworks the inputs
for the wifi and bluetooth nodes to consume the PMU outputs. This also
removes the always-on properties for some regulators.

Link: https://lore.kernel.org/all/20241018-sc8280xp-pwrseq-v6-0-8da8310d9564@linaro.org/

> Use the fixed BT vddrfa1p7-supply supply name to align with bindings.

[Severity: Medium]
Does the qcom,wcn6855-bt.yaml binding actually require vddrfa1p8-supply
instead? Looking at the documentation in that file, vddrfa1p7-supply is
marked as deprecated and replaced by vddrfa1p8-supply.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
> index f92c37bfe9c72..d1f72cddebf1d 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
[ ... ]
> @@ -820,20 +892,16 @@ &uart2 {
>  	bluetooth {
>  		compatible = "qcom,wcn6855-bt";
>  
> -		vddio-supply = <&vreg_s10b>;
> -		vddbtcxmx-supply = <&vreg_s12b>;
> -		vddrfacmn-supply = <&vreg_s12b>;
> -		vddrfa0p8-supply = <&vreg_s12b>;
> -		vddrfa1p2-supply = <&vreg_s11b>;
> -		vddrfa1p7-supply = <&vreg_s1c>;
> +		vddrfacmn-supply = <&vreg_pmu_rfa_cmn_0p8>;
> +		vddaon-supply = <&vreg_pmu_aon_0p8>;
> +		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> +		vddwlmx-supply = <&vreg_pmu_wlmx_0p8>;
> +		vddbtcmx-supply = <&vreg_pmu_btcmx_0p8>;
> +		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> +		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> +		vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>;

[Severity: Medium]
Would it be better to update this property to vddrfa1p8-supply to match the
binding schema? The wifi@0 node updated earlier in this same patch
successfully migrated to vddrfa1p8-supply, so using the deprecated property
name here might cause dtbs_check validation failures.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-surface-sp9-5g-for-next-v3-0-6aa6f6612c10@gmail.com?part=8