Re: [PATCH v7 1/2] arm64: dts: qcom: sm8250: sort out Iris power domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The newly added 'mmcx' power domain is ignored by the 'venus' and 'iris' drivers, leaving MMCX unvoted and incorrectly lowering the MX domain voltage vote.
- [Low] Adding 'mmcx' to the 'power-domains' array without updating the dt-bindings schema causes a validation error.
--

commit 3e49b17a27a634436ceefec5a26bbe9a8584818e
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
arm64: dts: qcom: sm8250: sort out Iris power domains

This commit adds the MMCX power domain and required-opps to the venus
device node for the SM8250 platform.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 7076720413ab2..6150380795b81 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -4326,8 +4326,12 @@ venus: video-codec@aa00000 {
>  			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>  			power-domains = <&videocc MVS0C_GDSC>,
>  					<&videocc MVS0_GDSC>,
> -					<&rpmhpd RPMHPD_MX>;
> -			power-domain-names = "venus", "vcodec0", "mx";
> +					<&rpmhpd RPMHPD_MX>,
> +					<&rpmhpd RPMHPD_MMCX>;
> +			power-domain-names = "venus",
> +					     "vcodec0",
> +					     "mx",
> +					     "mmcx";

[Severity: Low]
Does adding mmcx here cause a dt-bindings validation error?

Looking at Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml,
the schema strictly enforces maxItems: 3 for power-domains and requires
exact matches for power-domain-names (venus, vcodec0, mx).

[ ... ]

> @@ -4353,22 +4357,26 @@ venus_opp_table: opp-table {
>  
>  				opp-720000000 {
>  					opp-hz = /bits/ 64 <720000000>;
> -					required-opps = <&rpmhpd_opp_low_svs>;
> +					required-opps = <&rpmhpd_opp_svs>,
> +							<&rpmhpd_opp_low_svs>;
>  				};

[Severity: High]
Will this result in MMCX remaining unvoted and MX receiving a lowered
voltage vote?

The venus and iris drivers both hardcode their OPP power domains to only
request mx:

drivers/media/platform/qcom/venus/core.c:sm8250_res
    .opp_pmdomain = (const char *[]) { "mx" },

drivers/media/platform/qcom/iris/iris_platform_gen1.c:sm8250_opp_pd_table
    static const char * const sm8250_opp_pd_table[] = { "mx" };

Because mmcx is never requested via devm_pm_domain_attach_list(), the OPP
framework assigns the first required-opps entry to mx, and silently skips
the second entry since it maps to an unattached device.

This appears to leave MMCX unmanaged while incorrectly lowering the MX
domain vote.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604-iris-venus-fix-sm8250-v7-0-7bd2f0e5bae8@oss.qualcomm.com?part=1