Re: [PATCH v2 1/5] dt-bindings: soc: cix,sky1-system-control: add audss system control

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `clock-controller` child node is unconditionally permitted for all compatible strings, instead of being restricted to the AUDSS variant.
--

commit f3ed58f974f3ca4d534c723c42d7c1e7eefe2139
Author: Joakim Zhang <joakim.zhang@cixtech.com>

dt-bindings: soc: cix,sky1-system-control: add audss system control

This commit adds the Cix Sky1 Audio Subsystem (AUDSS) syscon compatible string.
It introduces AUDSS software reset indices and adds an AUDSS internal clock
provider property.

> diff --git a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> --- a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
[ ... ]
> @@ -27,6 +32,11 @@ properties:
>    '#reset-cells':
>      const: 1
>  
> +  clock-controller:
> +    $ref: /schemas/clock/cix,sky1-audss-clock.yaml#
> +    description:
> +      AUDSS internal clock provider (cix,sky1-audss-system-control only).

[Severity: Medium]
Is this clock-controller child node unconditionally permitted for all
compatible strings in this binding?

Because it is introduced in the global properties block without an allOf
and if-then constraint to restrict its usage, does this allow device tree
nodes using the unrelated cix,sky1-system-control or
cix,sky1-s5-system-control compatibles to incorrectly declare a
clock-controller child node and silently pass schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605032225.523669-1-joakim.zhang@cixtech.com?part=1