Re: [PATCH v2 3/5] dt-bindings: clock: cix,sky1-audss-clock: add audss clock controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `clock-controller` child node in `cix,sky1-system-control.yaml` is not restricted to the `cix,sky1-audss-system-control` compatible string via an `if-then` conditional block.
--

commit f3ed58f974f3ca4d534c723c42d7c1e7eefe2139
Author: Joakim Zhang <joakim.zhang@cixtech.com>

dt-bindings: soc: cix,sky1-system-control: add audss system control

This commit adds the cix,sky1-audss-system-control compatible string to the
Sky1 system control binding. It exposes the software reset lines and adds the
clock-controller property for the AUDSS block.

> diff --git a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> index a01a515222c6d..3b243b02a7e8c 100644
> --- a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml
> +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml

[ ... ]

> @@ -27,6 +32,11 @@ properties:
>    '#reset-cells':
>      const: 1
>  
> +  clock-controller:
> +    $ref: /schemas/clock/cix,sky1-audss-clock.yaml#
> +    description:
> +      AUDSS internal clock provider (cix,sky1-audss-system-control only).
> +

[Severity: Medium]
In Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml,
since this property is defined at the top level without being restricted by
compatible strings, will dtbs_check incorrectly allow the clock-controller
child node on other variants like cix,sky1-system-control and
cix,sky1-s5-system-control?

Should this be wrapped in an allOf -> if-then block targeting only the
cix,sky1-audss-system-control compatible string to ensure schema validation
fails on incompatible variants?

>  required:
>    - compatible
>    - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605032225.523669-1-joakim.zhang@cixtech.com?part=3