Re: [PATCH v2 1/2] dt-bindings: media: i2c: add aptina,mt9m113

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing schema length constraints for `reset-gpios` and `powerdown-gpios` arrays.
- [Low] Binding strictly rejects standard camera properties by not referencing `video-interface-devices.yaml`.
--

commit 63f988e66ed5aa2849614f19a1ca36bc01146bb7
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: media: i2c: add aptina,mt9m113

Adds a new device tree binding for the Aptina MT9M113 1.3 megapixel image
sensor. The binding details the I2C address, optional GPIOs, regulators, and
the MIPI CSI-2 port configuration.

> diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> new file mode 100644
> index 0000000000000..7fa7cb2fedf96
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> @@ -0,0 +1,127 @@
[ ... ]
> +  vaa-supply:
> +    description:
> +      Analog voltage supply, 2.8V
> +
> +  reset-gpios:
> +    description: |-
> +      Reference to the GPIO connected to the RESET_BAR pin, if any (active
> +      low).
> +
> +  powerdown-gpios:
> +    description: |-
> +      Reference to the GPIO connected to the STANDBY/PWDN pin, if any (active
> +      high). When asserted, the sensor enters low-power standby mode.

[Severity: Low]
Should these properties include a maxItems: 1 constraint? 

In Device Tree schemas, properties with the -gpios suffix map to arrays.
Without an explicit maximum length, dt-schema validation might allow arrays
of any length to pass. Since the hardware has exactly one reset pin and one
standby pin, enforcing a limit of 1 seems appropriate here to ensure strict
validation.

> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdd-supply
> +  - vddio-supply
> +  - vaa-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Low]
Does this schema need a reference to 
/schemas/media/video-interface-devices.yaml# before strictly disallowing
additional properties?

Camera sensors frequently require standard physical properties like rotation,
orientation, or flash-leds to describe how they are mounted on the board.
Setting additionalProperties to false without including the standard video
interface device schema will erroneously reject valid device trees that use
these common properties.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605-submit-media-mt9m113-v2-0-de1cc807f4cf@herrie.org?part=1