Re: [PATCH 8/13] ASoC: qcom: Add generic of_xlate_dai_name helper to common

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compilation failure due to conflicting static and non-static declarations of `asoc_qcom_of_xlate_dai_name`.
--

commit 49b02ad6fd90538b16f9ce1c7f6c4b2db0f7936f
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: qcom: Add generic of_xlate_dai_name helper to common

Multiple Qualcomm ASoC CPU DAI drivers need to resolve a sound-dai phandle
argument to a DAI name. This commit extracts the common logic into
asoc_qcom_of_xlate_dai_name() in common.c so it can be shared.

[ ... ]
> diff --git a/sound/soc/qcom/common.h b/sound/soc/qcom/common.h
> index ee6662885593c..5baf51a39c975 100644
> --- a/sound/soc/qcom/common.h
> +++ b/sound/soc/qcom/common.h
[ ... ]
> @@ -15,5 +16,9 @@ int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime *rtd,
>  int qcom_snd_dp_jack_setup(struct snd_soc_pcm_runtime *rtd,
>  			   struct snd_soc_jack *dp_jack, int id);
>  
> +int asoc_qcom_of_xlate_dai_name(const struct snd_soc_dai_driver *dai_drv,
> +				int num_dai,
> +				const struct of_phandle_args *args,
> +				const char **dai_name);
>  
>  #endif

[Severity: Low]
Does this new declaration break the build when included by lpass-cpu.c?

There is an existing static function in sound/soc/qcom/lpass-cpu.c with the
exact same name but a different signature:

static int asoc_qcom_of_xlate_dai_name(struct snd_soc_component *component,
                                       const struct of_phandle_args *args,
                                       const char **dai_name)

Since lpass-cpu.c indirectly includes common.h, the compiler will see the
non-static declaration followed by the static definition, resulting in a
conflicting types error. 

While this is fixed later in the series by commit 761cbeeaa59f ("ASoC: qcom:
lpass-cpu: Use asoc_qcom_of_xlate_dai_name helper"), could we avoid the
conflict in this patch to keep the commit history bisectable?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605103739.3557573-1-harendra.gautam@oss.qualcomm.com?part=8