Re: [PATCH 2/13] dt-bindings: sound: Add Qualcomm QAIF binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The property `qcom,qaif-aif-bits-per-lane` directly contradicts its own description and example, creating severe ambiguity for device tree authors and driver implementations.
--

commit 156362ec3cefdde2ab7850355d1276f1ccef3348
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

dt-bindings: sound: Add Qualcomm QAIF binding

This commit adds a DeviceTree binding for the Qualcomm Audio Interface (QAIF)
CPU DAI controller used on the Shikra audio platform. It describes the MMIO
region, clocks, interrupts, DMA IOMMU mapping, and per-interface AIF child
nodes.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,qaif.yaml b/Documentation/devicetree/bindings/sound/qcom,qaif.yaml
> new file mode 100644
> index 0000000000000..9c4371f13ff3b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,qaif.yaml

[ ... ]

> +      qcom,qaif-aif-full-cycle-en:
> +        type: boolean
> +        description: Enable full-cycle sync (effective in sync master mode).
> +      qcom,qaif-aif-bits-per-lane:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description:
> +          Number of slots per lane. The frame length is computed as
> +          slot-width multiplied by bits-per-lane.

[Severity: Medium]
Does the property name qcom,qaif-aif-bits-per-lane contradict its intended
meaning?

The description defines it as the number of slots per lane and explains that
the frame length is computed by multiplying the slot-width (which is in bits)
by this value. 

If this property actually represents a dimensionless slot count, would it be
clearer to name it qcom,qaif-aif-slots-per-lane?

Naming a slot count property bits-per-lane might lead authors to incorrectly
configure it as a bit count instead of a slot count.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605103739.3557573-1-harendra.gautam@oss.qualcomm.com?part=2